From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arodriguez@callistech.com>
Received: from mail-qc0-f169.google.com (mail-qc0-f169.google.com
 [209.85.216.169]) by dpdk.org (Postfix) with ESMTP id 853E77F1C
 for <dev@dpdk.org>; Wed, 29 Oct 2014 02:58:46 +0100 (CET)
Received: by mail-qc0-f169.google.com with SMTP id i17so1686589qcy.28
 for <dev@dpdk.org>; Tue, 28 Oct 2014 19:07:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:date:message-id:subject:from:to
 :content-type;
 bh=UzvmbjtI+s+KfnFTEsxr3Nxtsqo4OWtRh+9otRSy43Y=;
 b=iiMZMsfBKkGB0fCxBmUb38GDKNBFzyH5OMBxxes6L8crbkMePMOO3F8kMOJbpk5ywY
 IcBfb74OPV4f+d8eVRqy9JN5gW9KB2f30C8AChkXAshyYKigkhP3Fo3YTN+7noI3JYlq
 Y+NSPe11/6j4j/qY4cUX0lqn2coQJJpXjl9R3Ca7mfhdcLSE5gB9YEJPpU+N9lRILUzu
 5m8kgZOSK97Vc0MRNWShiK0OE/aXtdeC/7RfrwP9zOh5G4uHbGlHyDDYTJe/roiJH2v/
 MaIR4MSKWUV9QxGCdTzPbPeWT5WB8PLpUzPeWDhvDvio9B7NKKRsYonAvPOZTYb3pAH8
 KrZA==
X-Gm-Message-State: ALoCoQlEmrKqF+4D5G+DzaqPPI3YA/Agrifa7zOAwXhyTcNK1J2GB78bbfA3Qxi+jTniqePQ/Hts
MIME-Version: 1.0
X-Received: by 10.229.84.72 with SMTP id i8mr11044409qcl.7.1414548455477; Tue,
 28 Oct 2014 19:07:35 -0700 (PDT)
Received: by 10.140.240.194 with HTTP; Tue, 28 Oct 2014 19:07:35 -0700 (PDT)
Date: Tue, 28 Oct 2014 23:07:35 -0300
Message-ID: <CADoa0bbog5n7gsPU7013Jp8d584dCh_pT+w+pxCVtWMjnLkOGA@mail.gmail.com>
From: Ariel Rodriguez <arodriguez@callistech.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() call
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Oct 2014 01:58:46 -0000

Hi, im trying the kni example. When i hit ctrl-c in the terminal  stopping
the example, the os signals  with a segmentation fault.

The issue is in this block of code:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

-- for (i = 0; i < p[i]->nb_kni; i++) {
-- rte_kni_release(p[i]->kni[i]);
-- p[i]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}


The following change fix that issue:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

++ for (i = 0; i < p[port_id]->nb_kni; i++) {
++ rte_kni_release(p[port_id]->kni[i]);
++ p[port_id]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}

Sorry for the basic of my fix ... i dont know  the correct style to report
this kind of issues... im just a user of the dpdk library ... but i meet
this bug ...


Regards.

Ariel Horacio Rodriguez.