From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <steeven@gmail.com>
Received: from mail-io0-f170.google.com (mail-io0-f170.google.com
 [209.85.223.170]) by dpdk.org (Postfix) with ESMTP id 337F59254
 for <dev@dpdk.org>; Tue,  5 Jan 2016 11:20:51 +0100 (CET)
Received: by mail-io0-f170.google.com with SMTP id q21so181968420iod.0
 for <dev@dpdk.org>; Tue, 05 Jan 2016 02:20:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=hr+EBcly4ej80L3ONPUJ3Uqi3qtNv7mEGfGvR3UgagE=;
 b=sTq7fp1h9/zHRsa6jfh9+efB+5kEyRFlqSWdWdQyE9OCAaLVoVTwlk62qosbklqOzG
 a4bfj93ANgiRYon/31dVBIDTkZQb0qucFxBR1faTih3jpP3lXn1tqVJ4IBJ7AkVm99Qr
 pqR+GviDIzyl6I3d46RGQZtLWTsuRzJMoiaa8UPaaGHksxbNf0VqgF1JsPITehGKIMvV
 mxKJAjNdKl855jkz7M2jXkubj6eG2zcrStPeR73oi9pKhslQNURuc5hnEJdNRq2Uwo+4
 RTOoEWd0+2g4YPs9q9SCvsIRvzGw0Zit1eLkryyiowwpmsNUwZEuT6HQYKmof2Jo2H11
 3ZDA==
MIME-Version: 1.0
X-Received: by 10.107.16.27 with SMTP id y27mr85240245ioi.21.1451989250650;
 Tue, 05 Jan 2016 02:20:50 -0800 (PST)
Received: by 10.107.27.9 with HTTP; Tue, 5 Jan 2016 02:20:50 -0800 (PST)
In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F04CF5@SHSMSX101.ccr.corp.intel.com>
References: <CADvXkJ4rowM8vE1BUzOWuSVU_CpZii+q5ydsLihNNo7Pgij4Tg@mail.gmail.com>
 <533710CFB86FA344BFBF2D6802E6028622F04CF5@SHSMSX101.ccr.corp.intel.com>
Date: Tue, 5 Jan 2016 18:20:50 +0800
Message-ID: <CADvXkJ6HYXELrM-qzdm_KHBtXrQO5ut7iJzE7uwZDn4RVRWwwQ@mail.gmail.com>
From: steeven lee <steeven@gmail.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix examples build failure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2016 10:20:51 -0000

Hi Michael:

Seems the examples makefile seems to be broken, easy to reproduce on
master branch, below is the outputs on Ubuntu 14.04 amd64 version:

~/work/dpdk$ export RTE_SDK=/home/steeven/work/dpdk
~/work/dpdk$ cd /home/steeven/work/dpdk/examples/helloworld/
~/work/dpdk/examples/helloworld$ export RTE_TARGET=x86_64-native-linuxapp-gcc
~/work/dpdk/examples/helloworld$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.
~/work/dpdk/examples/helloworld$ cd ../cmdline/
~/work/dpdk/examples/cmdline$ make
/home/steeven/work/dpdk/mk/internal/rte.extvars.mk:57: *** Cannot find
.config in /home/xueming/work/dpdk.  Stop.


Thanks,
Steeven

On Mon, Dec 28, 2015 at 12:20 PM, Qiu, Michael <michael.qiu@intel.com> wrote:
> On 12/24/2015 8:38 PM, steeven lee wrote:
>> 1. Fix examples build failure
>> 2. make build as default output folder name
>>
>> Signed-off-by: steeven <steeven@gmail.com>
>> ---
>>  mk/internal/rte.extvars.mk | 4 ++--
>>  mk/rte.extsubdir.mk        | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk
>> index 040d39f..cabef0a 100644
>> --- a/mk/internal/rte.extvars.mk
>> +++ b/mk/internal/rte.extvars.mk
>> @@ -52,9 +52,9 @@ RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
>>  export RTE_EXTMK
>>
>>  # RTE_SDK_BIN must point to .config, include/ and lib/.
>> -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET)
>> +RTE_SDK_BIN := $(RTE_SDK)/build
>>  ifeq ($(wildcard $(RTE_SDK_BIN)/.config),)
>> -$(error Cannot find .config in $(RTE_SDK))
>> +$(error Cannot find .config in $(RTE_SDK_BIN))
>>  endif
>>
>>  #
>> diff --git a/mk/rte.extsubdir.mk b/mk/rte.extsubdir.mk
>> index f50f006..819020a 100644
>> --- a/mk/rte.extsubdir.mk
>> +++ b/mk/rte.extsubdir.mk
>> @@ -46,7 +46,7 @@ $(DIRS-y):
>>         @echo "== $@"
>>         $(Q)$(MAKE) -C $(@) \
>>                 M=$(CURDIR)/$(@)/Makefile \
>> -               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \
>> +               O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \
>>                 BASE_OUTPUT=$(BASE_OUTPUT) \
>>                 CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \
>>                 S=$(CURDIR)/$(@) \
>
> Could you show your compile error log? And how to reproduce it?
>
> Thanks,
> Michael