From: Lance Richardson <lance.richardson@broadcom.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"maicolgabriel@hotmail.com" <maicolgabriel@hotmail.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32
Date: Thu, 5 Nov 2020 08:41:46 -0500 [thread overview]
Message-ID: <CADyeNEA2=0g0p=k8Fj0G3UV6d8O8kei78mo_qQJoRYdrYackYA@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0802MB23512AD6CC32A11E8704DE9D9EEE0@VI1PR0802MB2351.eurprd08.prod.outlook.com>
> > Hi Juraj,
> >
> > I might be missing something, but I don't
> > believe these changes are sufficient to
> > enable vector mode for ARM32. For one
> > thing, bnxt_receive_function() in bnxt_ethdev.c
> > would need to be changed to enable the
> > selection of the vector receive function.
>
> Hi Lance,
>
> This patch set aimed to enable aarch32 compilation and run some basic unit tests.
> So changes in this patch fixed some 'symbol not found' issues when building for aarch32.
> However, it do need a respin because a patch that changed Arm flags has been merged.
>
> >
> > Also, meson.build has this condition
> > for building bnxt_rxtx_vec_neon.c:
> >
> > if arch_subdir == 'x86'
> > sources += files('bnxt_rxtx_vec_sse.c')
> > elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64')
> > sources += files('bnxt_rxtx_vec_neon.c')
> > endif
> >
> > Were you able to build with these changes
>
> Yes. I was able to build with these changes.
> As you can find in 3/5 of this patch set, aarch32 uses (cpu_family = 'aarch64').
> So condition in meson.build is not a problem.
>
> > and confirm that the vector mode functions
> > are selected and used? (There is a log at INFO
> > level to indicate which function is selected,
> > as should "show rxq info ..." from the
> > testpmd CLI.
> >
> > Thanks,
> Thanks for your review.
> >
> > Lance
Hi Juraj,
Have you tried building with this patch set lately? Changes
have been made to bnxt_rxtx_vec_neon.c for 20.11 that
require 64-bit (for example, the intrinsic vzip1q_u32() is
used, this intrinsic is only available for 64-bit targets), as
I was able to confirm by applying your patch set and
attempting to build.
I think the only change that is actually needed is this
in drivers/net/bnxt/meson.build:
-elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64')
+elif arch_subdir == 'arm' and
host_machine.cpu_family().startswith('aarch64') and
dpdk_conf.get('RTE_ARCH_64')
BTW, there are compilation failures in sfc_efx due to lack
of support for __int128 for Arm 32-bit targets.
Thanks,
Lance
next prev parent reply other threads:[~2020-11-05 13:42 UTC|newest]
Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:03 [dpdk-dev] [PATCH v3 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-04-15 9:03 ` [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to meson Juraj Linkeš
2020-04-15 11:45 ` Luca Boccassi
2020-04-16 6:16 ` Juraj Linkeš
2020-04-16 8:53 ` Luca Boccassi
2020-04-16 11:25 ` Juraj Linkeš
2020-04-16 12:00 ` Luca Boccassi
2020-04-16 12:22 ` Juraj Linkeš
2020-04-16 15:11 ` Ruifeng Wang
2020-04-15 9:03 ` [dpdk-dev] [PATCH v3 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-04-15 9:03 ` [dpdk-dev] [PATCH v3 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-04-15 9:03 ` [dpdk-dev] [PATCH v3 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 1/4] build: disable vhost NUMA for arm32 Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-05-05 18:56 ` Aaron Conole
2020-05-11 7:05 ` Juraj Linkeš
2020-07-06 8:28 ` [dpdk-dev] [PATCH v5 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-07-06 8:28 ` [dpdk-dev] [PATCH v5 1/4] build: disable vhost NUMA for arm32 Juraj Linkeš
2020-07-06 8:56 ` David Marchand
2020-07-06 8:28 ` [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-07-06 9:11 ` Jerin Jacob
2020-07-07 20:44 ` Honnappa Nagarahalli
2020-07-08 8:33 ` Jerin Jacob
2020-07-08 20:55 ` Honnappa Nagarahalli
2020-07-09 4:49 ` Jerin Jacob
2020-07-06 8:28 ` [dpdk-dev] [PATCH v5 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-07-06 8:28 ` [dpdk-dev] [PATCH v5 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-07-06 9:11 ` Juraj Linkeš
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-14 2:10 ` Ruifeng Wang
2020-08-13 9:21 ` [dpdk-dev] [PATCH v6 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-19 17:45 ` Ajit Khaparde
2020-08-20 3:00 ` Ruifeng Wang
2020-08-20 9:13 ` Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-14 10:31 ` [dpdk-dev] [PATCH v7 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-25 19:05 ` Ajit Khaparde
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-25 14:16 ` Aaron Conole
2020-08-26 6:21 ` Juraj Linkeš
2020-08-25 13:04 ` [dpdk-dev] [PATCH v8 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-25 14:03 ` Aaron Conole
2020-08-26 3:12 ` Phil Yang
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-28 11:38 ` [dpdk-dev] [PATCH v9 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-09-11 13:20 ` Aaron Conole
2020-09-16 8:04 ` Juraj Linkeš
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-11-04 18:30 ` Lance Richardson
2020-11-05 7:20 ` Ruifeng Wang
2020-11-05 13:41 ` Lance Richardson [this message]
2020-11-05 15:13 ` Ruifeng Wang
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-10-21 14:24 ` Ruifeng Wang
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-10-21 14:27 ` Ruifeng Wang
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-10-21 14:29 ` Ruifeng Wang
2020-09-16 8:21 ` [dpdk-dev] [PATCH v10 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-10-21 14:32 ` Ruifeng Wang
2020-10-21 11:42 ` [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-10-21 11:52 ` Thomas Monjalon
2020-10-28 9:22 ` Jerin Jacob
2020-11-30 14:03 ` Aaron Conole
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 0/7] " Juraj Linkeš
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2020-12-09 13:37 ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 2/7] net/bnxt: " Juraj Linkeš
2020-12-09 14:10 ` Lance Richardson
2020-12-09 14:16 ` Ruifeng Wang
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 3/7] net/bnxt: add support for aarch32 Juraj Linkeš
2020-12-09 13:59 ` Lance Richardson
2020-12-09 14:11 ` Ruifeng Wang
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 4/7] build: add aarch32 meson build flags Juraj Linkeš
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-12-09 15:29 ` Aaron Conole
2020-12-09 12:59 ` [dpdk-dev] [PATCH v11 7/7] doc: add aarch32 build guidance Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 0/6] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 1/6] net/sfc: fix aarch32 build Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 2/6] net/bnxt: " Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 3/6] build: add aarch32 meson build flags Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 4/6] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 5/6] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-12-11 8:26 ` [dpdk-dev] [PATCH v12 6/6] doc: add aarch32 build guidance Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 2/7] net/bnxt: " Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 3/7] net/virtio: " Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 4/7] build: add aarch32 meson build flags Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-03-09 8:36 ` [dpdk-dev] [PATCH v13 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-03-09 13:46 ` Aaron Conole
2021-03-17 13:35 ` [dpdk-dev] [PATCH v14 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-03-17 13:35 ` [dpdk-dev] [PATCH v14 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-03-17 13:35 ` [dpdk-dev] [PATCH v14 2/7] net/bnxt: " Juraj Linkeš
2021-03-17 13:35 ` [dpdk-dev] [PATCH v14 3/7] net/virtio: " Juraj Linkeš
2021-03-17 13:36 ` [dpdk-dev] [PATCH v14 4/7] build: add aarch32 meson build flags Juraj Linkeš
2021-03-17 13:36 ` [dpdk-dev] [PATCH v14 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-03-17 13:36 ` [dpdk-dev] [PATCH v14 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-03-17 13:36 ` [dpdk-dev] [PATCH v14 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 0/8] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build Juraj Linkeš
2021-04-21 9:04 ` Andrew Rybchenko
2021-04-21 10:06 ` Ruifeng Wang
2021-04-21 14:08 ` Juraj Linkeš
2021-04-21 14:20 ` Andrew Rybchenko
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 2/8] net/bnxt: " Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 3/8] net/virtio: " Juraj Linkeš
2021-04-21 9:16 ` Maxime Coquelin
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags Juraj Linkeš
2021-04-21 14:28 ` Juraj Linkeš
2021-04-22 5:32 ` Ruifeng Wang
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 5/8] build: add aarch32 meson build flags Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 6/8] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 7/8] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-04-21 8:50 ` [dpdk-dev] [PATCH v16 8/8] doc: add aarch32 build guidance Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 0/8] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 1/8] net/sfc: fix aarch32 build Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 2/8] net/bnxt: " Juraj Linkeš
2021-04-22 18:50 ` Ajit Khaparde
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 3/8] net/virtio: " Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 4/8] eal/arm: update CPU flags Juraj Linkeš
2021-04-25 7:03 ` Ruifeng Wang
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 5/8] build: add aarch32 meson build flags Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 6/8] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 7/8] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-04-22 12:49 ` [dpdk-dev] [PATCH v17 8/8] doc: add aarch32 build guidance Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 2/7] net/bnxt: " Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 3/7] net/virtio: " Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 4/7] eal/arm: update CPU flags Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 5/7] build: add aarch32 meson build flags Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 6/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-07-07 13:25 ` [dpdk-dev] [PATCH v18 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-07-09 18:19 ` [dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEA2=0g0p=k8Fj0G3UV6d8O8kei78mo_qQJoRYdrYackYA@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=maicolgabriel@hotmail.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).