From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19A2EA04DD; Thu, 5 Nov 2020 14:42:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36A2CC7EC; Thu, 5 Nov 2020 14:42:01 +0100 (CET) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id B3282C7EA for ; Thu, 5 Nov 2020 14:41:59 +0100 (CET) Received: by mail-oi1-f196.google.com with SMTP id z26so1705930oid.1 for ; Thu, 05 Nov 2020 05:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q7MpgoegpdyoTJ2sBG9ehMjGWAjTvrnYoWW6Z9d6g6s=; b=GLojCz6f8Th6PKMhLARnh21lyDdY//SYUhdGRnzKwaAKZRp0ITTQvnw5fdJb4kjV/z uahI7zzzjXT+7qzlDXFLnV+r1265oH6GmaY/U+cHTvTS7yia7TPIL3sB+VO5iPk+hn+c 9wNo3oi7O7ld2/Vq2FaPBITKD7X6nypbiAnLs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q7MpgoegpdyoTJ2sBG9ehMjGWAjTvrnYoWW6Z9d6g6s=; b=o+rmtFjdRNc3sncqu1SKnsaWUwYM9weKN3f43vevEOsBggoejHkQ72QzrofcFKperx XnNJGPzR1zQYisiWPayve1kZS3ugdrdveL+oU7YsGMKhQK8kW+JVqRb2fM1raunP6MyP jrxAjGU6Zc3EEq+IEbl5Ojov4udTg88UOYY9cXayj+eeQr2tjK5CXK7tOkjXUI2oLWcY KwV0cwt3uGB79G/xUsHdrAS8MCN8AS9x7GuS1MPBAcF62o/Bwe+hJv4aowIKxktikcVT 849r2qxYvzA1+B07cX+9QzsV0HSocDb5bBKigf1kHw19Rfrf+jIRvtGrxeWGo7iJXiYG A6pw== X-Gm-Message-State: AOAM532agNRmmxcQ/q2nW0rxuv91XWIM9ftMN5X94oyGYVL49SvJO1vN 82DRZdJYYhyQUxuYcfRWk7LJz6D6I3ZUPcRyncLblA== X-Google-Smtp-Source: ABdhPJz3RCVfzyEeyEV4ScSzrssy7dwYWboCnnpv0avub+o9Y6mJAnLgP+Xjm03UGiyg7OKqz8VMzMiSJ51yHoyCyug= X-Received: by 2002:aca:fdc8:: with SMTP id b191mr998587oii.19.1604583717806; Thu, 05 Nov 2020 05:41:57 -0800 (PST) MIME-Version: 1.0 References: <1598614733-16220-1-git-send-email-juraj.linkes@pantheon.tech> <1600244472-29696-1-git-send-email-juraj.linkes@pantheon.tech> <1600244472-29696-2-git-send-email-juraj.linkes@pantheon.tech> In-Reply-To: From: Lance Richardson Date: Thu, 5 Nov 2020 08:41:46 -0500 Message-ID: To: Ruifeng Wang Cc: =?UTF-8?Q?Juraj_Linke=C5=A1?= , "thomas@monjalon.net" , Bruce Richardson , "aconole@redhat.com" , "maicolgabriel@hotmail.com" , "dev@dpdk.org" , nd Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Hi Juraj, > > > > I might be missing something, but I don't > > believe these changes are sufficient to > > enable vector mode for ARM32. For one > > thing, bnxt_receive_function() in bnxt_ethdev.c > > would need to be changed to enable the > > selection of the vector receive function. > > Hi Lance, > > This patch set aimed to enable aarch32 compilation and run some basic unit tests. > So changes in this patch fixed some 'symbol not found' issues when building for aarch32. > However, it do need a respin because a patch that changed Arm flags has been merged. > > > > > Also, meson.build has this condition > > for building bnxt_rxtx_vec_neon.c: > > > > if arch_subdir == 'x86' > > sources += files('bnxt_rxtx_vec_sse.c') > > elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64') > > sources += files('bnxt_rxtx_vec_neon.c') > > endif > > > > Were you able to build with these changes > > Yes. I was able to build with these changes. > As you can find in 3/5 of this patch set, aarch32 uses (cpu_family = 'aarch64'). > So condition in meson.build is not a problem. > > > and confirm that the vector mode functions > > are selected and used? (There is a log at INFO > > level to indicate which function is selected, > > as should "show rxq info ..." from the > > testpmd CLI. > > > > Thanks, > Thanks for your review. > > > > Lance Hi Juraj, Have you tried building with this patch set lately? Changes have been made to bnxt_rxtx_vec_neon.c for 20.11 that require 64-bit (for example, the intrinsic vzip1q_u32() is used, this intrinsic is only available for 64-bit targets), as I was able to confirm by applying your patch set and attempting to build. I think the only change that is actually needed is this in drivers/net/bnxt/meson.build: -elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64') +elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64') and dpdk_conf.get('RTE_ARCH_64') BTW, there are compilation failures in sfc_efx due to lack of support for __int128 for Arm 32-bit targets. Thanks, Lance