From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 574F3A04E7; Thu, 5 Nov 2020 19:03:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E2C51D9E; Thu, 5 Nov 2020 19:03:00 +0100 (CET) Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by dpdk.org (Postfix) with ESMTP id 583A6F64 for ; Thu, 5 Nov 2020 19:02:59 +0100 (CET) Received: by mail-oo1-f66.google.com with SMTP id c25so641158ooe.13 for ; Thu, 05 Nov 2020 10:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6dM9COSdp57zeQZ2H6eUiu+3pF2tKhwKzDBbF/IAmBo=; b=WY/MF8ZH2zeBhVKoPwncxagra/SaAZwZ0g74rOof494SCvAsjTQ5W/vWbv/KB37U8I lJ7z6FsIyPk+7Q2Pulql0bdW2QXrAH+Zmue5pH7QpJInMvfsE725ZlDypIuVAH16hwk8 rP3TjrvuX6fi4faKyTTbOf2wBiIypWT0THbZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6dM9COSdp57zeQZ2H6eUiu+3pF2tKhwKzDBbF/IAmBo=; b=cM4JEwAYWE2/KvTlAALCbD+Jz0gW69IAwwPfHs1R5FM7UHPZHI7eWrVWdsfhjENulU /eIBgLTJ83ynPhN2OL2cRj5Qas64bWJmLnrXdvu2K6ePoRU7d+ulyr++gCAzshLDvaBc OmAJyrKFwyPG3D54UBNOSiISXo1wZpWUcWphALFhqerYW151+f36ZuSC0/CrWYYtLxve xpVynBfA4qi64JqX1UgGuwR5P31QmUIGY5/4TCikSro30NFvUD4OpDP7E0WcyX+zvrDx 4xGjcj07C4UDu8gexemtn07ULJR+Z6h8roJ9pmPGks9OLLAcrJjUhnkStt/bIELEE5bY fXzA== X-Gm-Message-State: AOAM532yL9zWHDl2JzOCY+QxcTdWBPu//51prnf+2juKdaP0EVAQvkzP OuEiyPJI63FDHgoSVrwK0MQubttRywKISS5I1Wv0dQ== X-Google-Smtp-Source: ABdhPJzsIP0SUdtcWhAbUij5Mxb7h6iXorqDBpy0Vh4mc72xFs4DVl5TCnLAo7osizIJA3WrPiXFSBapn9JZjODafFw= X-Received: by 2002:a4a:9806:: with SMTP id y6mr2653975ooi.45.1604599377250; Thu, 05 Nov 2020 10:02:57 -0800 (PST) MIME-Version: 1.0 References: <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com> <20201105174424.4131345-1-thomas@monjalon.net> In-Reply-To: <20201105174424.4131345-1-thomas@monjalon.net> From: Lance Richardson Date: Thu, 5 Nov 2020 13:02:46 -0500 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , David Marchand , Olivier Matz , Andrew Rybchenko , Maxime Coquelin , stable@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Steve Yang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 5, 2020 at 12:51 PM Thomas Monjalon wrote: > > The fix of max_rx_pkt_len for allowing VLAN packets in all cases > was breaking configuration of some drivers. Example with virtio: > > Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 > Fail to configure port 0 > > Trying to fix the logic was revealing other issues in some drivers. > That's why it is decided to revert. > > The workaround for the original issue would be > to set the MTU explicitly from the application > with rte_eth_dev_set_mtu(). > > Fixes: f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet") > Cc: stable@dpdk.org > > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > --- Acked-by: Lance Richardson