From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E9229A045E for ; Mon, 27 May 2019 20:50:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9D3EA49; Mon, 27 May 2019 20:50:16 +0200 (CEST) Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by dpdk.org (Postfix) with ESMTP id 979E89E4 for ; Mon, 27 May 2019 20:50:15 +0200 (CEST) Received: by mail-oi1-f195.google.com with SMTP id v2so12502149oie.6 for ; Mon, 27 May 2019 11:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HSUZ2eRIW8d6sqBbEc4dnGIqZJnI2PLuxpxaoHo7czI=; b=OtxBkHOjmE1++pbKu6nKBy5LrA1HQ8U15nxDzHjAlReie45OAeVNDTO54hUL8flfgk ZLqToD1RBArGDgbH4+ujG2UKClsPSAQSku0QF5tu2yaBiSx+esu0lqTRxxgQ9mEnDwvV syHfylvcTgoL2p5vlDjr1ddykR2BFV9dtxjoQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HSUZ2eRIW8d6sqBbEc4dnGIqZJnI2PLuxpxaoHo7czI=; b=rwsUk6VxkfzKneIg01wmQP4xJlNU8+LDsNG5zopdGahC/GLo+lwwmuXXyUHHub9bHJ DEHl3ijXOdvaWGj1UfjS+WxUSVIMLf/ZV+X61PK7yNy93f5Sl7xHjgQyL5jqgn3p7Q7u wbKoIBFLVlmKfVnH2a/YQrdDJp4gOynq6Wzw72hNHuhJgf67CL1U1HUri/8lB+vl+xhs t9vk3VY3gBQx9uOI8/wEV5yhzV3ubyFRbXwI3BYViX0eKvhZcqgtMZyzuwAixpujbxPm vFzL0T565/T5Oo/wItAxEMo01XR9f9T27BB7oBAo6BP1VtLePh0OZf2x5NYdV4ueOiKB FFIA== X-Gm-Message-State: APjAAAWnJsrp6tEtkDdKgOCfc7hDDsq8kahdyn9CCCialDhGn9EonGlq RB0pE5K9lFvNKggf2e30c0bgRjCU7Bgsd591QojXPw== X-Google-Smtp-Source: APXvYqw4KpPf4TquTCGiVOKTb8bAesB/6scajUozChsaFSRbBhmqAA4QYYBtp6sYRQxUfyjxeTosL6qqOxwvsfUi44M= X-Received: by 2002:aca:b108:: with SMTP id a8mr245437oif.81.1558983014901; Mon, 27 May 2019 11:50:14 -0700 (PDT) MIME-Version: 1.0 References: <20190521213953.25425-1-ajit.khaparde@broadcom.com> <20190524144935.18765-1-lance.richardson@broadcom.com> <20190524144935.18765-2-lance.richardson@broadcom.com> In-Reply-To: From: Lance Richardson Date: Mon, 27 May 2019 14:50:04 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Ajit Khaparde , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 01/10] net/bnxt: move tx bd checking to header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Apologies for the confusion. Regards, Lance On Mon, May 27, 2019 at 11:24 AM Ferruh Yigit wrote: > > On 5/27/2019 10:36 AM, Ferruh Yigit wrote: > > On 5/24/2019 3:49 PM, Lance Richardson wrote: > >> To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between > >> vector-mode and non-vector transmit functions, move these functions > >> into bnxt_txr.h. > >> > >> Signed-off-by: Lance Richardson > >> Reviewed-by: Ajit Khaparde > >> Reviewed-by: Maxime Coquelin > >> --- > >> drivers/net/bnxt/bnxt_txr.c | 15 --------------- > >> drivers/net/bnxt/bnxt_txr.h | 15 +++++++++++++++ > >> 2 files changed, 15 insertions(+), 15 deletions(-) > >> > >> diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c > >> index 9de12e0d0..16598ba63 100644 > >> --- a/drivers/net/bnxt/bnxt_txr.c > >> +++ b/drivers/net/bnxt/bnxt_txr.c > >> @@ -103,21 +103,6 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id) > >> return 0; > >> } > >> > >> -static inline uint32_t bnxt_tx_bds_in_hw(struct bnxt_tx_queue *txq) > >> -{ > >> - return ((txq->tx_ring->tx_prod - txq->tx_ring->tx_cons) & > >> - txq->tx_ring->tx_ring_struct->ring_mask); > >> -} > > > > I can't find this function at all, am I doing something wrong? > > Can you please confirm if this function is upstreamed at all? > > > > $ git co v19.05 > > $ git grep bnxt_tx_bds_in_hw > > $ echo $? > > 1 > > > > Ah, it is coming from "bnxt patchset for Tx performance optimization" patchset, > I will check it first. > (It is good to write dependency information clearly in the cover letter of the > patchset)