From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8CA8FA0C42;
Fri, 7 May 2021 23:35:34 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 07C1C4013F;
Fri, 7 May 2021 23:35:34 +0200 (CEST)
Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com
[209.85.167.172])
by mails.dpdk.org (Postfix) with ESMTP id C567540040
for <dev@dpdk.org>; Fri, 7 May 2021 23:35:31 +0200 (CEST)
Received: by mail-oi1-f172.google.com with SMTP id v24so9973862oiv.9
for <dev@dpdk.org>; Fri, 07 May 2021 14:35:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=44GrYoAvgf/TnHvki0R1NKrxihG+F/OcMXIuwHFE6hc=;
b=QhdyKvIaXfJTCPSHjJPQlInb6tQBsB9TCiglurFnwNzK09dI1MVzjA+4CsV/cZLg21
0sKd6uu7MxxtOY1mg4bQm5/GFDr5StjDJNkdk+lOEBK+cAocWS0R6tsfC31kJaf2AFF0
V/uguLC0UM0qCwjDunfmmENKIDC+m+Uh51FCo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=44GrYoAvgf/TnHvki0R1NKrxihG+F/OcMXIuwHFE6hc=;
b=AJSMulDPbkQjLwuoC4QXKUa6pHGEAwVcijfzwd66fn0HV6yNW+4+ZOnchYrK8PQDF6
tf5y/Mo4G8XJA0/Mx20vhfdeb164lDESk3W8GucX4nbpLxX2MCwZUdgtqjiwD5iU8gst
Z575RZLhtTyeraVshnNyaeNeh62/gZ6QVtk4drRqx2VB4hvdpVpc0Nk10VnnWC2oSspj
E1wRO0JVy0JG4++D/WV/sbxfjhiAlF8FekkrhddlGTFP7W5KX9tL6JTYjY3YT1Iia1/4
AFqlhHBz2mQ62jJp4N1qA0y7fgBjuZfnwSVTLpfmBmq6zAK1/n4PnoNwQLpTo7BBpXUW
3qQw==
X-Gm-Message-State: AOAM532Lyu5d5fNh0uyVuEsn2PqJYq9d+NW2uVE//LLOUZuUABMu2CdM
BzsaAtD3a/n2kWOvuzOv+okIOqiRs3BZtpz6zOWI3A==
X-Google-Smtp-Source: ABdhPJzq3RLlnZCEG4gapx3TBOf1jrZYbhuZtzbQKE7nIojXlxzy3QTJi4hJ/8Z/Tw1ayidVydCuY04EXvAchEEXCFM=
X-Received: by 2002:a05:6808:1408:: with SMTP id
w8mr2905743oiv.81.1620423330912;
Fri, 07 May 2021 14:35:30 -0700 (PDT)
MIME-Version: 1.0
References: <20210507181025.84012-1-lance.richardson@broadcom.com>
<20210507190657.84927-1-lance.richardson@broadcom.com>
<20210507235146.133c3706@sovereign>
In-Reply-To: <20210507235146.133c3706@sovereign>
From: Lance Richardson <lance.richardson@broadcom.com>
Date: Fri, 7 May 2021 17:35:20 -0400
Message-ID: <CADyeNEAURzE5fSS0x51s9E+NPzg4Tv3UKOtT+i-VCuTVXtT2gA@mail.gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, dev@dpdk.org,
dpdk stable <stable@dpdk.org>
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
micalg=sha-256; boundary="0000000000000bbb4f05c1c4353a"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix memory mapping for 32-bit targets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
--0000000000000bbb4f05c1c4353a
Content-Type: text/plain; charset="UTF-8"
On Fri, May 7, 2021 at 4:51 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> 2021-05-07 15:06 (UTC-0400), Lance Richardson:
> [...]
> > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> > index ec7156df96..41a94a7511 100644
> > --- a/lib/eal/unix/eal_unix_memory.c
> > +++ b/lib/eal/unix/eal_unix_memory.c
> > @@ -24,14 +24,14 @@
> >
> > static void *
> > mem_map(void *requested_addr, size_t size, int prot, int flags,
> > - int fd, size_t offset)
> > + int fd, uint64_t offset)
> > {
> > void *virt = mmap(requested_addr, size, prot, flags, fd, offset);
> > if (virt == MAP_FAILED) {
> > RTE_LOG(DEBUG, EAL,
> > - "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%zx): %s\n",
> > - requested_addr, size, prot, flags, fd, offset,
> > - strerror(errno));
> > + "Cannot mmap(%p, 0x%zx, 0x%x, 0x%x, %d, 0x%llx): %s\n",
> > + requested_addr, size, prot, flags, fd,
> > + (unsigned long long)offset, strerror(errno));
>
> Why not PRIx64?
Good point. %llx made sense for off_t.
Thanks,
Lance
--0000000000000bbb4f05c1c4353a--