From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id DEAB8A00E6
for <public@inbox.dpdk.org>; Tue, 11 Jun 2019 23:18:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id B94C11D05D;
Tue, 11 Jun 2019 23:18:55 +0200 (CEST)
Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com
[209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 8D73A1D01D
for <dev@dpdk.org>; Tue, 11 Jun 2019 23:18:54 +0200 (CEST)
Received: by mail-ot1-f68.google.com with SMTP id i8so13350375oth.10
for <dev@dpdk.org>; Tue, 11 Jun 2019 14:18:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=Yax8ECyuVBMR7hlIJMn8bZ05x99Yxn+wXgSTN5lSKVA=;
b=C8IcSsHy4696tXKpji7wawWjenSSir9ttQWPgX5LSLcHnn6H+w7eWsTI/3rjVqs3jr
tmVpfUD/24GYA93A1GqFwssb0dQMYrVURdcwGx3beEI9Ihy/zFMzad7TKk1n60fuVPju
JPcvaueFszFdNI1OFlEt45kJggR1XfqiHWqng=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Yax8ECyuVBMR7hlIJMn8bZ05x99Yxn+wXgSTN5lSKVA=;
b=doEChDILoJ1oA3f+FVlA6bwLV+5fC0oIp9F8kiOzhgkCY8mmp9+VFAXsL9gPCWFJhn
6U4+CPePEOKp1lpTjqtoWM7ch+JFBGPKlo//Lwen1UvtY093DL/z/XY36P8TuiHBAfjy
TGGa/WzI0HjyJbqHkFv1hyNxsy+IIsK90DsGgpyoJE/Wxpjte7Q0u7G/ebWeV1Cyv8iZ
IoErMxkM3LXGcS9T4ol/1waLrSWBlJEWrBd9Xdj/XmvjMhiWCmgC/k9th20TWmQ22LzC
59zRj9vwVxdhcoZ0lNEp1AgYpyv/BjdioRQUaco/VoCnYWgcTCxAbuGykqcXZgt9t7OC
53yw==
X-Gm-Message-State: APjAAAXGN02FJ1SkfbNXa6dM+zvwkOH+8hRE6Z5wmEc8nZCEhKAjX6R+
dYjvw6kkIlz+Bg1P7Ukiwr7TlMdi1CBRghdbnQHGID8uh98=
X-Google-Smtp-Source: APXvYqwKg+FubksnooCfKkes8daT9N6JRtN2N5G2FVzAIw4+DjOzfalt2H1F8NKVvUkDz8X3QKTAD7rzqnJwzWqKQU8=
X-Received: by 2002:a9d:6416:: with SMTP id h22mr4650135otl.44.1560287933836;
Tue, 11 Jun 2019 14:18:53 -0700 (PDT)
MIME-Version: 1.0
References: <20190610175155.21374-1-stephen@networkplumber.org>
<20190611135416.01f6dffc@hermes.lan>
In-Reply-To: <20190611135416.01f6dffc@hermes.lan>
From: Lance Richardson <lance.richardson@broadcom.com>
Date: Tue, 11 Jun 2019 17:18:42 -0400
Message-ID: <CADyeNEAkUijck-Ah=GFjGyzx0fG4jQoS+E4Fta2bkn7KHms4Qg@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Mon, 10 Jun 2019 10:51:48 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > While testing KNI with netvsc, saw lots of places more code
> > could be safely removed from KNI kernel driver.
> >
> > This is still mostly "putting lipstick on a pig" all users
> > would be better off using virtio_user rather than KNI.
> >
> > v2 - get rid of unnecessary padding, combine the unused field patches
> >
> > Stephen Hemminger (7):
> > kni: don't need stubs for rx_mode or ioctl
> > kni: use netdev_alloc_skb
> > kni: don't keep stats in kni_net
> > kni: drop unused fields
> > kni: use proper type for kni fifo's
> > kni: return -EFAULT if copy_from_user fails
> > doc: update KNI documentation
> >
> > .../sample_app_ug/kernel_nic_interface.rst | 18 ++---
> > kernel/linux/kni/kni_dev.h | 21 ++---
> > kernel/linux/kni/kni_misc.c | 17 ++--
> > kernel/linux/kni/kni_net.c | 79 +++++--------------
> > 4 files changed, 38 insertions(+), 97 deletions(-)
> >
>
> Don't believe patchwork the patch is fine, it is getting falsely blamed
> for failures caused by other changes in ice, bnxt which fail
> FreeBSD build.
Do you mean failures like the ones below? If so, I think think they
might be an unintended
consequence of commit a385972c3 "mk: disable warning for packed member pointer".
Lance
OS: FreeBSD12-64
Target: x86_64-native-bsdapp-gcc
CC ice_rxtx.o
CC ice_ethdev.o
cc1: error: unrecognized command line option
'-Wno-address-of-packed-member' [-Werror]
cc1: all warnings being treated as errors
gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114:
bnxt_ethdev.o] Error 1
gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37:
bnxt] Error 2
gmake[5]: *** Waiting for unfinished jobs....