From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E47C0A05D3 for ; Thu, 23 May 2019 21:24:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2D3D493D; Thu, 23 May 2019 21:24:00 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 5F7E82B9E for ; Thu, 23 May 2019 21:23:59 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id i8so6481646oth.10 for ; Thu, 23 May 2019 12:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=46s/FeE9nj4LbEnSDCkeSwUohPnyhUjOBfcpyyVUXsI=; b=I15b1RvWr3UOd3UcicT2ZBhSoe/I/2VEvWIXroCfkWsbuAVE2lQyquDsIl33YR335+ 8RPv6NH0Pj7u+6ypzFozA24BI9IXGa0HJ2QgiO1JbI8IJfq6sfo0+hnYMdds9jknN0Cc G9IMOGiHWHKyYDv8WsRhvAhcY5OuK+4vTfr9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=46s/FeE9nj4LbEnSDCkeSwUohPnyhUjOBfcpyyVUXsI=; b=fgH/VeB5/BaPMyLq7BuH39lUdfVBoMj6/CRoFTRfzb9dIOttlg80QkO+ohI3vdXUps asxo/6bKWUqO+CtrW0YOGKF6hwxJZSKrl7Z6JDOkYZPMRXkANkun7Bl7WU0SvEZm82by VfUemWp9JbBV0O5sPeFkll7cT3FB5VeyPzD/8Lua4BPFgilRGm/154W9YwRSY9oefMze E5J475SIvUhxfei4rLUyCU9cpuFrTTY0csNhD55mY5dKDUsmYM3+OqhH6pmARhzOjuv2 qlzVHWP6hhea3I88htRRIAiR2/u9OsXdjngmNHHClU827BnDmUjBVJnHTV6m5K3BNFZI hSgA== X-Gm-Message-State: APjAAAWcSDgAoCUlfYCDFMz8VvSR7Kpg1N9X2UwnGGbemkvr+WpPlIwR Z3mlsFneA285ihJmx0qxDA/kxh6y3EQhFh/urTA8Tg== X-Google-Smtp-Source: APXvYqyAITqQW/RIbkqYqDXPYXqkZQDUcnPgxBKaKl4yavUhBfKy/ohzSUShxeBYFiJgOvESN6SW/hrZ1aCanI68g7Q= X-Received: by 2002:a9d:481a:: with SMTP id c26mr11835608otf.267.1558639438618; Thu, 23 May 2019 12:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20190521213953.25425-1-ajit.khaparde@broadcom.com> <20190521213953.25425-4-ajit.khaparde@broadcom.com> <311341f0-054b-00af-4778-f8b2f5c771c2@redhat.com> In-Reply-To: <311341f0-054b-00af-4778-f8b2f5c771c2@redhat.com> From: Lance Richardson Date: Thu, 23 May 2019 15:23:47 -0400 Message-ID: To: Maxime Coquelin Cc: Ajit Khaparde , dev@dpdk.org, ferruh.yigit@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 03/11] net/bnxt: implement vector mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, thanks for taking the time to review this. On Thu, May 23, 2019 at 8:18 AM Maxime Coquelin wrote: ... > How do we enable it with Meson build? It seems to be missing. Ah, thanks for pointing that out, I had completely missed the Meson piece. Will fix in v2. > > I think we would better have a stub for bnxt_recv_pkts_vec() when > RTE_LIBRTE_BNXT_INC_VECTOR isn't set, that would avoid having all these > #ifdeferies in this file. > I'm having trouble picturing how having stubs would reduce the number of #ifdefs, but maybe the resulting code could be cleaner. I'll see what can be done for v2. (Stubs with weak linkage might help, but that approach seems to be going out of favor in http://patchwork.dpdk.org/patch/53498/). > > -static inline uint32_t bnxt_tx_bds_in_hw(struct bnxt_tx_queue *txq) > > +static inline uint32_t > > +bnxt_tx_bds_in_hw(struct bnxt_tx_queue *txq) > > If to be done, it should be done in patch 1. > > > { > > return ((txq->tx_ring->tx_prod - txq->tx_ring->tx_cons) & > > txq->tx_ring->tx_ring_struct->ring_mask); > > } > > > > -static inline uint32_t bnxt_tx_avail(struct bnxt_tx_queue *txq) > > +static inline uint32_t > > +bnxt_tx_avail(struct bnxt_tx_queue *txq) > > Ditto > I'll drop both of those changes from this patch in v2 (they don't seem to be needed since checkpatch was happy with patch 1). Thanks again, Lance