From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BBB96A045E for ; Wed, 29 May 2019 15:19:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85AA41B955; Wed, 29 May 2019 15:19:51 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id AD23E1B952 for ; Wed, 29 May 2019 15:19:50 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id l17so1990845otq.1 for ; Wed, 29 May 2019 06:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BMiZkieQCZTv55+nGQeX5uJcVxtDvp38dcbnGAtZnTY=; b=aMyfHVGElru1o9aBVEbZszudjbDT9uMOqnrWuiIIu5PAW/tpbHG/zrCMNaTdoB5U79 BXHTS0dTwPOxZMlwCuGvXW5leWra6/W/m4W+7fF6Z8oo2M1nCADLHQViQIHRUO6CsBj+ wiDIBc53KGS+f2eaWmyRNnxevAfhw9r71H0zo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BMiZkieQCZTv55+nGQeX5uJcVxtDvp38dcbnGAtZnTY=; b=ny1SVao+SOv4sOGQOL8TbSlHF//Y8V1ig4KRB95bWrA+hl8ypZOhrBr8As30qUPB+k KxOiB6tr+JHF3OrHzvqQFLdJnWEC5kGtwu+lZcbSSPb5YliJvf1/s8aO/lo50pl34uAY Q/DCiT/fOFYZciMDTwx7jfzrh9dqtOiJ+Uh99FLqGigcGApOjFBnmnw36Q8OCSNQSMPf EGfUtPaeu8YzYIjDhwe0THMbxdGPOpkhECQHQcXdCg667Dx3yUxk110X7iEfqWlkSWHD PgBRGEszyGjZ0DPgfR9OJpSKyHlNuIucD4lXi7izoUAn5fv9IItS098lhpNOqyzHH3rC x4LA== X-Gm-Message-State: APjAAAXw8xZvCAQUXyXXGanS/P5Ny1cZrCMRdirSgv197CEVvjOHDCib P68Tkp1E/AQjqhepPkADvudh91rXiDq2Cu6wJfsUYw== X-Google-Smtp-Source: APXvYqyn/VCmpOIRzfcuY/NDsmTVyGHrMqseJ9n9CjeqOr1yX7I9vMLZ3Ws5wbGc/ja8CCKMpuBFZH9mErdBrsoafDE= X-Received: by 2002:a05:6830:2015:: with SMTP id e21mr45752124otp.259.1559135990079; Wed, 29 May 2019 06:19:50 -0700 (PDT) MIME-Version: 1.0 References: <20190521213953.25425-1-ajit.khaparde@broadcom.com> <20190528192339.10903-1-lance.richardson@broadcom.com> <20190528192339.10903-5-lance.richardson@broadcom.com> <7293818a-8104-6dbc-a772-e86e7bea2fa8@redhat.com> In-Reply-To: <7293818a-8104-6dbc-a772-e86e7bea2fa8@redhat.com> From: Lance Richardson Date: Wed, 29 May 2019 09:19:39 -0400 Message-ID: To: Maxime Coquelin Cc: dev@dpdk.org, Ajit Khaparde , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 4/8] net/bnxt: implement vector mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 29, 2019 at 2:48 AM Maxime Coquelin wrote: > > > > On 5/28/19 9:23 PM, Lance Richardson wrote: > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > > index 5b3932b7b..bccba445a 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -638,13 +638,73 @@ static int bnxt_scattered_rx(struct rte_eth_dev *eth_dev) > > > > buf_size = (uint16_t)(rte_pktmbuf_data_room_size(rxq->mb_pool) - > > RTE_PKTMBUF_HEADROOM); > > - if (eth_dev->data->dev_conf.rxmode.max_rx_pkt_len + > > - VLAN_TAG_SIZE * BNXT_NUM_VLANS > buf_size) > > + if (eth_dev->data->dev_conf.rxmode.max_rx_pkt_len > buf_size) > > return 1; > > } > > return 0; > > } > > It seems you forgot to squash this in patch 3. Thanks, good catch... it appears that I did squash patch 4 from the v1 set, but I mistakenly squashed it into patch 3 instead of patch 2. I'll fix in the next spin. Lance