From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E869CA04B5; Tue, 12 Jan 2021 21:32:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8962140D17; Tue, 12 Jan 2021 21:32:14 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 68A48140D13 for ; Tue, 12 Jan 2021 21:32:13 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id d20so3600582otl.3 for ; Tue, 12 Jan 2021 12:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cvmLOzXp6kV8e+B5m7fNT1Y5xgb37jiJ2lrpo/qvhrk=; b=M30EuT2UpoUiWPhE/+dym5rdDIOo8O6NRvnur3pyFqomt69vYqKuQjq+J4mq2vAEI7 56rRayioIRliMxnzaAFEXYUNbJjKM7lnlC14qtnF7/q6WGJgR6JQeY70sKqhb1E7Z7O6 ueFABFCKY80eNJ1DnblAvhE6XGeie3RDtpZ10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cvmLOzXp6kV8e+B5m7fNT1Y5xgb37jiJ2lrpo/qvhrk=; b=l0QcrI4z2eMlu1U9kYBmNhnsndnKfzz5mAwGNj+KP8WOUWoH67/JcOSn5lafYsn54H 76OEGjfs1DbP+CyhXJvWRvlYpI/p84idOy6RerYBhaLFvgsDfKCzYuwkqqaDU98f16fe k8k2ccvhVbOJqUhNSG98UZ+TsAdsYW0kLolJDlKpiDNK1fBy5PPGtmA+jgdBRAw+UHri TD7XpF7AcIr8P8LUbgg19eWz8SMUECItyxojqFwknVXijkNGNPNfkpDK55ADspD0Ocit e9ZchKqE2hiXZe0UaddDhuIJs2xjX4IeJQwppnwMbLp3XlwmxgQdQfKkwKt0qioAzeq2 LMxg== X-Gm-Message-State: AOAM5330Thpm6sRiK7G0piBCJshA3Cr9VmwFdLnx9V8/6VPKXn4I+kYn T2uLRYdztb3aI8SFfv1ISE3Q9eLEzDmXi01RNpE1Yg== X-Google-Smtp-Source: ABdhPJwoSo5BXapBx2fRXHFqFHcoZjhZ9sZjZ4lnPGpguwebCU9J++bKn4NnB6R/zp/5/bgHK5BXsS16qitkLeCNmxk= X-Received: by 2002:a05:6830:1c79:: with SMTP id s25mr816733otg.172.1610483532553; Tue, 12 Jan 2021 12:32:12 -0800 (PST) MIME-Version: 1.0 References: <1604315406-27669-1-git-send-email-liang.j.ma@intel.com> <8f06ba8347a3b464eba41ee4985b83934422c89a.1608213657.git.anatoly.burakov@intel.com> In-Reply-To: <8f06ba8347a3b464eba41ee4985b83934422c89a.1608213657.git.anatoly.burakov@intel.com> From: Lance Richardson Date: Tue, 12 Jan 2021 15:32:01 -0500 Message-ID: To: Anatoly Burakov Cc: dev@dpdk.org, Liang Ma , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella , Neil Horman , "Ananyev, Konstantin" , gage.eads@intel.com, timothy.mcdaniel@intel.com, david.hunt@intel.com, Bruce Richardson , chris.macnamara@intel.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000e4ad5905b8b9ea42" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v12 06/11] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000e4ad5905b8b9ea42 Content-Type: text/plain; charset="UTF-8" On Thu, Dec 17, 2020 at 9:08 AM Anatoly Burakov wrote: > > From: Liang Ma > > Add a simple API to allow getting the monitor conditions for > power-optimized monitoring of the RX queues from the PMD, as well as > release notes information. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: Konstantin Ananyev > --- > /** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > @@ -917,6 +937,8 @@ struct eth_dev_ops { > /**< Set up the connection between the pair of hairpin queues. */ > eth_hairpin_queue_peer_unbind_t hairpin_queue_peer_unbind; > /**< Disconnect the hairpin queues of a pair from each other. */ > + eth_get_monitor_addr_t get_monitor_addr; > + /**< Get next RX queue ring entry address. */ > }; > The implementation of get_monitor_addr will have much in common with the rx_descriptor_status API in struct rte_eth_dev, including the property that it will likely not make sense for it to be called concurrently with rx_pkt_burst on a given queue. Might it make more sense to have this API in struct rte_eth_dev instead of struct eth_dev_ops? --000000000000e4ad5905b8b9ea42--