DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lance Richardson <lance.richardson@broadcom.com>
To: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Bruce Richardson <bruce.richardson@intel.com>,
	aconole@redhat.com,  maicolgabriel@hotmail.com, dev@dpdk.org,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	 stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v11 2/7] net/bnxt: fix aarch32 build
Date: Wed, 9 Dec 2020 09:10:04 -0500
Message-ID: <CADyeNEBUc=6Dce6gsAY7x=d1M=JHr=0Aq=hsPSy6W9Jq_7CXRw@mail.gmail.com> (raw)
In-Reply-To: <1607518771-7564-3-git-send-email-juraj.linkes@pantheon.tech>

On Wed, Dec 9, 2020 at 7:59 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> From: Ruifeng Wang <ruifeng.wang@arm.com>
>
> NEON vector path of the PMD needs aarch64 support. But it was
> enabled for aarch32 build as well because aarch32 build had
> cpu_family set to aarch64. So build for aarch32 will fail due
> to unsupported intrinsics.
>
> Fixed aarch32 build by updating meson file to execule NEON vector
> implementation for aarch32.
>
> Fixes: 398358341419 ("net/bnxt: support NEON")
> Cc: lance.richardson@broadcom.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>  drivers/net/bnxt/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
> index 2896337b5..a2fd494da 100644
> --- a/drivers/net/bnxt/meson.build
> +++ b/drivers/net/bnxt/meson.build
> @@ -74,6 +74,6 @@ sources = files('bnxt_cpr.c',
>
>  if arch_subdir == 'x86'
>         sources += files('bnxt_rxtx_vec_sse.c')
> -elif arch_subdir == 'arm' and host_machine.cpu_family().startswith('aarch64')
> +elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
>         sources += files('bnxt_rxtx_vec_neon.c')
>  endif
> --
> 2.20.1
>
With this change, there should be no need for
http://patchwork.dpdk.org/patch/84864/

Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

  reply	other threads:[~2020-12-09 14:10 UTC|newest]

Thread overview: 158+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  9:03 [dpdk-dev] [PATCH v3 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-04-15  9:03 ` [dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to meson Juraj Linkeš
2020-04-15 11:45   ` Luca Boccassi
2020-04-16  6:16     ` Juraj Linkeš
2020-04-16  8:53       ` Luca Boccassi
2020-04-16 11:25         ` Juraj Linkeš
2020-04-16 12:00           ` Luca Boccassi
2020-04-16 12:22             ` Juraj Linkeš
2020-04-16 15:11               ` Ruifeng Wang
2020-04-15  9:03 ` [dpdk-dev] [PATCH v3 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-04-15  9:03 ` [dpdk-dev] [PATCH v3 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-04-15  9:03 ` [dpdk-dev] [PATCH v3 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-04-29 10:24 ` [dpdk-dev] [PATCH v4 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-04-29 10:24   ` [dpdk-dev] [PATCH v4 1/4] build: disable vhost NUMA for arm32 Juraj Linkeš
2020-04-29 10:24   ` [dpdk-dev] [PATCH v4 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-04-29 10:24   ` [dpdk-dev] [PATCH v4 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-04-29 10:24   ` [dpdk-dev] [PATCH v4 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-05-05 18:56     ` Aaron Conole
2020-05-11  7:05       ` Juraj Linkeš
2020-07-06  8:28   ` [dpdk-dev] [PATCH v5 0/4] aarch64 -> arm32 cross compilation support Juraj Linkeš
2020-07-06  8:28     ` [dpdk-dev] [PATCH v5 1/4] build: disable vhost NUMA for arm32 Juraj Linkeš
2020-07-06  8:56       ` David Marchand
2020-07-06  8:28     ` [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags Juraj Linkeš
2020-07-06  9:11       ` Jerin Jacob
2020-07-07 20:44         ` Honnappa Nagarahalli
2020-07-08  8:33           ` Jerin Jacob
2020-07-08 20:55             ` Honnappa Nagarahalli
2020-07-09  4:49               ` Jerin Jacob
2020-07-06  8:28     ` [dpdk-dev] [PATCH v5 3/4] build: add arm32 meson cross file Juraj Linkeš
2020-07-06  8:28     ` [dpdk-dev] [PATCH v5 4/4] ci: add aarch64 -> arm32 cross compiling jobs Juraj Linkeš
2020-07-06  9:11       ` Juraj Linkeš
2020-08-13  9:21     ` [dpdk-dev] [PATCH v6 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-13  9:21       ` [dpdk-dev] [PATCH v6 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-13  9:21       ` [dpdk-dev] [PATCH v6 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-13  9:21       ` [dpdk-dev] [PATCH v6 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-13  9:21       ` [dpdk-dev] [PATCH v6 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-14  2:10         ` Ruifeng Wang
2020-08-13  9:21       ` [dpdk-dev] [PATCH v6 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-14 10:31       ` [dpdk-dev] [PATCH v7 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-14 10:31         ` [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-19 17:45           ` Ajit Khaparde
2020-08-20  3:00             ` Ruifeng Wang
2020-08-20  9:13               ` Juraj Linkeš
2020-08-14 10:31         ` [dpdk-dev] [PATCH v7 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-14 10:31         ` [dpdk-dev] [PATCH v7 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-14 10:31         ` [dpdk-dev] [PATCH v7 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-14 10:31         ` [dpdk-dev] [PATCH v7 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-25 13:04         ` [dpdk-dev] [PATCH v8 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-25 13:04           ` [dpdk-dev] [PATCH v8 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-25 19:05             ` Ajit Khaparde
2020-08-25 13:04           ` [dpdk-dev] [PATCH v8 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-25 13:04           ` [dpdk-dev] [PATCH v8 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-25 13:04           ` [dpdk-dev] [PATCH v8 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-25 14:16             ` Aaron Conole
2020-08-26  6:21               ` Juraj Linkeš
2020-08-25 13:04           ` [dpdk-dev] [PATCH v8 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-08-25 14:03             ` Aaron Conole
2020-08-26  3:12               ` Phil Yang
2020-08-28 11:38           ` [dpdk-dev] [PATCH v9 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-08-28 11:38             ` [dpdk-dev] [PATCH v9 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-08-28 11:38             ` [dpdk-dev] [PATCH v9 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-08-28 11:38             ` [dpdk-dev] [PATCH v9 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-08-28 11:38             ` [dpdk-dev] [PATCH v9 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-08-28 11:38             ` [dpdk-dev] [PATCH v9 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-09-11 13:20               ` Aaron Conole
2020-09-16  8:04                 ` Juraj Linkeš
2020-09-16  8:21             ` [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-09-16  8:21               ` [dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32 Juraj Linkeš
2020-11-04 18:30                 ` Lance Richardson
2020-11-05  7:20                   ` Ruifeng Wang
2020-11-05 13:41                     ` Lance Richardson
2020-11-05 15:13                       ` Ruifeng Wang
2020-09-16  8:21               ` [dpdk-dev] [PATCH v10 2/5] build: add aarch32 meson build flags Juraj Linkeš
2020-10-21 14:24                 ` Ruifeng Wang
2020-09-16  8:21               ` [dpdk-dev] [PATCH v10 3/5] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-10-21 14:27                 ` Ruifeng Wang
2020-09-16  8:21               ` [dpdk-dev] [PATCH v10 4/5] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-10-21 14:29                 ` Ruifeng Wang
2020-09-16  8:21               ` [dpdk-dev] [PATCH v10 5/5] doc: add aarch32 build guidance Juraj Linkeš
2020-10-21 14:32                 ` Ruifeng Wang
2020-10-21 11:42               ` [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-10-21 11:52                 ` Thomas Monjalon
2020-10-28  9:22               ` Jerin Jacob
2020-11-30 14:03               ` Aaron Conole
2020-12-09 12:59               ` [dpdk-dev] [PATCH v11 0/7] " Juraj Linkeš
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2020-12-09 13:37                   ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 2/7] net/bnxt: " Juraj Linkeš
2020-12-09 14:10                   ` Lance Richardson [this message]
2020-12-09 14:16                     ` Ruifeng Wang
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 3/7] net/bnxt: add support for aarch32 Juraj Linkeš
2020-12-09 13:59                   ` Lance Richardson
2020-12-09 14:11                     ` Ruifeng Wang
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 4/7] build: add aarch32 meson build flags Juraj Linkeš
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-12-09 15:29                   ` Aaron Conole
2020-12-09 12:59                 ` [dpdk-dev] [PATCH v11 7/7] doc: add aarch32 build guidance Juraj Linkeš
2020-12-11  8:26                 ` [dpdk-dev] [PATCH v12 0/6] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 1/6] net/sfc: fix aarch32 build Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 2/6] net/bnxt: " Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 3/6] build: add aarch32 meson build flags Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 4/6] build: add aarch32 to meson cross-compilation Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 5/6] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2020-12-11  8:26                   ` [dpdk-dev] [PATCH v12 6/6] doc: add aarch32 build guidance Juraj Linkeš
2021-03-09  8:36                   ` [dpdk-dev] [PATCH v13 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 2/7] net/bnxt: " Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 3/7] net/virtio: " Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 4/7] build: add aarch32 meson build flags Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-03-09  8:36                     ` [dpdk-dev] [PATCH v13 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-03-09 13:46                       ` Aaron Conole
2021-03-17 13:35                     ` [dpdk-dev] [PATCH v14 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-03-17 13:35                       ` [dpdk-dev] [PATCH v14 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-03-17 13:35                       ` [dpdk-dev] [PATCH v14 2/7] net/bnxt: " Juraj Linkeš
2021-03-17 13:35                       ` [dpdk-dev] [PATCH v14 3/7] net/virtio: " Juraj Linkeš
2021-03-17 13:36                       ` [dpdk-dev] [PATCH v14 4/7] build: add aarch32 meson build flags Juraj Linkeš
2021-03-17 13:36                       ` [dpdk-dev] [PATCH v14 5/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-03-17 13:36                       ` [dpdk-dev] [PATCH v14 6/7] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-03-17 13:36                       ` [dpdk-dev] [PATCH v14 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-04-21  8:50                       ` [dpdk-dev] [PATCH v16 0/8] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build Juraj Linkeš
2021-04-21  9:04                           ` Andrew Rybchenko
2021-04-21 10:06                             ` Ruifeng Wang
2021-04-21 14:08                               ` Juraj Linkeš
2021-04-21 14:20                                 ` Andrew Rybchenko
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 2/8] net/bnxt: " Juraj Linkeš
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 3/8] net/virtio: " Juraj Linkeš
2021-04-21  9:16                           ` Maxime Coquelin
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags Juraj Linkeš
2021-04-21 14:28                           ` Juraj Linkeš
2021-04-22  5:32                             ` Ruifeng Wang
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 5/8] build: add aarch32 meson build flags Juraj Linkeš
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 6/8] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 7/8] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-04-21  8:50                         ` [dpdk-dev] [PATCH v16 8/8] doc: add aarch32 build guidance Juraj Linkeš
2021-04-22 12:49                         ` [dpdk-dev] [PATCH v17 0/8] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 1/8] net/sfc: fix aarch32 build Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 2/8] net/bnxt: " Juraj Linkeš
2021-04-22 18:50                             ` Ajit Khaparde
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 3/8] net/virtio: " Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 4/8] eal/arm: update CPU flags Juraj Linkeš
2021-04-25  7:03                             ` Ruifeng Wang
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 5/8] build: add aarch32 meson build flags Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 6/8] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 7/8] ci: add aarch64 -> aarch32 cross compiling jobs Juraj Linkeš
2021-04-22 12:49                           ` [dpdk-dev] [PATCH v17 8/8] doc: add aarch32 build guidance Juraj Linkeš
2021-07-07 13:25                           ` [dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 1/7] net/sfc: fix aarch32 build Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 2/7] net/bnxt: " Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 3/7] net/virtio: " Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 4/7] eal/arm: update CPU flags Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 5/7] build: add aarch32 meson build flags Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 6/7] build: add aarch32 to meson cross-compilation Juraj Linkeš
2021-07-07 13:25                             ` [dpdk-dev] [PATCH v18 7/7] doc: add aarch32 build guidance Juraj Linkeš
2021-07-09 18:19                             ` [dpdk-dev] [PATCH v18 0/7] aarch64 -> aarch32 cross compilation support Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADyeNEBUc=6Dce6gsAY7x=d1M=JHr=0Aq=hsPSy6W9Jq_7CXRw@mail.gmail.com' \
    --to=lance.richardson@broadcom.com \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=maicolgabriel@hotmail.com \
    --cc=ruifeng.wang@arm.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git