From: Lance Richardson <lance.richardson@broadcom.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] hash: fix thash gfni implementation
Date: Tue, 9 Nov 2021 12:34:27 -0500 [thread overview]
Message-ID: <CADyeNEBoQeMaP=k=_JJ2_F1JcM+mpiJJLm4sk6iqNF0TgYbfcA@mail.gmail.com> (raw)
In-Reply-To: <20211109172456.147140-1-vladimir.medvedkin@intel.com>
On Tue, Nov 9, 2021 at 12:25 PM Vladimir Medvedkin
<vladimir.medvedkin@intel.com> wrote:
>
> This patch replaces _mm512_set_epi8 with _mm512_set_epi32
> due to the lack of support by some compilers.
> Also this patch checks if AVX512F is supported along with GFNI.
> This is done if the code is built on a platform that supports GFNI,
> but does not support AVX512.
>
> Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
> Cc: vladimir.medvedkin@intel.com
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
> lib/hash/rte_thash_x86_gfni.h | 31 +++++++++++++------------------
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h
> index c2889c3734..7afbbedc08 100644
> --- a/lib/hash/rte_thash_x86_gfni.h
> +++ b/lib/hash/rte_thash_x86_gfni.h
> @@ -18,7 +18,7 @@
> extern "C" {
> #endif
>
> -#ifdef __GFNI__
> +#if defined(__GFNI__) && defined(__AVX512F__)
> #define RTE_THASH_GFNI_DEFINED
>
> #define RTE_THASH_FIRST_ITER_MSK 0x0f0f0f0f0f0e0c08
> @@ -56,23 +56,18 @@ static inline __m512i
> __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,
> const uint8_t *secondary_tuple, int len)
> {
> - __m512i permute_idx = _mm512_set_epi8(7, 6, 5, 4, 7, 6, 5, 4,
> - 6, 5, 4, 3, 6, 5, 4, 3,
> - 5, 4, 3, 2, 5, 4, 3, 2,
> - 4, 3, 2, 1, 4, 3, 2, 1,
> - 3, 2, 1, 0, 3, 2, 1, 0,
> - 2, 1, 0, -1, 2, 1, 0, -1,
> - 1, 0, -1, -2, 1, 0, -1, -2,
> - 0, -1, -2, -3, 0, -1, -2, -3);
> -
> - const __m512i rewind_idx = _mm512_set_epi8(0, 0, 0, 0, 0, 0, 0, 0,
> - 0, 0, 0, 0, 0, 0, 0, 0,
> - 0, 0, 0, 0, 0, 0, 0, 0,
> - 0, 0, 0, 0, 0, 0, 0, 0,
> - 0, 0, 0, 0, 0, 0, 0, 0,
> - 0, 0, 0, 59, 0, 0, 0, 59,
> - 0, 0, 59, 58, 0, 0, 59, 58,
> - 0, 59, 58, 57, 0, 59, 58, 57);
> + __m512i permute_idx = _mm512_set_epi32(0x7060504, 0x7060504,
> + 0x6050403, 0x6050403,
> + 0x5040302, 0x5040302,
> + 0x4030201, 0x4030201,
> + 0x3020100, 0x3020100,
> + 0x20100FF, 0x20100FF,
> + 0x100FFFE, 0x100FFFE,
> + 0xFFFEFD, 0xFFFEFD);
> + const __m512i rewind_idx = _mm512_set_epi32(0, 0, 0, 0, 0, 0, 0, 0,
> + 0, 0, 0x3B, 0x3B,
> + 0x3B3A, 0x3B3A,
> + 0x3B3A39, 0x3B3A39);
> const __mmask64 rewind_mask = RTE_THASH_REWIND_MSK;
> const __m512i shift_8 = _mm512_set1_epi8(8);
> __m512i xor_acc = _mm512_setzero_si512();
> --
> 2.25.1
>
This fixes the gcc 8 build issue on my CentOS 8 system.
Acked-by: Lance Richardson <lance.richardson@broadcom.com>
next prev parent reply other threads:[~2021-11-09 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 17:24 Vladimir Medvedkin
2021-11-09 17:34 ` Lance Richardson [this message]
2021-11-09 18:08 ` Ji, Kai
2021-11-12 14:17 ` [PATCH v2] " Vladimir Medvedkin
2021-11-16 13:53 ` David Marchand
2021-11-16 14:08 ` Walsh, Conor
2021-11-16 14:10 ` Bruce Richardson
2021-11-16 14:17 ` David Marchand
2021-11-16 14:18 ` Medvedkin, Vladimir
2021-11-16 14:33 ` [PATCH v3] " Vladimir Medvedkin
2021-11-17 9:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyeNEBoQeMaP=k=_JJ2_F1JcM+mpiJJLm4sk6iqNF0TgYbfcA@mail.gmail.com' \
--to=lance.richardson@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).