From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF35DA04C7; Tue, 15 Sep 2020 16:13:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BB2B1BF83; Tue, 15 Sep 2020 16:13:08 +0200 (CEST) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by dpdk.org (Postfix) with ESMTP id 184A01BF7F for ; Tue, 15 Sep 2020 16:13:07 +0200 (CEST) Received: by mail-oi1-f169.google.com with SMTP id x19so4029292oix.3 for ; Tue, 15 Sep 2020 07:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dWCRKj/OPUzr8MejvMoRJLOQ8PMm/b9X8MjW285CFFU=; b=DscTnsfkTLVShNAdPH0L6CZAuKa9BM40yDbNKXtz9+uXgJQ7hP4vQizBmN/GiyrMJH yHiWOvKM1KZzkcjbbTssMgCLyiZIFnIsms/dTg4IHFYnXDKf3/PMTUGcHOpD/9HAav2z +G90M63cIbFdslobJSiszn2anGnMBA7OsIJiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dWCRKj/OPUzr8MejvMoRJLOQ8PMm/b9X8MjW285CFFU=; b=bNXxUINCEiIciE0vKwgTIHhhzqKBGozFWPdxeO1WO7lPyTjEEzK0ZtDaCfWWKil0i9 7cVHUYuAgY408UUD2diZ3armyPVkMERA7uW9sk2uvhFvsAQ6E3oylBJhPFkFOr+0V15T qulJcK3UnQGMzHx/d1SJ88BZHsc/Svs7aeZ+uT087VjSMvEYYHOVUazhaO9h90qQqPbD j9Yn5LsR9/TMg3s11bECK4dp2nm2+It+vlySIi67s8fyaWIjmbbtGWhj93Jwq14DrjP5 bVNUVEsQt9HrQAer6qYLaJ8Q1GyO+Wh0hQyMCSLfx+30bXMIJ72YOnnCZrPmrrGiGXxN z9vA== X-Gm-Message-State: AOAM532ZTQLEXmM0v4dytpZbgwaL0f+QhhJ4lDbt0choYFTDFGIl0BYz YQ8g/DqH+1MuSpKtr5mBH1TkQEeiIet34UJxBoIO2Q== X-Google-Smtp-Source: ABdhPJx7SRKkKvomtGBF7sokXSZwqs6hchtiHAz/yANzKtdcIilZwRqxXStfOzS9zzzCr+mL6X2gmTpUWsuL25L5VOk= X-Received: by 2002:a54:4783:: with SMTP id o3mr3622474oic.89.1600179186126; Tue, 15 Sep 2020 07:13:06 -0700 (PDT) MIME-Version: 1.0 References: <20200909155302.28656-1-lance.richardson@broadcom.com> <20200909155302.28656-6-lance.richardson@broadcom.com> <4152848a-c2d9-6e96-d931-32f774dbc122@intel.com> In-Reply-To: <4152848a-c2d9-6e96-d931-32f774dbc122@intel.com> From: Lance Richardson Date: Tue, 15 Sep 2020 10:12:55 -0400 Message-ID: To: Ferruh Yigit Cc: Ajit Khaparde , Somnath Kotur , dev@dpdk.org, rasland@nvidia.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 05/12] net/bnxt: improve support for small ring sizes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 14, 2020 at 6:03 PM Ferruh Yigit wrote: > > Hi Lance, Ajit, Somnath, > > Raslan reported a build error for PPC architecture, this happens because > static inline functions in 'bnxt_rxtx_vec_common.h' are using > 'rxq->rxrearm_nb' & 'rxq->rxrearm_start' which are not defined for PPC. > > As far as I can see the 'bnxt_rxtx_vec_common.h' is included because of > some macros. > A quick fix can be to wrap all static inline functions with !PPC checks > but from the name of the header file, it looks like it shouldn't be > included by scalar datapath .c files at first place. > > Instead it can be possible to extract those macros into another header > and both these .c file and 'bnxt_rxtx_vec_common.h' can include it. > Or 'bnxt_txq.h' & 'bnxt_txr.h' can be used to hold those macros, and > those headers were already included by 'bnxt_rxtx_vec_common.h' and .c > files. > > > Anyway can you please provide the fix as incremental patches on top of > latest head, so I can squash them into original patches. > > If the patches can't be done as incremental fixes or if they will delay, > I will need to drop the patchset from next-net, to not block any > possible pull from main repo. Hi Feruh, I just sent a fix for this based on the head of next-net, compile-tested on x86_64, arm64, and powerpc. Please let me know if you run into any further snags. Thanks, Lance