From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81718A0547; Thu, 29 Apr 2021 15:59:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7096A4131A; Thu, 29 Apr 2021 15:59:16 +0200 (CEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 874A0410F1 for ; Thu, 29 Apr 2021 15:59:15 +0200 (CEST) Received: by mail-ot1-f45.google.com with SMTP id g4-20020a9d6b040000b029029debbbb3ecso28465106otp.7 for ; Thu, 29 Apr 2021 06:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m5g6YsJ6QSOnU6OOSsS5OFKkUqBgQ330k7CT5nBUmUg=; b=dbI+DLRQIxv/RPYCxTR53mmqUEwQoV1jQNH624opZcpzqC2sxLXj7KFn34uQXzALxf IhT4ZpRxbuK7SFKVSlzpARJ3vfOFGSibue46QTsEFMlj5MRZnX99m2bgB5EL5Y1PAGWb q/CXANHc0bamFnuwcV70GGAHtlHcZh5wvjvyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m5g6YsJ6QSOnU6OOSsS5OFKkUqBgQ330k7CT5nBUmUg=; b=HCkxnSqKyNtzSl5Ebqkm4SPmV26M4LRwnCwiFZXrDcO0m2czWvC3BvWa4oX6kroxiy p+9zY8yk1zY3Rhlkd3SReLufXa+AnxzIfLFYlOWqyPiBN6VksDjzbP+1YWvVRowEgk41 CCT5oqd7x2DZDe8yShdNPKxGad+7drqwAmMgLMxCe+EkDCDrlv3lGtxzkgQbm9aoMoeW yBUY9kILtMp10iAyKruBk5ByVccdLVV/6FymqswtXYimjdWXSNwFdBkAp0WbgEkiZxf+ HsIpptCo3ipUf4PJDDh+mBRmrwvDcByJ5AUnn4mpOio00Nz8wbi7cmhvUHQi8dijgd1I HSUQ== X-Gm-Message-State: AOAM530kT+f4d1HsolStcgZLYfUKt87ngxF3RsciZwXI5pi3I5aIZSv+ On208mjBDqQEHMd1FtXrgLlgv7gTXxS78HfuW4F5kA== X-Google-Smtp-Source: ABdhPJyPuLsMVzf8mwmnCs67SkmvHrzPjusK0Bk09OoMXvume6PPIMMFfiZrWs53gREaPDnb0E2jCFjiuhq8dhRPvzM= X-Received: by 2002:a9d:5e0a:: with SMTP id d10mr27621178oti.44.1619704754769; Thu, 29 Apr 2021 06:59:14 -0700 (PDT) MIME-Version: 1.0 References: <20210428220403.10115-1-lance.richardson@broadcom.com> In-Reply-To: From: Lance Richardson Date: Thu, 29 Apr 2021 09:59:00 -0400 Message-ID: To: Ajit Khaparde , Somnath Kotur Cc: dev@dpdk.org, dpdk stable , Kalesh Anakkur Purayil Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000091535e05c11ce6e7" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix initialization of filter struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000091535e05c11ce6e7 Content-Type: text/plain; charset="UTF-8" On Thu, Apr 29, 2021 at 9:43 AM Lance Richardson wrote: > > On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson > wrote: > > > > Initialize filter structure to all zeroes on allocation. > > > > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") > > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson > > Reviewed-by: Ajit Kumar Khaparde > > --- > > drivers/net/bnxt/bnxt_filter.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c > > index 1d08e03b2f..6aadfa9526 100644 > > --- a/drivers/net/bnxt/bnxt_filter.c > > +++ b/drivers/net/bnxt/bnxt_filter.c > > @@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp) > > return NULL; > > } > > STAILQ_REMOVE_HEAD(&bp->free_filter_list, next); > > + memset(filter, 0, sizeof(*filter)); > > > > return filter; > > } > > -- > > 2.25.1 > > > Self-NAK, will send a v2 shortly. Let's drop this patch, this is already fixed in upstream via commit 7105de7085b0 ("net/bnxt: reset filter indices on free"), but that commit should be applied to -stable branches. --00000000000091535e05c11ce6e7--