DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lance Richardson <lance.richardson@broadcom.com>
To: dev@dpdk.org
Subject: [dpdk-dev] question regarding rx checksum offload flags
Date: Mon, 24 Aug 2020 16:11:45 -0400	[thread overview]
Message-ID: <CADyeNEDKjT5eKHYWvmag2-cc3xFmnpK8UkouauX57P-+DYA47w@mail.gmail.com> (raw)

I was looking for some clarification regarding how rx checksum
flags should be set for tunnel packets having both inner and outer
IP/L4 headers.

Based on comments in rte_mbuf_core.h, it seems to me. that the
inner (encapsulated) IP header checksum status should determine
which of these goes into ol_flags:
    PKT_RX_IP_CKSUM_UNKNOWN
    PKT_RX_IP_CKSUM_BAD
    PKT_RX_IP_CKSUM_GOOD
    PKT_RX_IP_CKSUM_NONE

Similarly, the L4 checksum status should determine which of these
goes into ol_flags:
   PKT_RX_L4_CKSUM_UNKNOWN
   PKT_RX_L4_CKSUM_BAD
   PKT_RX_L4_CKSUM_GOOD
   PKT_RX_L4_CKSUM_NONE

The IP header checksum status for the outer IP header should determine
whether this flag is set in ol_flags:
    PKT_RX_EIP_CKSUM_BAD

And for UDP-based tunnel encapsulations, the outer L4 checksum status
should determine which of these goes into ol_flags:
    PKT_RX_OUTER_L4_CKSUM_UNKNOWN
    PKT_RX_OUTER_L4_CKSUM_BAD
    PKT_RX_OUTER_L4_CKSUM_GOOD
    PKT_RX_OUTER_L4_CKSUM_INVALID

Finally, the checksum status of inner headers should have no influence
on PKT_RX_EIP_CKSUM_BAD or PKT_RX_OUTER_L4_CKSUM_*, and
likewise the checksum status of outer headers should have no influence
on PKT_RX_L4_CKSUM_* or PKT_RX_IP_CKSUM_*.

Is this correct? Apologies for such a basic question, but I'm having trouble
correlating the above with implementations.

Thanks and regards,
    Lance

             reply	other threads:[~2020-08-24 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 20:11 Lance Richardson [this message]
2020-08-25 14:39 ` Lance Richardson
2020-08-26 13:39   ` Lance Richardson
2020-09-17 14:05 ` Olivier Matz
2020-12-14 17:41   ` Lance Richardson
2020-12-15 22:05     ` Lance Richardson
2020-12-18  9:27     ` Olivier Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADyeNEDKjT5eKHYWvmag2-cc3xFmnpK8UkouauX57P-+DYA47w@mail.gmail.com \
    --to=lance.richardson@broadcom.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).