From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DE67A056A; Thu, 5 Mar 2020 21:11:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF5DF2BB8; Thu, 5 Mar 2020 21:11:02 +0100 (CET) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 912CD3B5 for ; Thu, 5 Mar 2020 21:11:01 +0100 (CET) Received: by mail-ot1-f66.google.com with SMTP id j14so157508otq.3 for ; Thu, 05 Mar 2020 12:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ReBDKTW1folYVgVL8D4eYoJ5uGLnrY2w3r0PXXR7CJA=; b=CoiRTS1gOwLL/a7v/zQQ07zIxhX+QOYROlF+mIseCxzNDGGMmLRru0wExfv26lhwUD 7pe3JjQSG1YYnPAKr/ZHME40Im2qmZ52Fv8u77h+w6Dp3DpygRyOesa/gfYQdQzsvpC+ wSVJiIZNwNl0yWV9EFGz0Cgzbu5kNfysO9XAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ReBDKTW1folYVgVL8D4eYoJ5uGLnrY2w3r0PXXR7CJA=; b=aZEP7zLL6GzO/q40yxTTIHUnR7DINIJo1wWcDl2KCbudUi6cY4rObQyCa+zc78KUdK NT8SqGC7buCaZ3tG3NwuHaktIXojzj+1Nz3fdkBJO0FhI7CyBRbhFkd8+EqPa2LKTtf5 aX8QinV1piM2VC1ftXze8mPr8k8zcmeyv18z338tw92tS/BCUDSyr7nAR6LtKIqiUm97 5iANkCoorq7R9IT4+Vza/Z0dYcNhRyKlIX+XtdEb/DaWqPdyBOjKJzNcqYSIxIvMx4wc wVP98GMxVycAgc06kUiga5odd1+5eVNV2lCwVZFSlKaySdsgXdJEnJyayGE7BO01QMjI APjw== X-Gm-Message-State: ANhLgQ1bxNUurqyViv5UAWDiM/23ZI9WMFxWxbUl4F9qwwd4UR0/pbw2 k3W1508sHL38IdrYWTE3e1ilpVwu1z+XmsVAd8hFSA== X-Google-Smtp-Source: ADFU+vsmViloEOkQ4HMbf53OV9YNg8BtoTHsufg/4jAHE3A9/Hq3yXUx/xBqKIA2GFJLJa3WA7+EI6jjN/1lcm5ib68= X-Received: by 2002:a9d:3ea4:: with SMTP id b33mr191708otc.136.1583439059863; Thu, 05 Mar 2020 12:10:59 -0800 (PST) MIME-Version: 1.0 References: <20200305064500.5634-1-stephen@networkplumber.org> In-Reply-To: <20200305064500.5634-1-stephen@networkplumber.org> From: Lance Richardson Date: Thu, 5 Mar 2020 15:10:48 -0500 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: allow configuring vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, On Thu, Mar 5, 2020 at 1:45 AM Stephen Hemminger wrote: > > > Make the configuration use the same as other drivers with > vector mode: ixge, i40e, ... s/ixge/ixgbe/? > > This will also make future support of vector mode on other > architectures possible. > > Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") > +#error "bnxt: IEEE1588 is incompatiable with vector mode" > +#endif s/incompatiable/incompatible/ This was this approach taken in the initial patch set to add bnxt vector mode support, however based on feedback the current approach was used instead. That discussion can be found here: http://patches.dpdk.org/patch/53683/ If mark support could be treated as a receive offload, it would be possible to choose the non-vector receive handler based on whether mark is enabled. Adding a kvargs option to disable vector mode might be another possibility. Otherwise, a build-time configuration option does seem to be useful. LGTM... with the above: Acked-by: Lance Richardson Regards, Lance