From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 874E9A045E for ; Tue, 28 May 2019 13:23:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE2844C8B; Tue, 28 May 2019 13:23:55 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id EF1AF137D for ; Tue, 28 May 2019 13:23:53 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id t24so17353412otl.12 for ; Tue, 28 May 2019 04:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tEfsQZ+3w9Iynb7fcDifCPLDetXypfEympeOMofKCrg=; b=N3Kt4uGg91tkxXizb0fw9rK94pam+jSGJNd6ZNU3CaRT1fiNqNmuPwrPcPbWgKsr6E YBo1QXbz4zi+Hvh2B2xm5Te00lC8KPyGqdA5oENkLV7ipJlRt21azRfa4cWpn+HZi/KW mlAEncjDlrozDg4P7MVBRDDAQyanoQM4VfrtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tEfsQZ+3w9Iynb7fcDifCPLDetXypfEympeOMofKCrg=; b=C6GWOxh1VUMCx5X0DTFoGNLXD8W2jXWTqyg8tMUbab9vyv1YYsMkeZRTO4H/rpodAM a7cOWOltKsASZlqPP8FhRZS2U9tSOZrBl9GN7n0qgXSBIYWGeTWVUGr3pSqNycM3AJsD TI1vz6yh5vk68FmfXu27d4XumUtGf/nir3ek8dueG6UDx6h7Sb0JjYIHq5Po3xtwI3JY qS4l3YLSGFC8BZFS81p8OAJhUOWH03x5r6Q73FwIJ5g7Oi4bxkUj761eDZ/HsWOlKeQR 7pBmJ1OnKMaHeQLKY46YnFJ3BHOVYAlq1YqJD0EKWTNSBZyBAJj3rO+zYflfjEnmQG0F V5zQ== X-Gm-Message-State: APjAAAVmMyOXhGVwMvuIbMUM4+37zwQPRFOSTH/7L14nrJRvxwMV1g59 Gg/T84BjNoWbsicUCTQ94t4/JjtNMQspYIzRsuCpkQ== X-Google-Smtp-Source: APXvYqyAVRea+7bm9DrQlCb7p1gxQ69HeIXc5C6PxNW4yaQ+IJluLrUKWf/W9VDmiFCkFUUoMvM//cA5REEe3WbSUL8= X-Received: by 2002:a9d:6c82:: with SMTP id c2mr17095189otr.172.1559042633343; Tue, 28 May 2019 04:23:53 -0700 (PDT) MIME-Version: 1.0 References: <20190521213953.25425-1-ajit.khaparde@broadcom.com> <20190524144935.18765-1-lance.richardson@broadcom.com> <20190524144935.18765-4-lance.richardson@broadcom.com> <49587a40-43e4-3c57-4e54-b6414832275d@intel.com> In-Reply-To: <49587a40-43e4-3c57-4e54-b6414832275d@intel.com> From: Lance Richardson Date: Tue, 28 May 2019 07:23:42 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Ajit Khaparde , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 03/10] net/bnxt: implement vector mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 28, 2019 at 5:08 AM Ferruh Yigit wrote: > > On 5/24/2019 3:49 PM, Lance Richardson wrote: > > @@ -1597,6 +1659,8 @@ > > > > bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id, > > > > static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu) > > { > > + uint32_t new_pkt_size = new_mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + > > + VLAN_TAG_SIZE * BNXT_NUM_VLANS; > > 'ETHER_HDR_LEN' & 'ETHER_CRC_LEN' are renamed to > 'RTE_ETHER_HDR_LEN' & 'RTE_ETHER_CRC_LEN' > > I am mostly fixing these while applying but since there will be a new version, > can you please rebase on top of latest next-net, to be able to catch these. Sure. Will rebase on next-net and resend after addressing feedback. Thanks, Lance