From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADB6AA00E6 for ; Fri, 12 Jul 2019 14:06:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C7E31BDEE; Fri, 12 Jul 2019 14:06:39 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 880E21BDE8 for ; Fri, 12 Jul 2019 14:06:37 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id r21so3159951otq.6 for ; Fri, 12 Jul 2019 05:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5fHxJqcSxuS00QJOD2q1sXoaagTNIppFLNhnadyDlYM=; b=D0MKxUkhGvdY7ZsZ4/cWmIgCjgCvojeEUjp0H8eEdNI9F2BWQ2hkNn0rYDMNT6wZ+B mqdGoCWvzX8E5n4ZmE8BUXbpdKhqcqX4KOLROZbqrHx+r1ik4mWYDFq/u+PLNF6g3rsP wRKDnOccMrIdDWY6NcatQRrsHn6qiMCfSOYGM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5fHxJqcSxuS00QJOD2q1sXoaagTNIppFLNhnadyDlYM=; b=lzx86D57bSLan3YpYXkuQZ60VTKQkp2I96ll36IXLV3axU9LyLfQ0xVwI//RKe/Y3S NABxjTL6S3N65kPyQsYLb1LfXnI2z3BTRh2dA5zUAlkV/oZvXnWFQ3OCnuYLeVlhy4/O NSRznkPxs5To1IdcOwo+EY+0a7tOHJPpfS7D2M9PssILZT9+NagVlW72+W230b87p3Dz mmm7pZZvPYR/jmm+ccGtWNswSm7GTolOBwhYVdCAplFjXWidIPd/54WjR2z3WeP+R/KQ uWPZP8B30x7SuWPxSZXzlb1EU8CgxgOcI2KLYKYQg4dQwB1aXmjXpjGl2YDio9wfyqXo IHFQ== X-Gm-Message-State: APjAAAXeMPVRAmf8VWBKpnmDBoqPJqIl87J7bTPQs0mos1piyMaIA7cw 1+yOZiCvu598RMrsrsBnvZIkwRacU98jRU0jgcOlvg== X-Google-Smtp-Source: APXvYqz6aspKRIeZZPG/J1LH4ekSCgxET1dWB6SNE7lfkB4O1WJRweEQ40B3pcn39580ut5ZW9XXZ1UcpBEYPNc/2uk= X-Received: by 2002:a9d:3f62:: with SMTP id m89mr8364833otc.44.1562933196782; Fri, 12 Jul 2019 05:06:36 -0700 (PDT) MIME-Version: 1.0 References: <20190712060622.76975-1-ajit.khaparde@broadcom.com> <20190712060622.76975-6-ajit.khaparde@broadcom.com> In-Reply-To: <20190712060622.76975-6-ajit.khaparde@broadcom.com> From: Lance Richardson Date: Fri, 12 Jul 2019 08:06:25 -0400 Message-ID: To: Ajit Khaparde Cc: dev@dpdk.org, Ferruh Yigit , Christopher Reder Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde wrote: > > From: Lance Richardson > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > and rxq->rxrearm_start are reinitialized correctly when a port is > restarted. > > Fixes: af3ed597e305 ("net/bnxt: initial vector-mode driver") > Reviewed-by: Christopher Reder > Signed-off-by: Lance Richardson > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ring.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c > index 16327dbe9..13478fa02 100644 > --- a/drivers/net/bnxt/bnxt_ring.c > +++ b/drivers/net/bnxt/bnxt_ring.c > @@ -613,6 +613,9 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp) > bnxt_db_write(&rxr->rx_db, rxr->rx_prod); > bnxt_db_write(&rxr->ag_db, rxr->ag_prod); > rxq->index = i; > +#ifdef RTE_LIBRTE_BNXT_INC_VECTOR This #ifdef should be removed, the macro is never defined in upstream. > + bnxt_rxq_vec_setup(rxq); > +#endif > } > > for (i = 0; i < bp->tx_cp_nr_rings; i++) { > -- > 2.20.1 (Apple Git-117) >