From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 309E7A04BB; Fri, 11 Sep 2020 17:07:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B68808F96; Fri, 11 Sep 2020 17:07:54 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id AF85FE07 for ; Fri, 11 Sep 2020 17:07:53 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id o8so907967otl.4 for ; Fri, 11 Sep 2020 08:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wgtXPC+8BRw6H2IkTqReORN7UPNbMbjG1TL6KUp2PLc=; b=DBo1jmigo+vfExVHo6KL4wGdvBghhQxGOWhNaXOI/Y/YGye+9PdHyo3DcxUm5B7Eoa X6hFDrpJR+I1W8/fNUhrnjU+/ClZLNT4oNFXU+KJ3FRpWkABiVZLsUiM43qyjIB1Xz5D VIlRvg6HFh7vNgDXHuSA0+yood2j54OnlLZgY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wgtXPC+8BRw6H2IkTqReORN7UPNbMbjG1TL6KUp2PLc=; b=a41WiVNIDRrU4sgjVIBVb5kKbdOq6lCuM+eONsbRye4UuOU9c2jj5RubPYHrLJs7ya iB0a56N8jfHSOmBQHr8QPawZAqsULaM6/quEZRu6AtOtdZv+ftQ3c8pkcrwxvAIxr/l0 dPser9v4WtYXHoYiC3sM9XrqW55BN/7PMgL8UswEWk+V4ePcfQGnKi19HHYHWpVSrUhr OytFzvRhTOYQRNkn+hHDbSZSx6vRc3jpMy8PMoB4dTVU+yIIe2S0qSoblnPw8ntTWzRl R3SOBVWTki4EDQB+4wlrBbfy/3qLLtouGpVTBARPPkrmCAIozhucxXxznhux5iKn3wIH Rd/w== X-Gm-Message-State: AOAM531biaC+0KOYeXFXM/oXaCOszaIe5urKsqIBRyy9rEtSJla8CnYm /pjjIvzzfzY80IQY24h5PMU3cAIMrFfQMREYqlQrig== X-Google-Smtp-Source: ABdhPJxQBRY+xlWmv4MYWd1JklhjXBTTbdYU1RTq6143FserIHxPknzG4lWOpD1nxFqMasHwo7UYMJRjIDCW8EpRa6o= X-Received: by 2002:a9d:8c7:: with SMTP id 65mr1524464otf.267.1599836872880; Fri, 11 Sep 2020 08:07:52 -0700 (PDT) MIME-Version: 1.0 References: <20200909155302.28656-1-lance.richardson@broadcom.com> <20200909155302.28656-5-lance.richardson@broadcom.com> <32cac6a3-c524-7d60-45a9-c64bd34cf4b4@intel.com> In-Reply-To: <32cac6a3-c524-7d60-45a9-c64bd34cf4b4@intel.com> From: Lance Richardson Date: Fri, 11 Sep 2020 11:07:41 -0400 Message-ID: To: Ferruh Yigit Cc: Ajit Khaparde , Somnath Kotur , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 04/12] net/bnxt: require async cq for vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 11:03 AM Ferruh Yigit wrote: > > On 9/9/2020 4:52 PM, Lance Richardson wrote: > > Disable support for vector mode when async completions can be placed > > in a receive completion ring and change the default for all platforms > > to use a dedicated async completion ring. > > > > Simplify completion handling in vector mode receive paths now that > > it no longer needs to handle async completions. > > I guess 'cq' is "completion queue"(?), based on above description I understand > vector mode no more handles async completions and to enable vector mode there > should be at lest one async completion ring. If correct, would it be OK if I > update the title as: > net/bnxt: require async completion ring for vector mode That's correct. Your suggestion will make things clearer, sounds good to me. Thanks, Lance > > > > > Reviewed-by: Ajit Kumar Khaparde > > Signed-off-by: Lance Richardson > > <...> >