From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anudeepnmam@gmail.com>
Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com
 [209.85.167.169]) by dpdk.org (Postfix) with ESMTP id C5A2B5A4A
 for <dev@dpdk.org>; Mon, 21 Jan 2019 14:23:34 +0100 (CET)
Received: by mail-oi1-f169.google.com with SMTP id c206so14550884oib.0
 for <dev@dpdk.org>; Mon, 21 Jan 2019 05:23:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=XkZg2HzBbpSi/TInnwxNjxcHyhws4cI0I1MDpjiBJhc=;
 b=Y9zG4Xqx1J3yj1JWCC1kYgZlse3EBVPYe0RI5SSvKZcMnEEu0xg01f9e9NZamuo0vU
 i8xYaREqrjMagpBonxp9FSCjjSXU8OsqBJO6CeWNlG4WyJVHJJABFCZqfV1EqkmLyy37
 MSyG3jjvarADl2iEaJcUclL/Lbymh7HA4QuJXWKErCaNmcBnSBn07lV6vCrC/SaNKiXF
 S3UboM+YvOA1qo1NplBJn4d/HtXgBfsiOvPoCXcWVuN9+AN2qwS4fx5MTYzJVpPyZsa7
 o2oNVUE1khxAl07e7WFVnb1LkFT1fdQNJfz1TiJ8pubi1bw3SyBWo/MLLd1NlRlw8e6h
 gRrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=XkZg2HzBbpSi/TInnwxNjxcHyhws4cI0I1MDpjiBJhc=;
 b=XWXkeQzR5eKiMapC2vYiqGy6HLTqTphUgK+jE/UYva7NT0HFgqBLflYmJjrNCOyNy3
 A1H+NIAqX2Ojg7Ef3hYCd97LeeXT9/XtYNUj6+tHA+/4cu2qZEr2fE1Qw+IrNPIjaj14
 FmbO2Ztv67edxypJ3blcfbWZ4F9WJzUr1CDrGe5BLIPTTxtDfLDs+zAUFsu7IyAAhI9m
 h8WcfQ1ZwIgTZu7gbS4GMUFudZEJQVsQoZ8RdgYmCE1L3geRq0OcRMgZliaOmD/HOdkV
 2N/qcgpjJtf6UlwdW97nxK5rs79k8pPTZHTxxCaD0dJ5lJcA+4Ep/boswxgA5JVGs5GB
 y91w==
X-Gm-Message-State: AJcUukcPBzf7bpNq07W5YuwVtzTRMd352ZKSyVtOr8rlis5+FFufQese
 Mz0Fg7OG2YK/kh4DsR639UMt1KfZywltbgzJv/9ToQ==
X-Google-Smtp-Source: ALg8bN4mMwlZwllkd6NCgL2o2UrW3akrr8MI1d5RM5Efh4VHZ62Ts2Td7RnDZwVCOnz5QHWvrMlLXASkRPg+80Jt6ek=
X-Received: by 2002:aca:3092:: with SMTP id w140mr5806986oiw.237.1548077013684; 
 Mon, 21 Jan 2019 05:23:33 -0800 (PST)
MIME-Version: 1.0
References: <mailman.14255.1548076743.7586.dev@dpdk.org>
In-Reply-To: <mailman.14255.1548076743.7586.dev@dpdk.org>
From: Anudeep Kumar <anudeepnmam@gmail.com>
Date: Mon, 21 Jan 2019 18:53:21 +0530
Message-ID: <CAE0Vva7UbF7DKNCaEi-7L-5Cx-w8-PQzQe6L3huFF3j5BGwd2g@mail.gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] dev Digest, Vol 231, Issue 6
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jan 2019 13:23:35 -0000

Hi,

I am unable to run l3fwd in dpdk. Please provide steps to run.

Regards,
Anudeep

On Mon, Jan 21, 2019, 18:49 <dev-request@dpdk.org wrote:

> Send dev mailing list submissions to
>         dev@dpdk.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://mails.dpdk.org/listinfo/dev
> or, via email, send a message with subject or body 'help' to
>         dev-request@dpdk.org
>
> You can reach the person managing the list at
>         dev-owner@dpdk.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of dev digest..."
>
>
> Today's Topics:
>
>    1. [PATCH v6 2/4] examples/ip_pipeline: support QinQ PPPoE   encap
>       (Nemanja Marjanovic)
>    2. [PATCH v6 1/4] pipeline: support QinQ PPPoE encap
>       (Nemanja Marjanovic)
>    3. [PATCH v6 3/4] net/softnic: support QinQ PPPoE encap
>       (Nemanja Marjanovic)
>    4. [PATCH v6 4/4] net: add PPPoE ethertypes (Nemanja Marjanovic)
>    5. Re: [PATCH] doc: add deprecation notice to remove rte meter
>       color (Mohammad Abdul Awal)
>    6. Re: [PATCH] service: fix parameter type (Van Haaren, Harry)
>    7. Re: [PATCH] vhost: fix possible out of bound access for
>       indirect descs (Maxime Coquelin)
>    8. Re: IXGBE, IOMMU DMAR DRHD handling fault issue (Hu, Xuekun)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 21 Jan 2019 11:11:22 +0000
> From: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> To: dev@dpdk.org
> Cc: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, "Nemanja
>         Marjanovic" <nemanja.marjanovic@intel.com>
> Subject: [dpdk-dev] [PATCH v6 2/4] examples/ip_pipeline: support QinQ
>         PPPoE   encap
> Message-ID: <20190121111124.16362-2-nemanja.marjanovic@intel.com>
>
> From: "Nemanja Marjanovic" <nemanja.marjanovic@intel.com>
>
> Add implementation of QinQ PPPoE packet encapsulation action.
>
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v5:Removing footer from patch.
> v6:Added missing acks.
> ---
>  examples/ip_pipeline/cli.c | 46 ++++++++++++++++++++++++++++++++++++--
>  1 file changed, 44 insertions(+), 2 deletions(-)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 910386282..dd05393ef 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1022,7 +1022,7 @@ static const char cmd_table_action_profile_help[] =
>  "       tc <n_tc>\n"
>  "       stats none | pkts | bytes | both]\n"
>  "   [tm spp <n_subports_per_port> pps <n_pipes_per_subport>]\n"
> -"   [encap ether | vlan | qinq | mpls | pppoe |\n"
> +"   [encap ether | vlan | qinq | mpls | pppoe | qinq_pppoe \n"
>  "       vxlan offset <ether_offset> ipv4 | ipv6 vlan on | off]\n"
>  "   [nat src | dst\n"
>  "       proto udp | tcp]\n"
> @@ -1290,7 +1290,10 @@ cmd_table_action_profile(char **tokens,
>
>                         p.encap.encap_mask = 1LLU <<
> RTE_TABLE_ACTION_ENCAP_VXLAN;
>                         n_extra_tokens = 5;
> -               } else {
> +               } else if (strcmp(tokens[t0 + 1], "qinq_pppoe") == 0)
> +                       p.encap.encap_mask =
> +                               1LLU << RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE;
> +               else {
>                         snprintf(out, out_size, MSG_ARG_MISMATCH, "encap");
>                         return;
>                 }
> @@ -3090,6 +3093,7 @@ parse_match(char **tokens,
>   *       ether <da> <sa>
>   *       | vlan <da> <sa> <pcp> <dei> <vid>
>   *       | qinq <da> <sa> <pcp> <dei> <vid> <pcp> <dei> <vid>
> + *       | qinq_pppoe <da> <sa> <pcp> <dei> <vid> <pcp> <dei> <vid>
> <session_id>
>   *       | mpls unicast | multicast
>   *          <da> <sa>
>   *          label0 <label> <tc> <ttl>
> @@ -3391,6 +3395,44 @@ parse_table_action_encap(char **tokens,
>                 return 1 + 9;
>         }
>
> +       /* qinq_pppoe */
> +       if (n_tokens && (strcmp(tokens[0], "qinq_pppoe") == 0)) {
> +               uint32_t svlan_pcp, svlan_dei, svlan_vid;
> +               uint32_t cvlan_pcp, cvlan_dei, cvlan_vid;
> +
> +               if ((n_tokens < 10) ||
> +                       parse_mac_addr(tokens[1],
> +                               &a->encap.qinq_pppoe.ether.da) ||
> +                       parse_mac_addr(tokens[2],
> +                               &a->encap.qinq_pppoe.ether.sa) ||
> +                       parser_read_uint32(&svlan_pcp, tokens[3]) ||
> +                       (svlan_pcp > 0x7) ||
> +                       parser_read_uint32(&svlan_dei, tokens[4]) ||
> +                       (svlan_dei > 0x1) ||
> +                       parser_read_uint32(&svlan_vid, tokens[5]) ||
> +                       (svlan_vid > 0xFFF) ||
> +                       parser_read_uint32(&cvlan_pcp, tokens[6]) ||
> +                       (cvlan_pcp > 0x7) ||
> +                       parser_read_uint32(&cvlan_dei, tokens[7]) ||
> +                       (cvlan_dei > 0x1) ||
> +                       parser_read_uint32(&cvlan_vid, tokens[8]) ||
> +                       (cvlan_vid > 0xFFF) ||
> +
>  parser_read_uint16(&a->encap.qinq_pppoe.pppoe.session_id,
> +                               tokens[9]))
> +                       return 0;
> +
> +               a->encap.qinq_pppoe.svlan.pcp = svlan_pcp & 0x7;
> +               a->encap.qinq_pppoe.svlan.dei = svlan_dei & 0x1;
> +               a->encap.qinq_pppoe.svlan.vid = svlan_vid & 0xFFF;
> +               a->encap.qinq_pppoe.cvlan.pcp = cvlan_pcp & 0x7;
> +               a->encap.qinq_pppoe.cvlan.dei = cvlan_dei & 0x1;
> +               a->encap.qinq_pppoe.cvlan.vid = cvlan_vid & 0xFFF;
> +               a->encap.type = RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE;
> +               a->action_mask |= 1 << RTE_TABLE_ACTION_ENCAP;
> +               return 1 + 10;
> +
> +       }
> +
>         /* mpls */
>         if (n_tokens && (strcmp(tokens[0], "mpls") == 0)) {
>                 uint32_t label, tc, ttl;
> --
> 2.17.1
>
>
>
> ------------------------------
>
> Message: 2
> Date: Mon, 21 Jan 2019 11:11:21 +0000
> From: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> To: dev@dpdk.org
> Cc: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, "Nemanja
>         Marjanovic" <nemanja.marjanovic@intel.com>
> Subject: [dpdk-dev] [PATCH v6 1/4] pipeline: support QinQ PPPoE encap
> Message-ID: <20190121111124.16362-1-nemanja.marjanovic@intel.com>
>
> From: "Nemanja Marjanovic" <nemanja.marjanovic@intel.com>
>
> Add support of QinQ PPPoE packet encapsulation action.
>
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v5:Removing footer from patch.
> v6:Added missing acks.
> ---
>  lib/librte_pipeline/rte_table_action.c | 61 ++++++++++++++++++++++++++
>  lib/librte_pipeline/rte_table_action.h | 16 +++++++
>  2 files changed, 77 insertions(+)
>
> diff --git a/lib/librte_pipeline/rte_table_action.c
> b/lib/librte_pipeline/rte_table_action.c
> index 7c7c8dd82..466019934 100644
> --- a/lib/librte_pipeline/rte_table_action.c
> +++ b/lib/librte_pipeline/rte_table_action.c
> @@ -432,6 +432,7 @@ encap_valid(enum rte_table_action_encap_type encap)
>         case RTE_TABLE_ACTION_ENCAP_MPLS:
>         case RTE_TABLE_ACTION_ENCAP_PPPOE:
>         case RTE_TABLE_ACTION_ENCAP_VXLAN:
> +       case RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE:
>                 return 1;
>         default:
>                 return 0;
> @@ -532,6 +533,13 @@ struct encap_vxlan_ipv6_vlan_data {
>         struct vxlan_hdr vxlan;
>  } __attribute__((__packed__));
>
> +struct encap_qinq_pppoe_data {
> +       struct ether_hdr ether;
> +       struct vlan_hdr svlan;
> +       struct vlan_hdr cvlan;
> +       struct pppoe_ppp_hdr pppoe_ppp;
> +} __attribute__((__packed__));
> +
>  static size_t
>  encap_data_size(struct rte_table_action_encap_config *encap)
>  {
> @@ -563,6 +571,9 @@ encap_data_size(struct rte_table_action_encap_config
> *encap)
>                         else
>                                 return sizeof(struct
> encap_vxlan_ipv6_data);
>
> +       case 1LLU << RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE:
> +                       return sizeof(struct encap_qinq_pppoe_data);
> +
>         default:
>                 return 0;
>         }
> @@ -599,6 +610,9 @@ encap_apply_check(struct rte_table_action_encap_params
> *p,
>         case RTE_TABLE_ACTION_ENCAP_VXLAN:
>                 return 0;
>
> +       case RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE:
> +               return 0;
> +
>         default:
>                 return -EINVAL;
>         }
> @@ -676,6 +690,38 @@ encap_qinq_apply(void *data,
>         return 0;
>  }
>
> +static int
> +encap_qinq_pppoe_apply(void *data,
> +       struct rte_table_action_encap_params *p)
> +{
> +       struct encap_qinq_pppoe_data *d = data;
> +
> +       /* Ethernet */
> +       ether_addr_copy(&p->qinq.ether.da, &d->ether.d_addr);
> +       ether_addr_copy(&p->qinq.ether.sa, &d->ether.s_addr);
> +       d->ether.ether_type = rte_htons(ETHER_TYPE_VLAN);
> +
> +       /* SVLAN */
> +       d->svlan.vlan_tci = rte_htons(VLAN(p->qinq.svlan.pcp,
> +               p->qinq.svlan.dei,
> +               p->qinq.svlan.vid));
> +       d->svlan.eth_proto = rte_htons(ETHER_TYPE_VLAN);
> +
> +       /* CVLAN */
> +       d->cvlan.vlan_tci = rte_htons(VLAN(p->qinq.cvlan.pcp,
> +               p->qinq.cvlan.dei,
> +               p->qinq.cvlan.vid));
> +       d->cvlan.eth_proto = rte_htons(ETHER_TYPE_PPPOE_SESSION);
> +
> +       /* PPPoE and PPP*/
> +       d->pppoe_ppp.ver_type_code = rte_htons(0x1100);
> +       d->pppoe_ppp.session_id =
> rte_htons(p->qinq_pppoe.pppoe.session_id);
> +       d->pppoe_ppp.length = 0; /* not pre-computed */
> +       d->pppoe_ppp.protocol = rte_htons(PPP_PROTOCOL_IP);
> +
> +       return 0;
> +}
> +
>  static int
>  encap_mpls_apply(void *data,
>         struct rte_table_action_encap_params *p)
> @@ -921,6 +967,9 @@ encap_apply(void *data,
>         case RTE_TABLE_ACTION_ENCAP_VXLAN:
>                 return encap_vxlan_apply(data, p, cfg);
>
> +       case RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE:
> +               return encap_qinq_pppoe_apply(data, p);
> +
>         default:
>                 return -EINVAL;
>         }
> @@ -1119,6 +1168,18 @@ pkt_work_encap(struct rte_mbuf *mbuf,
>                 break;
>         }
>
> +       case 1LLU << RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE:
> +       {
> +               struct encap_qinq_pppoe_data *qinq_pppoe =
> +                       encap(ip, data, sizeof(struct
> encap_qinq_pppoe_data));
> +               qinq_pppoe->pppoe_ppp.length = rte_htons(total_length + 2);
> +               mbuf->data_off = ip_offset - (sizeof(struct rte_mbuf) +
> +                       sizeof(struct encap_qinq_pppoe_data));
> +               mbuf->pkt_len = mbuf->data_len = total_length +
> +                       sizeof(struct encap_qinq_pppoe_data);
> +               break;
> +       }
> +
>         case 1LLU << RTE_TABLE_ACTION_ENCAP_VXLAN:
>         {
>                 if (cfg->vxlan.ip_version)
> diff --git a/lib/librte_pipeline/rte_table_action.h
> b/lib/librte_pipeline/rte_table_action.h
> index c96061291..53d16af8a 100644
> --- a/lib/librte_pipeline/rte_table_action.h
> +++ b/lib/librte_pipeline/rte_table_action.h
> @@ -380,6 +380,9 @@ enum rte_table_action_encap_type {
>          * Ether -> { Ether | VLAN | IP | UDP | VXLAN | Ether }
>          */
>         RTE_TABLE_ACTION_ENCAP_VXLAN,
> +
> +       /** IP -> { Ether | S-VLAN | C-VLAN | PPPoE | PPP | IP } */
> +       RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE,
>  };
>
>  /** Pre-computed Ethernet header fields for encapsulation action. */
> @@ -529,6 +532,16 @@ struct rte_table_action_encap_config {
>         };
>  };
>
> +/** QinQ_PPPoE encap paramaeters. */
> +struct rte_table_encap_ether_qinq_pppoe {
> +
> +       /** Only valid when *type* is set to QinQ. */
> +       struct rte_table_action_ether_hdr ether;
> +       struct rte_table_action_vlan_hdr svlan; /**< Service VLAN header.
> */
> +       struct rte_table_action_vlan_hdr cvlan; /**< Customer VLAN header.
> */
> +       struct rte_table_action_pppoe_hdr pppoe; /**< PPPoE/PPP headers. */
> +};
> +
>  /** Encap action parameters (per table rule). */
>  struct rte_table_action_encap_params {
>         /** Encapsulation type. */
> @@ -553,6 +566,9 @@ struct rte_table_action_encap_params {
>
>                 /** Only valid when *type* is set to VXLAN. */
>                 struct rte_table_action_encap_vxlan_params vxlan;
> +
> +               /** Only valid when *type* is set to QinQ_PPPoE. */
> +               struct rte_table_encap_ether_qinq_pppoe qinq_pppoe;
>         };
>  };
>
> --
> 2.17.1
>
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 21 Jan 2019 11:11:23 +0000
> From: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> To: dev@dpdk.org
> Cc: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, "Nemanja
>         Marjanovic" <nemanja.marjanovic@intel.com>
> Subject: [dpdk-dev] [PATCH v6 3/4] net/softnic: support QinQ PPPoE
>         encap
> Message-ID: <20190121111124.16362-3-nemanja.marjanovic@intel.com>
>
> From: "Nemanja Marjanovic" <nemanja.marjanovic@intel.com>
>
> Add implementation of QinQ PPPoE packet encapsulation action.
>
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v5:Removing footer from patch.
> v6:Added missing acks.
> ---
>  drivers/net/softnic/rte_eth_softnic_cli.c | 44 ++++++++++++++++++++++-
>  1 file changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c
> b/drivers/net/softnic/rte_eth_softnic_cli.c
> index 57b623377..c15b57b5b 100644
> --- a/drivers/net/softnic/rte_eth_softnic_cli.c
> +++ b/drivers/net/softnic/rte_eth_softnic_cli.c
> @@ -1335,7 +1335,7 @@ cmd_port_in_action_profile(struct pmd_internals
> *softnic,
>   *      tc <n_tc>
>   *      stats none | pkts | bytes | both]
>   *  [tm spp <n_subports_per_port> pps <n_pipes_per_subport>]
> - *  [encap ether | vlan | qinq | mpls | pppoe |
> + *  [encap ether | vlan | qinq | mpls | pppoe | qinq_pppoe |
>   *      vxlan offset <ether_offset> ipv4 | ipv6 vlan on | off]
>   *  [nat src | dst
>   *      proto udp | tcp]
> @@ -1612,10 +1612,14 @@ cmd_table_action_profile(struct pmd_internals
> *softnic,
>                         p.encap.encap_mask = 1LLU <<
> RTE_TABLE_ACTION_ENCAP_VXLAN;
>                         n_extra_tokens = 5;
>
> +               } else if (strcmp(tokens[t0 + 1], "qinq_pppoe") == 0) {
> +                       p.encap.encap_mask =
> +                               1LLU << RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE;
>                 } else {
>                         snprintf(out, out_size, MSG_ARG_MISMATCH, "encap");
>                         return;
>                 }
> +
>                 p.action_mask |= 1LLU << RTE_TABLE_ACTION_ENCAP;
>                 t0 += 2 + n_extra_tokens;
>         } /* encap */
> @@ -3353,6 +3357,7 @@ parse_match(char **tokens,
>   *       ether <da> <sa>
>   *       | vlan <da> <sa> <pcp> <dei> <vid>
>   *       | qinq <da> <sa> <pcp> <dei> <vid> <pcp> <dei> <vid>
> + *       | qinq_pppoe <da> <sa> <pcp> <dei> <vid> <pcp> <dei> <vid>
> <session_id>
>   *       | mpls unicast | multicast
>   *          <da> <sa>
>   *          label0 <label> <tc> <ttl>
> @@ -3658,6 +3663,43 @@ parse_table_action_encap(char **tokens,
>                 return 1 + 9;
>         }
>
> +       /* qinq_pppoe */
> +       if (n_tokens && (strcmp(tokens[0], "qinq_pppoe") == 0)) {
> +               uint32_t svlan_pcp, svlan_dei, svlan_vid;
> +               uint32_t cvlan_pcp, cvlan_dei, cvlan_vid;
> +
> +               if (n_tokens < 10 ||
> +                       softnic_parse_mac_addr(tokens[1],
> +                               &a->encap.qinq_pppoe.ether.da) ||
> +                       softnic_parse_mac_addr(tokens[2],
> +                               &a->encap.qinq_pppoe.ether.sa) ||
> +                       softnic_parser_read_uint32(&svlan_pcp, tokens[3])
> ||
> +                       svlan_pcp > 0x7 ||
> +                       softnic_parser_read_uint32(&svlan_dei, tokens[4])
> ||
> +                       svlan_dei > 0x1 ||
> +                       softnic_parser_read_uint32(&svlan_vid, tokens[5])
> ||
> +                       svlan_vid > 0xFFF ||
> +                       softnic_parser_read_uint32(&cvlan_pcp, tokens[6])
> ||
> +                       cvlan_pcp > 0x7 ||
> +                       softnic_parser_read_uint32(&cvlan_dei, tokens[7])
> ||
> +                       cvlan_dei > 0x1 ||
> +                       softnic_parser_read_uint32(&cvlan_vid, tokens[8])
> ||
> +                       cvlan_vid > 0xFFF ||
> +
>  softnic_parser_read_uint16(&a->encap.qinq_pppoe.pppoe.session_id,
> +                               tokens[9]))
> +                       return 0;
> +
> +               a->encap.qinq_pppoe.svlan.pcp = svlan_pcp & 0x7;
> +               a->encap.qinq_pppoe.svlan.dei = svlan_dei & 0x1;
> +               a->encap.qinq_pppoe.svlan.vid = svlan_vid & 0xFFF;
> +               a->encap.qinq_pppoe.cvlan.pcp = cvlan_pcp & 0x7;
> +               a->encap.qinq_pppoe.cvlan.dei = cvlan_dei & 0x1;
> +               a->encap.qinq_pppoe.cvlan.vid = cvlan_vid & 0xFFF;
> +               a->encap.type = RTE_TABLE_ACTION_ENCAP_QINQ_PPPOE;
> +               a->action_mask |= 1 << RTE_TABLE_ACTION_ENCAP;
> +               return 1 + 10;
> +       }
> +
>         /* mpls */
>         if (n_tokens && (strcmp(tokens[0], "mpls") == 0)) {
>                 uint32_t label, tc, ttl;
> --
> 2.17.1
>
>
>
> ------------------------------
>
> Message: 4
> Date: Mon, 21 Jan 2019 11:11:24 +0000
> From: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> To: dev@dpdk.org
> Cc: jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, "Nemanja
>         Marjanovic" <nemanja.marjanovic@intel.com>
> Subject: [dpdk-dev] [PATCH v6 4/4] net: add PPPoE ethertypes
> Message-ID: <20190121111124.16362-4-nemanja.marjanovic@intel.com>
>
> From: "Nemanja Marjanovic" <nemanja.marjanovic@intel.com>
>
> Add PPPoE ethertypes in to rte_ether.h.
>
> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v5:Removing footer from patch.
> v6:Added missing acks.
> ---
>  lib/librte_net/rte_ether.h             | 2 ++
>  lib/librte_pipeline/rte_table_action.c | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> index c2c5e249f..54822df75 100644
> --- a/lib/librte_net/rte_ether.h
> +++ b/lib/librte_net/rte_ether.h
> @@ -301,6 +301,8 @@ struct vxlan_hdr {
>  #define ETHER_TYPE_RARP 0x8035 /**< Reverse Arp Protocol. */
>  #define ETHER_TYPE_VLAN 0x8100 /**< IEEE 802.1Q VLAN tagging. */
>  #define ETHER_TYPE_QINQ 0x88A8 /**< IEEE 802.1ad QinQ tagging. */
> +#define ETHER_TYPE_PPPOE_DISCOVERY 0x8863 /**< PPPoE Discovery Stage. */
> +#define ETHER_TYPE_PPPOE_SESSION 0x8864 /**< PPPoE Session Stage. */
>  #define ETHER_TYPE_ETAG 0x893F /**< IEEE 802.1BR E-Tag. */
>  #define ETHER_TYPE_1588 0x88F7 /**< IEEE 802.1AS 1588 Precise Time
> Protocol. */
>  #define ETHER_TYPE_SLOW 0x8809 /**< Slow protocols (LACP and Marker). */
> diff --git a/lib/librte_pipeline/rte_table_action.c
> b/lib/librte_pipeline/rte_table_action.c
> index 466019934..ac8109f00 100644
> --- a/lib/librte_pipeline/rte_table_action.c
> +++ b/lib/librte_pipeline/rte_table_action.c
> @@ -485,8 +485,6 @@ struct encap_mpls_data {
>         uint32_t mpls_count;
>  } __attribute__((__packed__));
>
> -#define ETHER_TYPE_PPPOE_SESSION                           0x8864
> -
>  #define PPP_PROTOCOL_IP                                    0x0021
>
>  struct pppoe_ppp_hdr {
> --
> 2.17.1
>
>
>
> ------------------------------
>
> Message: 5
> Date: Mon, 21 Jan 2019 11:39:09 +0000
> From: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> To: Reshma Pattan <reshma.pattan@intel.com>, dev@dpdk.org
> Cc: jasvinder.singh@intel.com
> Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice to remove
>         rte meter color
> Message-ID: <398165c5-c5c3-dcc3-a9ef-d688f94db81c@intel.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
>
> On 12/12/2018 16:38, Reshma Pattan wrote:
> > Added deprecation notice to replace rte_meter_color
> > with rte_color.
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > index b48486d36..bf1fdf369 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -105,3 +105,8 @@ Deprecation Notices
> >     - ``rte_pdump_set_socket_dir`` will be removed;
> >     - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
> >     - The enum ``rte_pdump_socktype`` will be removed.
> > +
> > +* meter: New ``rte_color`` definition will be added in 19.02 and that
> will
> > +  replace ``enum rte_meter_color`` in meter library in 19.05. This will
> help
> > +  to consolidate color definition, which is currently replicated in
> many places,
> > +  such as: rte_meter.h, rte_mtr.h, rte_tm.h.
> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
>
>
> ------------------------------
>
> Message: 6
> Date: Mon, 21 Jan 2019 11:43:59 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: "Rao, Nikhil" <nikhil.rao@intel.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] service: fix parameter type
> Message-ID:
>         <
> E923DB57A917B54B9182A2E928D00FA6757C579E@IRSMSX102.ger.corp.intel.com>
>
> Content-Type: text/plain; charset="us-ascii"
>
> > -----Original Message-----
> > From: Rao, Nikhil
> > Sent: Saturday, January 19, 2019 2:01 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> > Subject: [PATCH] service: fix parameter type
> >
> > The type of value parameter to rte_service_attr_get
> > should be uint64_t *, since the attributes
> > are of type uint64_t.
> >
> > Fixes: 4d55194d76a4 ("service: add attribute get function")
> >
> > Reviewed-by: Gage Eads <gage.eads@intel.com>
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> > ---
> >  lib/librte_eal/common/include/rte_service.h | 2 +-
> >  lib/librte_eal/common/rte_service.c         | 2 +-
> >  test/test/test_service_cores.c              | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > For 19.02, I assume this will require the ABI change announcement. I will
> > post it once this patch is acked.
>
> Correct - this breaks API and ABI, so certainly will need an announce.
>
> Thanks for the fixup, -Harry
>
>
>
> ------------------------------
>
> Message: 7
> Date: Mon, 21 Jan 2019 13:43:55 +0100
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com,
>         dev@dpdk.org
> Cc: haiyue.wang@intel.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] vhost: fix possible out of bound
>         access for indirect descs
> Message-ID: <1173420b-78cf-ba5b-c2f5-54ab47d0792f@redhat.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
>
>
> On 1/21/19 9:12 AM, Tiwei Bie wrote:
> > Fix a possible out of bound access which may happen when handling
> > indirect descs in split ring.
> >
> > Fixes: 1be4ebb1c464 ("vhost: support indirect descriptor in mergeable
> Rx")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Haiyue Wang <haiyue.wang@intel.com>
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> >   lib/librte_vhost/virtio_net.c | 8 ++------
> >   1 file changed, 2 insertions(+), 6 deletions(-)
> >
>
>
> Applide to dpdk-next-virtio/master.
>
> Thanks,
> Maxime
>
>
>
> ------------------------------
>
> Message: 8
> Date: Mon, 21 Jan 2019 13:18:57 +0000
> From: "Hu, Xuekun" <xuekun.hu@intel.com>
> To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, Ravi Kerur
>         <rkerur@gmail.com>
> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ananyev, Konstantin"
>         <konstantin.ananyev@intel.com>, "Lu, Wenzhuo" <
> wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue
> Message-ID:
>         <
> 88A92D351643BA4CB23E30315517062663547499@SHSMSX103.ccr.corp.intel.com>
>
> Content-Type: text/plain; charset="utf-8"
>
>
> > You might also want to look here:
> https://bugs.dpdk.org/show_bug.cgi?id=76
>
> > There are apparently issues with some kernel versions that will manifest
> themselves as problems with using VF devices with IOMMU in a VM.
>
> Thanks, Anatoly. By updating host kernel to 4.18, the issue is gone. ?
>
> End of dev Digest, Vol 231, Issue 6
> ***********************************
>