From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A40A0547; Sun, 7 Feb 2021 10:38:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6969640147; Sun, 7 Feb 2021 10:38:38 +0100 (CET) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 4EB054067B for ; Fri, 5 Feb 2021 17:54:59 +0100 (CET) Received: by mail-lf1-f48.google.com with SMTP id v24so10819674lfr.7 for ; Fri, 05 Feb 2021 08:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5X+7+VwtBjMkpuApwPzgsmGZj+bhFMvZgAV6Cm/gmyU=; b=LUuZZ40Ea/K9hjg6OljGA7fUAvGkvIMFDgEIXYJjK24yYU1aXGhFAJKOUg8bEHmLiw Sw/aFPMSsEkhjUDTcWAGJYlosvMqXQmD3UIHOfaY79tICPTTI2lptqsSyQm2FgElBtD9 wmuwfrTs+nOK53OxyB/O1qu868yJamoSER+peXPeflSlP/0mhNcDiYLskWzKLeKBTGtU 0/N5mPJf5qPAxHRkY5sdvlu9AmM2o4BfCXegiI7OG24QHqUFDGV5Tw9qzZEsMCYUZTCA +PMCfWvkjSqKYqOevzdURcTjNVoc/51DUrRFPrQie/Woug2k0lFantlEreiJYP/uy1ul wM4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5X+7+VwtBjMkpuApwPzgsmGZj+bhFMvZgAV6Cm/gmyU=; b=lEnCiMLETIq3fxOet5Z5nlfY2tmTXtxxMKyrKeoyBonTdd4frHvW5PjtSe4kt3mkpt 25u4SJpEAzDjZ75lFd+AaPDTEHaqz8Qd/UQem6DIywvYs8WHNEtqrnpv54P8iOdEQpBt cs1BjmSp0Q94VhsqwQwAX4FtH+UVlTLF7XLq0MxG9gOj0DoxmYXEExzLYyoslFUxJidS HBboEyT1Da1GyvX5did1mfPSmnXfNyFNpl5h9ibEW+gCF6A96FuHV2ShGVuDSq+8/XYD zkl/MJ34r1MZDCekWqfi21We9qcVjmxW+H7S1vwtFcKJOoKbhiWdrdHpVLZnfF82yFaC DhWA== X-Gm-Message-State: AOAM532uBdG07A8Wg9Xa22TJRz+wpyykTq3uJagQ8zja54aER4ZCQijf DXSRgifGhMoWxmQ7CwWGB4v2u+Jd9n5atxptmxk= X-Google-Smtp-Source: ABdhPJxTFJ3QOeOa3l6V1h2LwrlSzYPg+bGh+DrUmpE/mtmzYzpQC/e7WUUO8pwvmmtuieoDtNqgw3qBnnCxccrD0VI= X-Received: by 2002:ac2:4d24:: with SMTP id h4mr3139979lfk.458.1612544098517; Fri, 05 Feb 2021 08:54:58 -0800 (PST) MIME-Version: 1.0 References: <20210205112433.1681853-1-fengli@smartx.com> <20210205081056.32c69647@hermes.local> In-Reply-To: <20210205081056.32c69647@hermes.local> From: Feng Li Date: Sat, 6 Feb 2021 00:54:30 +0800 Message-ID: To: stephen@networkplumber.org Cc: David Marchand , Li Feng , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sun, 07 Feb 2021 10:38:37 +0100 Subject: Re: [dpdk-dev] [PATCH] log: support custom log function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Stephen Hemminger =E4=BA=8E2021=E5=B9=B42=E6= =9C=886=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=8812:11=E5=86=99=E9=81= =93=EF=BC=9A > > On Fri, 5 Feb 2021 12:55:48 +0100 > David Marchand wrote: > > > On Fri, Feb 5, 2021 at 12:25 PM Li Feng wrote: > > > > > > Currently, the dpdk log is out to stdout/stderr and syslog. > > > We should support to output the log to another please, e.g. file or > > > glog. > > > > Why not use rte_openlog_stream() / rte_log_get_stream() ? > > Agree, I have used rte_openlog_stream several times to do this. As Dmitry Kozlyuk said, FILE* is convenient for the C/libc, but not for other languages. C++ standard IO stream is the case.