From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BA41A053D; Fri, 17 Jul 2020 17:36:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 123B02C57; Fri, 17 Jul 2020 17:36:09 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id C11C625B3 for ; Fri, 17 Jul 2020 17:36:07 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id d11so5070600vsq.3 for ; Fri, 17 Jul 2020 08:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ZLQOhT+wcAzFzzkM8h2DSBWouU/6ngLCJaF+pAzNbg=; b=W93ABklxN/JyUVbi92BL/VIkqPgW0Pf1kRe/fi8u65V7wpB59sxEfyl3DKDIN/HpRR 8WlBNH/rD2231d5Mls+faWOtWGGXuzQlcwRLYVW3Zirxc5I1ZON95VU/iNyCp7WeWXJI EUMGkErLDpxnlO5ROcpNvXR8khQQqT1cLJ7cCond3OIAP/Vi1k1zkSCbA1+G9RAcezyj NqjBSOIpopKzZ1bzTHg6wW6CoIZtU5V7UPOEce8aBbAP3EuWeuxYy5pJXssjYSgi7J56 1jgfckakWO29TXXucJXd94zi3eyGtqxOBmSXRaTGPnjntGhiE0/ML39kJFg9m6WeUkJc FAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ZLQOhT+wcAzFzzkM8h2DSBWouU/6ngLCJaF+pAzNbg=; b=Fk4iTfmXcnv4zeLElrNyNnOnLloqkOqX2K1+TQJin9jtK8e2aeI2RbIG4zjpWL/lqg QrNskXx7OHAUzviTgMuorSmMHtwYW2oxlhMAUu9WcQLJbendSAAcjZ322oBEYHqpk2L8 z6fRlS39SRtFdRWubHGSpgjSbCifLDZuKKvtcOnFMHXVpPs8ZU3COInWRejb4qV0bfDx 70ppGtyT+aGh55stMS0awK1fKpFnS/PmmQEFevlD0Np21IJCD05x+jq9CEe71zC2IB/5 jw+0akPUHc6DfnU5GratQeCur2chaKWELZjhAsLI7SWRlb1FoF/LvebpwXDmL8zo63sM h2hA== X-Gm-Message-State: AOAM533XyGQeh/buJ7b7l+Q8qE7ia1QdnXpRn3UHQV8MIibGMp38PvUt OAgFWNpgorJ4FHgrhF6WLYFgyMg0420uOJIfcTg= X-Google-Smtp-Source: ABdhPJyuguyYffY2qeVRxUUSr2wz3V0K5s/VBmD9D2p5B1xBH6SQywq0BKPLCEWLQdOYylLyJxsa1/xRzxNkmnZoFPY= X-Received: by 2002:a67:c208:: with SMTP id i8mr7571945vsj.167.1595000167014; Fri, 17 Jul 2020 08:36:07 -0700 (PDT) MIME-Version: 1.0 References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> <20200715132910.5aaa11ed@hermes.lan> <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> <20200716150429.664a524e@hermes.lan> <88cf6911-c0e5-1f37-5f2d-51232d8dc787@intel.com> In-Reply-To: <88cf6911-c0e5-1f37-5f2d-51232d8dc787@intel.com> From: Dmitry Kozliuk Date: Fri, 17 Jul 2020 18:35:54 +0300 Message-ID: To: "Burakov, Anatoly" Cc: Stephen Hemminger , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 17, 2020, 18:21 Burakov, Anatoly wrote: > On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: > > On Thu, 16 Jul 2020 14:41:41 +0100 > > "Burakov, Anatoly" wrote: > > > >> On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > >>> On Wed, 15 Jul 2020 14:28:17 +0100 > >>> "Burakov, Anatoly" wrote: > >>> > >>>>> -#define SKIP_MASTER SKIP_INITIAL > >>>>> -#define CALL_MASTER CALL_INITIAL > >>>>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is > deprecated\"") SKIP_INITIAL > >>>>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is > deprecated\"") CALL_INITIAL > >>>> > >>>> Presumably this is a generic header, should we introduce GCC-specific > >>>> things there? > >>> > >>> It works with Clang as well. Likely ICC but don't have that. > >>> > >> > >> What about MSVC? > FYI, DPDK on Windows is compiled with Clang, only linker is from MSVC. And MinGW uses GCC toolchain. Why care about MSVC here?