From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63D13A04FD; Mon, 23 May 2022 12:54:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 461A440141; Mon, 23 May 2022 12:54:03 +0200 (CEST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by mails.dpdk.org (Postfix) with ESMTP id 256C940041 for ; Mon, 23 May 2022 12:54:01 +0200 (CEST) Received: by mail-yb1-f170.google.com with SMTP id d137so24617226ybc.13 for ; Mon, 23 May 2022 03:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e4xBJMkgMLzC7VDsEJVmSwGiZ2H25KTlBevZU3B4JOw=; b=YS8S3kZE0qw5HhFon+zEblMPgRWq2g+gHBIfy740gTGeD6HejDBNBLi2ye09BclCTk f1hi/0Enf0j3FqvYMrgmmL+cWPl2Dr3U2xszonbcpZ59XbbUpRBfsmnebeF7pjaoEHfk PXijl7DU2/8cQdgjQTc+EJOJk6hnKqLEIDGtesXMgsWsDptEJ6ozH5MMNxCFS6qudBgo qXGO/l/AeZmp3nj7+ILEfmEU3ReOsoLJy0S9fuAuM3U5c4uA3f74XDb7pJQ3SkntK7kC OhgJWs/zAJCr8SxjiQ9Ohy0j66Z5Y1FATCsqHdwmplNE6KzjkJtwCZvEsHwmx8XvH1y5 fkaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e4xBJMkgMLzC7VDsEJVmSwGiZ2H25KTlBevZU3B4JOw=; b=QcqA2Ov/EDzSrwZKSVfCRO+YJtGB2W3thfErmh5qdVGNAaieUVKMlZE/5pyt1TjctZ u8q4M7yMbD5YEeCaUOpbwJTvJtGJcggHUphclykqcB28Kwan2+GlIXnMlamoFEC7KFnk 4lQMra1aYRoU1fJyChDbHVLZjnXUI9V1On6BtU3ZPzVmdq0VEVxe/3k+z9aDc6X9nXkJ Z96oL0bsfhEjdbtUmOAB62ZnoOPeFj3VorXoW2Re/xlEpND7JBk41U72ulB+QCF/VHwA Rwubv8lF70sW3QNTU+6ZXGel1cBdSEa0pL3uQ2G3PWPPMBPjX1/VH8Aew+vVLFuF67Hn 6qzg== X-Gm-Message-State: AOAM5327X41DxzPQYwciKoZ3ty0LeaZtcHGseRC0ab4tqbM4flYbxJl5 SA440WCU0XiIdKsCaD0cIUbl9pCQpa0S0A9oMDvZ X-Google-Smtp-Source: ABdhPJzpE/zgWHVbaR8AHX5jWZsldkuLnE45im8UJSfJBrcdZih8pExrywP0XiHQSNRX26njmuylaEH/Sr6mtIvETtg= X-Received: by 2002:a25:bac7:0:b0:64c:b780:90d3 with SMTP id a7-20020a25bac7000000b0064cb78090d3mr21606994ybk.10.1653303240513; Mon, 23 May 2022 03:54:00 -0700 (PDT) MIME-Version: 1.0 References: <20220510132118.22688-1-subendu@arista.com> In-Reply-To: <20220510132118.22688-1-subendu@arista.com> From: Subendu Santra Date: Mon, 23 May 2022 16:23:44 +0530 Message-ID: Subject: Re: [PATCH] app/procinfo: show all non-owned ports To: Reshma Pattan , Stephen Hemminger , Hemant Agrawal Cc: dev@dpdk.org, Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Reshma, Thomas, What do you think about this patch? Regards, Subendu. On Tue, May 10, 2022 at 6:52 PM Subendu Santra wrote: > > Show all non-owned ports when no port mask is specified > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned > ports") > Cc: stephen@networkplumber.org > > Signed-off-by: Subendu Santra > --- > app/proc-info/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index 56070a3317..2be24b584e 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -1504,10 +1504,10 @@ main(int argc, char **argv) > if (nb_ports == 0) > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > - /* If no port mask was specified, then show non-owned ports */ > + /* If no port mask was specified, then show all non-owned ports */ > if (enabled_port_mask == 0) { > RTE_ETH_FOREACH_DEV(i) > - enabled_port_mask = 1ul << i; > + enabled_port_mask |= (1ul << i); > } > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > -- > 2.28.0 >