From: Subendu Santra <subendu@arista.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
dev@dpdk.org
Subject: Re: [PATCH] app/procinfo: show all non-owned ports
Date: Mon, 23 May 2022 21:40:54 +0530 [thread overview]
Message-ID: <CAEc=+OkCE8pA8H_6wXhz+G_QhSf4-qD9W5DKXM_HQFwa8KRQMQ@mail.gmail.com> (raw)
In-Reply-To: <23962511.kmuVQn2iE0@thomas>
Sure. Will add a sentence about the issue which is getting fixed.
However, I have already added Fixes: 1dd6cffb6571 in the patch.
Is there anything else that needs to be done apart from this w.r.to
"Fixes:" comment?
Regards,
Subendu.
On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 23/05/2022 12:53, Subendu Santra:
> > Hi Reshma, Thomas,
> >
> > What do you think about this patch?
>
> It looks to be a fix, right?
> Please add a sentence about the previous behaviour,
> explaining what is fixed.
>
> Ideally you should show the commit doing the mistake
> with the syntax "Fixes:" as in other commits of this tree.
>
> Thanks
>
>
> > On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
> > >
> > > Show all non-owned ports when no port mask is specified
> > >
> > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> > > ports")
> > > Cc: stephen@networkplumber.org
> > >
> > > Signed-off-by: Subendu Santra <subendu@arista.com>
> > > ---
> > > app/proc-info/main.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> > > index 56070a3317..2be24b584e 100644
> > > --- a/app/proc-info/main.c
> > > +++ b/app/proc-info/main.c
> > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> > > if (nb_ports == 0)
> > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
> > >
> > > - /* If no port mask was specified, then show non-owned ports */
> > > + /* If no port mask was specified, then show all non-owned ports */
> > > if (enabled_port_mask == 0) {
> > > RTE_ETH_FOREACH_DEV(i)
> > > - enabled_port_mask = 1ul << i;
> > > + enabled_port_mask |= (1ul << i);
> > > }
> > >
> > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> > > --
> > > 2.28.0
> > >
> >
>
>
>
>
>
next prev parent reply other threads:[~2022-05-23 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 13:21 Subendu Santra
2022-05-23 10:53 ` Subendu Santra
2022-05-23 14:41 ` Thomas Monjalon
2022-05-23 16:10 ` Subendu Santra [this message]
2022-05-23 18:00 ` Thomas Monjalon
2022-05-25 5:52 ` [PATCH v2] " Subendu Santra
2022-05-25 5:58 ` Subendu Santra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEc=+OkCE8pA8H_6wXhz+G_QhSf4-qD9W5DKXM_HQFwa8KRQMQ@mail.gmail.com' \
--to=subendu@arista.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).