* [PATCH] app/procinfo: show all non-owned ports
@ 2022-05-10 13:21 Subendu Santra
2022-05-23 10:53 ` Subendu Santra
2022-05-25 5:52 ` [PATCH v2] " Subendu Santra
0 siblings, 2 replies; 7+ messages in thread
From: Subendu Santra @ 2022-05-10 13:21 UTC (permalink / raw)
To: Maryam Tahhan, Reshma Pattan, Stephen Hemminger, Hemant Agrawal
Cc: dev, Subendu Santra
Show all non-owned ports when no port mask is specified
Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
ports")
Cc: stephen@networkplumber.org
Signed-off-by: Subendu Santra <subendu@arista.com>
---
app/proc-info/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 56070a3317..2be24b584e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1504,10 +1504,10 @@ main(int argc, char **argv)
if (nb_ports == 0)
rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
- /* If no port mask was specified, then show non-owned ports */
+ /* If no port mask was specified, then show all non-owned ports */
if (enabled_port_mask == 0) {
RTE_ETH_FOREACH_DEV(i)
- enabled_port_mask = 1ul << i;
+ enabled_port_mask |= (1ul << i);
}
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] app/procinfo: show all non-owned ports
2022-05-10 13:21 [PATCH] app/procinfo: show all non-owned ports Subendu Santra
@ 2022-05-23 10:53 ` Subendu Santra
2022-05-23 14:41 ` Thomas Monjalon
2022-05-25 5:52 ` [PATCH v2] " Subendu Santra
1 sibling, 1 reply; 7+ messages in thread
From: Subendu Santra @ 2022-05-23 10:53 UTC (permalink / raw)
To: Reshma Pattan, Stephen Hemminger, Hemant Agrawal; +Cc: dev, Thomas Monjalon
Hi Reshma, Thomas,
What do you think about this patch?
Regards,
Subendu.
On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
>
> Show all non-owned ports when no port mask is specified
>
> Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> ports")
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Subendu Santra <subendu@arista.com>
> ---
> app/proc-info/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index 56070a3317..2be24b584e 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> if (nb_ports == 0)
> rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
>
> - /* If no port mask was specified, then show non-owned ports */
> + /* If no port mask was specified, then show all non-owned ports */
> if (enabled_port_mask == 0) {
> RTE_ETH_FOREACH_DEV(i)
> - enabled_port_mask = 1ul << i;
> + enabled_port_mask |= (1ul << i);
> }
>
> for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] app/procinfo: show all non-owned ports
2022-05-23 10:53 ` Subendu Santra
@ 2022-05-23 14:41 ` Thomas Monjalon
2022-05-23 16:10 ` Subendu Santra
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2022-05-23 14:41 UTC (permalink / raw)
To: Subendu Santra; +Cc: Reshma Pattan, Stephen Hemminger, Hemant Agrawal, dev
23/05/2022 12:53, Subendu Santra:
> Hi Reshma, Thomas,
>
> What do you think about this patch?
It looks to be a fix, right?
Please add a sentence about the previous behaviour,
explaining what is fixed.
Ideally you should show the commit doing the mistake
with the syntax "Fixes:" as in other commits of this tree.
Thanks
> On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
> >
> > Show all non-owned ports when no port mask is specified
> >
> > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> > ports")
> > Cc: stephen@networkplumber.org
> >
> > Signed-off-by: Subendu Santra <subendu@arista.com>
> > ---
> > app/proc-info/main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> > index 56070a3317..2be24b584e 100644
> > --- a/app/proc-info/main.c
> > +++ b/app/proc-info/main.c
> > @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> > if (nb_ports == 0)
> > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
> >
> > - /* If no port mask was specified, then show non-owned ports */
> > + /* If no port mask was specified, then show all non-owned ports */
> > if (enabled_port_mask == 0) {
> > RTE_ETH_FOREACH_DEV(i)
> > - enabled_port_mask = 1ul << i;
> > + enabled_port_mask |= (1ul << i);
> > }
> >
> > for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> > --
> > 2.28.0
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] app/procinfo: show all non-owned ports
2022-05-23 14:41 ` Thomas Monjalon
@ 2022-05-23 16:10 ` Subendu Santra
2022-05-23 18:00 ` Thomas Monjalon
0 siblings, 1 reply; 7+ messages in thread
From: Subendu Santra @ 2022-05-23 16:10 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Reshma Pattan, Stephen Hemminger, Hemant Agrawal, dev
Sure. Will add a sentence about the issue which is getting fixed.
However, I have already added Fixes: 1dd6cffb6571 in the patch.
Is there anything else that needs to be done apart from this w.r.to
"Fixes:" comment?
Regards,
Subendu.
On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 23/05/2022 12:53, Subendu Santra:
> > Hi Reshma, Thomas,
> >
> > What do you think about this patch?
>
> It looks to be a fix, right?
> Please add a sentence about the previous behaviour,
> explaining what is fixed.
>
> Ideally you should show the commit doing the mistake
> with the syntax "Fixes:" as in other commits of this tree.
>
> Thanks
>
>
> > On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
> > >
> > > Show all non-owned ports when no port mask is specified
> > >
> > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> > > ports")
> > > Cc: stephen@networkplumber.org
> > >
> > > Signed-off-by: Subendu Santra <subendu@arista.com>
> > > ---
> > > app/proc-info/main.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> > > index 56070a3317..2be24b584e 100644
> > > --- a/app/proc-info/main.c
> > > +++ b/app/proc-info/main.c
> > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> > > if (nb_ports == 0)
> > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
> > >
> > > - /* If no port mask was specified, then show non-owned ports */
> > > + /* If no port mask was specified, then show all non-owned ports */
> > > if (enabled_port_mask == 0) {
> > > RTE_ETH_FOREACH_DEV(i)
> > > - enabled_port_mask = 1ul << i;
> > > + enabled_port_mask |= (1ul << i);
> > > }
> > >
> > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> > > --
> > > 2.28.0
> > >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] app/procinfo: show all non-owned ports
2022-05-23 16:10 ` Subendu Santra
@ 2022-05-23 18:00 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2022-05-23 18:00 UTC (permalink / raw)
To: Subendu Santra; +Cc: Reshma Pattan, Stephen Hemminger, Hemant Agrawal, dev
23/05/2022 18:10, Subendu Santra:
> Sure. Will add a sentence about the issue which is getting fixed.
> However, I have already added Fixes: 1dd6cffb6571 in the patch.
Sorry I missed it.
> Is there anything else that needs to be done apart from this w.r.to
> "Fixes:" comment?
No that's fine, thanks.
>
> Regards,
> Subendu.
>
>
> On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 23/05/2022 12:53, Subendu Santra:
> > > Hi Reshma, Thomas,
> > >
> > > What do you think about this patch?
> >
> > It looks to be a fix, right?
> > Please add a sentence about the previous behaviour,
> > explaining what is fixed.
> >
> > Ideally you should show the commit doing the mistake
> > with the syntax "Fixes:" as in other commits of this tree.
> >
> > Thanks
> >
> >
> > > On Tue, May 10, 2022 at 6:52 PM Subendu Santra <subendu@arista.com> wrote:
> > > >
> > > > Show all non-owned ports when no port mask is specified
> > > >
> > > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> > > > ports")
> > > > Cc: stephen@networkplumber.org
> > > >
> > > > Signed-off-by: Subendu Santra <subendu@arista.com>
> > > > ---
> > > > app/proc-info/main.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> > > > index 56070a3317..2be24b584e 100644
> > > > --- a/app/proc-info/main.c
> > > > +++ b/app/proc-info/main.c
> > > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> > > > if (nb_ports == 0)
> > > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
> > > >
> > > > - /* If no port mask was specified, then show non-owned ports */
> > > > + /* If no port mask was specified, then show all non-owned ports */
> > > > if (enabled_port_mask == 0) {
> > > > RTE_ETH_FOREACH_DEV(i)
> > > > - enabled_port_mask = 1ul << i;
> > > > + enabled_port_mask |= (1ul << i);
> > > > }
> > > >
> > > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> > > > --
> > > > 2.28.0
> > > >
> > >
> >
> >
> >
> >
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] app/procinfo: show all non-owned ports
2022-05-10 13:21 [PATCH] app/procinfo: show all non-owned ports Subendu Santra
2022-05-23 10:53 ` Subendu Santra
@ 2022-05-25 5:52 ` Subendu Santra
2022-05-25 5:58 ` Subendu Santra
1 sibling, 1 reply; 7+ messages in thread
From: Subendu Santra @ 2022-05-25 5:52 UTC (permalink / raw)
To: Maryam Tahhan, Reshma Pattan, Stephen Hemminger, Hemant Agrawal
Cc: dev, Subendu Santra
Show all non-owned ports when no port mask is specified
show-port option without the mask option, displays only the last
non-owned port. Show all the non-owned ports instead.
Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
ports")
Cc: stephen@networkplumber.org
Signed-off-by: Subendu Santra <subendu@arista.com>
---
app/proc-info/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 56070a3317..2be24b584e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1504,10 +1504,10 @@ main(int argc, char **argv)
if (nb_ports == 0)
rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
- /* If no port mask was specified, then show non-owned ports */
+ /* If no port mask was specified, then show all non-owned ports */
if (enabled_port_mask == 0) {
RTE_ETH_FOREACH_DEV(i)
- enabled_port_mask = 1ul << i;
+ enabled_port_mask |= (1ul << i);
}
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
--
2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] app/procinfo: show all non-owned ports
2022-05-25 5:52 ` [PATCH v2] " Subendu Santra
@ 2022-05-25 5:58 ` Subendu Santra
0 siblings, 0 replies; 7+ messages in thread
From: Subendu Santra @ 2022-05-25 5:58 UTC (permalink / raw)
To: Reshma Pattan, Stephen Hemminger, Hemant Agrawal, Thomas Monjalon; +Cc: dev
I have updated the v2 of the patch with the explanation.
Kindly advise if it looks ok.
Regards,
Subendu.
On Wed, May 25, 2022 at 11:22 AM Subendu Santra <subendu@arista.com> wrote:
>
> Show all non-owned ports when no port mask is specified
>
> show-port option without the mask option, displays only the last
> non-owned port. Show all the non-owned ports instead.
>
> Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
> ports")
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Subendu Santra <subendu@arista.com>
> ---
> app/proc-info/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index 56070a3317..2be24b584e 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -1504,10 +1504,10 @@ main(int argc, char **argv)
> if (nb_ports == 0)
> rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
>
> - /* If no port mask was specified, then show non-owned ports */
> + /* If no port mask was specified, then show all non-owned ports */
> if (enabled_port_mask == 0) {
> RTE_ETH_FOREACH_DEV(i)
> - enabled_port_mask = 1ul << i;
> + enabled_port_mask |= (1ul << i);
> }
>
> for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-25 5:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 13:21 [PATCH] app/procinfo: show all non-owned ports Subendu Santra
2022-05-23 10:53 ` Subendu Santra
2022-05-23 14:41 ` Thomas Monjalon
2022-05-23 16:10 ` Subendu Santra
2022-05-23 18:00 ` Thomas Monjalon
2022-05-25 5:52 ` [PATCH v2] " Subendu Santra
2022-05-25 5:58 ` Subendu Santra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).