From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65367A00C2; Mon, 23 May 2022 18:11:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B705427F2; Mon, 23 May 2022 18:11:13 +0200 (CEST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by mails.dpdk.org (Postfix) with ESMTP id 06B204161A for ; Mon, 23 May 2022 18:11:12 +0200 (CEST) Received: by mail-yb1-f170.google.com with SMTP id i187so24037385ybg.6 for ; Mon, 23 May 2022 09:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uAHEtzr1P7tBYH7sKKixcZVITRyo1ZbTcdhwPuGVITU=; b=D3ZEhExluvoYFbygeZlaHgfKKhvLCmTy35sBfZpBGlx8VDUlxVFXQVciytjM9fvMRx j3Uz8x1NAZR9gTs5g6IBsap61bXALcjexL47oD84jBeHYyOQowsSNOye3V5jFZZQMnVF CkfIITgWoyQBCOkQ9gjsFCJ0nYZA6rYHL6cb6G/Y2oPd9rT+yNK0WozRwVdmljPQvBfG 52zTzWq8IQEy8/9cPnmm+1Te7S8NwlPJSvj7kiSjxMv2cIVPxrHqnS5rJcPu3Xk7EeIb LjysCQ4TYKTpgzQ/Q+dw8KA6xx/HtSshPkYArL/7wh+swZ9EVWWY7J+AUu0edQkTcOOY ervw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uAHEtzr1P7tBYH7sKKixcZVITRyo1ZbTcdhwPuGVITU=; b=1tvT5Px9trUAq95mYPSis0+sF8vdLdUE0doPF1XYUR01O9GXq0LKokw8tItaOhYHgg NbDRTprmTaYnAOE4tlhnIvUQImaP9nBxLkEZBGErvlrnSKhfFFXmD6pZH/l9nWlFamKv 8RLJN9BIG6AfwhtILX7qPIndLVMpqNRP+SzORpPGYr1EraQ4/j4JCVjhYXGrvqvZf2V5 Z8g42DDdrXeFZklECAI+uNXH4K9lEU2j0LeL5YRcT/F3zUnlg2u/z6EQONPHR7m6ta0L VpXVPY0gNCV1k5uAymS5vTu0dOQ4+4Qyi7SazYi+pumDIbuObMO20r3g+zqB/1wEIASE PmRQ== X-Gm-Message-State: AOAM532HofBhXBh+/5++o1IvoCgemYxsS/sl++Zxr9eh1BZrEyEjPiOB 5Vd6b6/POPzlnrwLNXpAvZecTAGa+4fZEiSLH1zF X-Google-Smtp-Source: ABdhPJyJr1pjYmZE6KkGnPSY1oD1pYWgfG+XODivjPe+g//ESO25NfCwaHMpeANHN53NwZBMRv/u3L8Tpd9yvz3SHNY= X-Received: by 2002:a05:6902:1346:b0:64d:87fd:1863 with SMTP id g6-20020a056902134600b0064d87fd1863mr22570188ybu.468.1653322271379; Mon, 23 May 2022 09:11:11 -0700 (PDT) MIME-Version: 1.0 References: <20220510132118.22688-1-subendu@arista.com> <23962511.kmuVQn2iE0@thomas> In-Reply-To: <23962511.kmuVQn2iE0@thomas> From: Subendu Santra Date: Mon, 23 May 2022 21:40:54 +0530 Message-ID: Subject: Re: [PATCH] app/procinfo: show all non-owned ports To: Thomas Monjalon Cc: Reshma Pattan , Stephen Hemminger , Hemant Agrawal , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sure. Will add a sentence about the issue which is getting fixed. However, I have already added Fixes: 1dd6cffb6571 in the patch. Is there anything else that needs to be done apart from this w.r.to "Fixes:" comment? Regards, Subendu. On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon wrote: > > 23/05/2022 12:53, Subendu Santra: > > Hi Reshma, Thomas, > > > > What do you think about this patch? > > It looks to be a fix, right? > Please add a sentence about the previous behaviour, > explaining what is fixed. > > Ideally you should show the commit doing the mistake > with the syntax "Fixes:" as in other commits of this tree. > > Thanks > > > > On Tue, May 10, 2022 at 6:52 PM Subendu Santra wrote: > > > > > > Show all non-owned ports when no port mask is specified > > > > > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned > > > ports") > > > Cc: stephen@networkplumber.org > > > > > > Signed-off-by: Subendu Santra > > > --- > > > app/proc-info/main.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > > > index 56070a3317..2be24b584e 100644 > > > --- a/app/proc-info/main.c > > > +++ b/app/proc-info/main.c > > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv) > > > if (nb_ports == 0) > > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > > > > > - /* If no port mask was specified, then show non-owned ports */ > > > + /* If no port mask was specified, then show all non-owned ports */ > > > if (enabled_port_mask == 0) { > > > RTE_ETH_FOREACH_DEV(i) > > > - enabled_port_mask = 1ul << i; > > > + enabled_port_mask |= (1ul << i); > > > } > > > > > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > > > -- > > > 2.28.0 > > > > > > > > > >