From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8704A0548; Wed, 25 May 2022 07:58:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C829D40146; Wed, 25 May 2022 07:58:35 +0200 (CEST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by mails.dpdk.org (Postfix) with ESMTP id 270F2400EF for ; Wed, 25 May 2022 07:58:34 +0200 (CEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-30026b1124bso46633377b3.1 for ; Tue, 24 May 2022 22:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qR5hz6GztIEnBl2H8mYcP6S44glzjhi8XWAwYl80fGM=; b=TMS21SX++xShyc1tBnJmqAWKaqc9e229sgvMBnoluaW2Ae6/kINHMBg6HQBOhz+7Hx 7AMrsCooLXTVNtVu0we2Dzzu62i1AEcDQxaZA+QILvHfa1tEauwwLVwu/IZ/tQuv8sUw kNNsf+odHLvJeaaU475NRQ3/Ie21jz5VLp/m1r3Dm/U6AnOzUbhwW2RDUM51UYJXb/7z adeimn/Y6pnMtO221mgJ8hl0wNPLgJoLFNoTd5ehaIUIPhBTOdqZuqVCvMoSA5EXIc03 du/ga2VmpsD3GkLkdw/v6nZuKYxnharBhPIxGzAAghjbu3qDc9UZNZwOt+J98mBoGAbp J+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qR5hz6GztIEnBl2H8mYcP6S44glzjhi8XWAwYl80fGM=; b=aPYWPALokRvx9QJw/BK8Zdj9Zt2pqk5AJv2qxGYeoZYKCzny7sYxRYyas5znEX/HWF nmdJNJm8dzxfl3IeF7lqb3t2548w+CpvPRvtVFjs+u79dFScJoyQqONePOTgRNH+Rc/p kmqO64WKrUcp+Gbi9ozdUvh93LewegCM3OZ4SbY7yvIzkmRu6nwUu/4fPXKMGbrp28A+ gyaaLoou3xajoOkM7Y3iqXBWVDc6KljNtLNOpXGJVb4GPqzqyF3z9BzwAATOnhdgohZd fpn82ZB3W/82lz7PWgNlLynjyUpidycb7q661dB+P2SCzIZKk9b6WuHcI1zAS2Kt+79I fdeg== X-Gm-Message-State: AOAM5305Haeun+8UpSmC14NIcD+5zollQ0xD0QZ7pMgGcfZsOEIxiGJx DBu4sgMMdJkk2SNSTzse5FYb8QoyCxMMzTiU8X4r X-Google-Smtp-Source: ABdhPJzqLkVoMMIrR51IZ1T4CU0H2G8L3aTvnNCJXL0shp81g830+oCq0rUDOsUi3+7o7T3s9dlq63G2G6rS47tABhs= X-Received: by 2002:a81:949:0:b0:2f7:c45b:e291 with SMTP id 70-20020a810949000000b002f7c45be291mr31734023ywj.503.1653458313454; Tue, 24 May 2022 22:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20220510132118.22688-1-subendu@arista.com> <20220525055250.22541-1-subendu@arista.com> In-Reply-To: <20220525055250.22541-1-subendu@arista.com> From: Subendu Santra Date: Wed, 25 May 2022 11:28:16 +0530 Message-ID: Subject: Re: [PATCH v2] app/procinfo: show all non-owned ports To: Reshma Pattan , Stephen Hemminger , Hemant Agrawal , Thomas Monjalon Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I have updated the v2 of the patch with the explanation. Kindly advise if it looks ok. Regards, Subendu. On Wed, May 25, 2022 at 11:22 AM Subendu Santra wrote: > > Show all non-owned ports when no port mask is specified > > show-port option without the mask option, displays only the last > non-owned port. Show all the non-owned ports instead. > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned > ports") > Cc: stephen@networkplumber.org > > Signed-off-by: Subendu Santra > --- > app/proc-info/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index 56070a3317..2be24b584e 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -1504,10 +1504,10 @@ main(int argc, char **argv) > if (nb_ports == 0) > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > - /* If no port mask was specified, then show non-owned ports */ > + /* If no port mask was specified, then show all non-owned ports */ > if (enabled_port_mask == 0) { > RTE_ETH_FOREACH_DEV(i) > - enabled_port_mask = 1ul << i; > + enabled_port_mask |= (1ul << i); > } > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > -- > 2.28.0 >