From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAC7742F93; Wed, 2 Aug 2023 17:34:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E43640DDB; Wed, 2 Aug 2023 17:34:30 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id A229B4021D for ; Wed, 2 Aug 2023 17:34:28 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4fe44955decso1400008e87.1 for ; Wed, 02 Aug 2023 08:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690990468; x=1691595268; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sd7TwTc7cJstDM1OZBmCztMaVGL7L82LQp2uZSDURcY=; b=FEul9kLI44bZreqZawZe/xRW6VWT4Fd3N+fmfcTPfIBVK9m6TBGeHBS/+A40p6IrGw s5ClFqi7DrdnjSx05dV7JYPx52Q/RRbsGuRVdvFghdfji3JQNpyC9dek17lOGhFNjwCr JcEpIivQoje9SqQaHuyqJWf8ZRZssnBI+DH1dbwMvEA3taaWq4eYLzmBfOYQ+DhY/dQY pZuiqnf9nSTqee898X/Aj+pQlqVVzMZ33TX4Ngkgl913WK2DBlUMY7ko89bt6EcQSrBZ Z4nC9f2H8tSzjjK0UE7hSHW+Ye01Kxd7lwCfcFetKckz+JHiBIyUeSRNxnK6YOdv+Osg WFOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690990468; x=1691595268; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sd7TwTc7cJstDM1OZBmCztMaVGL7L82LQp2uZSDURcY=; b=Yi1BHYBmWNCzS6ZLDZGOWVSu2AKSebQEuQRGoO8fjpZic8aG/DrpIPqHo71K5MfHiQ bgs6oTnxmTGuxeqm3PrCUlpP3TYnpEUhP2TCq0E5dOaFLiiFnuzNA4RzTs9e35nn9KZY FRuXLkRV5lrlZN0dDm9OXwqerg9TB7aAShZJMBmFMPX72E5u/7bpIbcxqPkaU+ogBkBn J/xbTNv+h/v0GNtfr6wRgjBSYr7ca8yeWXwM1tnJXP9RlDQTQVY6oI7XxPplqHS7ilqY 0zg6XCw6HM8YgakCOeSWrwZa6KiFMgzVrHblSxlSxVO6a8dm+Qs9gpT/oO11nCY0A0ct wJ5g== X-Gm-Message-State: ABy/qLZErM6zWBQC932P6ypgBm4nmXv7FNON3YSasPpoBhWi3prDPouH 3zMl0UUA1UvZKScyKkzqS7iLc3Sx2+4XKZr+w30= X-Google-Smtp-Source: APBJJlF6XJPcevymSOp+rtnajiqCD0H0J5X68nPCKpeTsnaQNAsMsb4DfoowPCK25Y1baty0u+8DHZv+6rqvO9lOjfs= X-Received: by 2002:a05:6512:3b13:b0:4eb:4258:bf62 with SMTP id f19-20020a0565123b1300b004eb4258bf62mr2226015lfv.8.1690990467608; Wed, 02 Aug 2023 08:34:27 -0700 (PDT) MIME-Version: 1.0 References: <20230726013517.216549-1-dmiller423@gmail.com> In-Reply-To: From: David Miller Date: Wed, 2 Aug 2023 10:34:15 -0500 Message-ID: Subject: Re: [PATCH v3] Add support for IBM Z s390x To: David Marchand Cc: dev@dpdk.org, Mathew S Thoennes , Konstantin Ananyev , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Dmitry Kozlyuk , Yuying Zhang , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Qiming Yang , Wenjun Wu , Jakub Grajciar , Harman Kalra , Thomas Monjalon , David Christensen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, I'm happy to split it, I will resubmit when these changes are made. I was planning to spend some time to figure out why the CI abi test is failing / it had previously passed all tests locally. The (one) long term maintainer will be Mathew S Thoennes . I will relay your concerns about CI and have him speak with David Christens= en. - David Miller On Wed, Aug 2, 2023 at 10:25=E2=80=AFAM David Marchand wrote: > > Hello David, > > On Wed, Jul 26, 2023 at 3:35=E2=80=AFAM David Miller wrote: > > > > Minimal changes to drivers and app to support the IBM s390x. > > This seems a bit more than "minimal changes" :-). > > > > > Signed-off-by: David Miller > > Reviewed-by: Mathew S Thoennes > > --- > > app/test-acl/main.c | 4 + > > app/test/test_acl.c | 1 + > > app/test/test_atomic.c | 7 +- > > app/test/test_cmdline_ipaddr.c | 12 +- > > app/test/test_cmdline_num.c | 110 ++++ > > app/test/test_hash_functions.c | 29 + > > app/test/test_xmmt_ops.h | 14 + > > buildtools/pmdinfogen.py | 11 +- > > config/meson.build | 2 + > > config/s390x/meson.build | 51 ++ > > config/s390x/s390x_linux_clang_ubuntu | 19 + > > doc/guides/nics/features/i40e.ini | 1 + > > drivers/common/mlx5/mlx5_common.h | 9 + > > drivers/net/i40e/i40e_rxtx_vec_s390x.c | 630 +++++++++++++++++++ > > drivers/net/i40e/meson.build | 2 + > > drivers/net/ixgbe/ixgbe_rxtx.c | 8 +- > > drivers/net/memif/rte_eth_memif.h | 2 + > > drivers/net/mlx5/mlx5_rx.c | 24 +- > > drivers/net/octeontx/base/octeontx_pki_var.h | 6 + > > examples/l3fwd/l3fwd_em.c | 8 + > > examples/l3fwd/l3fwd_lpm_s390x.h | 137 ++++ > > examples/l3fwd/l3fwd_s390x.h | 261 ++++++++ > > lib/acl/acl_bld.c | 3 + > > lib/acl/acl_gen.c | 9 + > > lib/acl/acl_run_scalar.c | 8 + > > lib/acl/rte_acl.c | 27 + > > lib/acl/rte_acl.h | 5 +- > > lib/eal/s390x/include/meson.build | 16 + > > lib/eal/s390x/include/rte_atomic.h | 44 ++ > > lib/eal/s390x/include/rte_byteorder.h | 43 ++ > > lib/eal/s390x/include/rte_cpuflags.h | 41 ++ > > lib/eal/s390x/include/rte_cycles.h | 44 ++ > > lib/eal/s390x/include/rte_io.h | 184 ++++++ > > lib/eal/s390x/include/rte_mcslock.h | 18 + > > lib/eal/s390x/include/rte_memcpy.h | 55 ++ > > lib/eal/s390x/include/rte_pause.h | 22 + > > lib/eal/s390x/include/rte_power_intrinsics.h | 20 + > > lib/eal/s390x/include/rte_prefetch.h | 46 ++ > > lib/eal/s390x/include/rte_rwlock.h | 42 ++ > > lib/eal/s390x/include/rte_spinlock.h | 85 +++ > > lib/eal/s390x/include/rte_ticketlock.h | 18 + > > lib/eal/s390x/include/rte_vect.h | 35 ++ > > lib/eal/s390x/meson.build | 16 + > > lib/eal/s390x/rte_cpuflags.c | 91 +++ > > lib/eal/s390x/rte_cycles.c | 11 + > > lib/eal/s390x/rte_hypervisor.c | 11 + > > lib/eal/s390x/rte_power_intrinsics.c | 51 ++ > > lib/hash/rte_fbk_hash.h | 7 + > > lib/lpm/meson.build | 1 + > > lib/lpm/rte_lpm.h | 2 + > > lib/lpm/rte_lpm6.c | 18 + > > lib/lpm/rte_lpm_s390x.h | 130 ++++ > > meson.build | 2 + > > 53 files changed, 2439 insertions(+), 14 deletions(-) > > - This is too big to review. > Please split this patch separating the really minimum support (getting > EAL and main libraries to build, disabling the rest that is "broken" > for s390x) then adding more components support in later patches. > > RISC V and LoongArch "recent" additions are good examples. > https://patchwork.dpdk.org/project/dpdk/list/?series=3D23380&state=3D%2A&= archive=3Dboth > https://patchwork.dpdk.org/project/dpdk/list/?series=3D24969&state=3D%2A&= archive=3Dboth > > - We need one maintainer for this new architecture. > > - You'll notice that the DPDK CI reported issues, please fix them. > > - What are the plans in terms of CI? We need some compilation testing > and ideally some regular runtime testing. > Maybe you can reach out to IBM PPC DPDK guys, like David Christensen, > to see what they are doing. > > > -- > David Marchand >