From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f175.google.com (mail-ob0-f175.google.com [209.85.214.175]) by dpdk.org (Postfix) with ESMTP id 70E825A65 for ; Tue, 20 Oct 2015 16:55:30 +0200 (CEST) Received: by obbda8 with SMTP id da8so15899777obb.1 for ; Tue, 20 Oct 2015 07:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ibnYHpUWSBgYx2o6r6EAsV0vFFOUGta3aC4IpeNypFo=; b=HiBss0FITsnTXuxyr7uk6NwYHcRsyuL0/V1V6E0ZnrVSze5Zho4pR3qlELiMmlTQXP CX7lIquFQMeQmLuPiWcwRhLUr544UhWqbENAKpmxEozmxPODXVxLtvr7z+PC1Ffuyktl RIDW5BEoZgTdE7A7xj7pgOJykhrDRsmLEmPxldgtr7T28gvKN1GxOcqxY5aDtH/492ub YRzxB1i9jKHTIzyejGvvZFYrNBWAhqI12yANmoM1BVyG6VFqGAjN11B3P2r+RP47LQln ZW5i8osUzDSc1XI14x/7u7qf9r0Xf5gw4L/Ks3XqQC1D8xOumHxv9RseXFFQ9A1jT6ss 9y+A== X-Gm-Message-State: ALoCoQmnnp+XFF32U3COeX3Dsb2lBl7i7FDQNkaTbakBYeYbxEhQdVTy9Slm8lpdvdeJ62pSOh7C MIME-Version: 1.0 X-Received: by 10.182.165.131 with SMTP id yy3mr2361543obb.49.1445352929840; Tue, 20 Oct 2015 07:55:29 -0700 (PDT) Received: by 10.202.215.196 with HTTP; Tue, 20 Oct 2015 07:55:29 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB97725836AB2B3C@irsmsx105.ger.corp.intel.com> References: <1443729293-20753-2-git-send-email-konstantin.ananyev@intel.com> <1445292384-19815-1-git-send-email-amine.kherbouche@6wind.com> <1445292384-19815-2-git-send-email-amine.kherbouche@6wind.com> <20151019154427.65ccc42b@xeon-e3> <2601191342CEEE43887BDE71AB97725836AB2B3C@irsmsx105.ger.corp.intel.com> Date: Tue, 20 Oct 2015 16:55:29 +0200 Message-ID: From: Amine Kherbouche To: "Ananyev, Konstantin" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [dpdk-dev, PATCHv6 1/6] ethdev: enhance rte_eth_(tx|rx)q_info struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 14:55:30 -0000 > Yep, similar thought here: > In the for Intel HW implementations: > qinfo->used_desc = ixgbe_dev_rx_queue_count(dev, queue_id); > It seems a bit redundant, as if user wants to know HW state it can call > rte_eth_rx_queue_count() directly. > From other side: rte_eth_rx_queue_count() is quite heavyweight function, > as it scans HW descriptors to check their status. > I think it should be better to return here just a snapshot of SW state: > how many free/used RXDs are from PMD perspective > (by collecting info from *_rx_queue structure, without reading actual HW > registers/descriptors - as you done for TX queue info). > > Konstantin > Yes, Konstantin is right, it is a light solution to get an snapshot of the state of the queues.