[PATCH] maintainers: update for gve

[PATCH] maintainers: update for gve

[Junfeng Guo]

Add co-maintainers from Google team for gve (Google Virtual Ethernet).

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1c9922123e..d8c1d5272b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -698,6 +698,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <junfeng.guo@intel.com>
+M: Jeroen de Borst <jeroendb@google.com>
+M: Rushil Gupta <rushilg@google.com>
+M: Jordan Kimbrough <jrkim@google.com>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
-- 
2.34.1

Re: [PATCH] maintainers: update for gve

[Rushil Gupta]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Thanks a lot Junfeng!

On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com> wrote:

> Add co-maintainers from Google team for gve (Google Virtual Ethernet).
>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1c9922123e..d8c1d5272b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -698,6 +698,9 @@ F: doc/guides/nics/features/enic.ini
>
>  Google Virtual Ethernet
>  M: Junfeng Guo <junfeng.guo@intel.com>
> +M: Jeroen de Borst <jeroendb@google.com>
> +M: Rushil Gupta <rushilg@google.com>
> +M: Jordan Kimbrough <jrkim@google.com>
>  F: drivers/net/gve/
>  F: doc/guides/nics/gve.rst
>  F: doc/guides/nics/features/gve.ini
> --
> 2.34.1
>
>

[-- Attachment #2: Type: text/html, Size: 1456 bytes --]

Re: [PATCH] maintainers: update for gve

[Thomas Monjalon]

09/11/2022 20:37, Rushil Gupta:
> Thanks a lot Junfeng!
> 
> On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
> 
> > Add co-maintainers from Google team for gve (Google Virtual Ethernet).
> >
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > ---
> >  Google Virtual Ethernet
> >  M: Junfeng Guo <junfeng.guo@intel.com>
> > +M: Jeroen de Borst <jeroendb@google.com>
> > +M: Rushil Gupta <rushilg@google.com>
> > +M: Jordan Kimbrough <jrkim@google.com>

They were not part of the patch review process in the mailing list,
why do you want them to become maintainers?
I think it would be saner to have them involved first.

RE: [PATCH] maintainers: update for gve

[Guo, Junfeng]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, November 15, 2022 16:33
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> Jordan Kimbrough <jrkim@google.com>
> Subject: Re: [PATCH] maintainers: update for gve
> 
> 09/11/2022 20:37, Rushil Gupta:
> > Thanks a lot Junfeng!
> >
> > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> wrote:
> >
> > > Add co-maintainers from Google team for gve (Google Virtual
> Ethernet).
> > >
> > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > ---
> > >  Google Virtual Ethernet
> > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > +M: Jeroen de Borst <jeroendb@google.com>
> > > +M: Rushil Gupta <rushilg@google.com>
> > > +M: Jordan Kimbrough <jrkim@google.com>
> 
> They were not part of the patch review process in the mailing list,
> why do you want them to become maintainers?
> I think it would be saner to have them involved first.

Yes, make sense! Thanks for reminding this!

Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
could you help register for dev@dpdk.org 
at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first? 
Then you can add more info & explanation for your maintaining plan here.
Thanks!

> 

Re: [PATCH] maintainers: update for gve

[Rushil Gupta]

Done. Thanks Junfeng!



On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, November 15, 2022 16:33
> > To: Guo, Junfeng <junfeng.guo@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> > Jordan Kimbrough <jrkim@google.com>
> > Subject: Re: [PATCH] maintainers: update for gve
> >
> > 09/11/2022 20:37, Rushil Gupta:
> > > Thanks a lot Junfeng!
> > >
> > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> > wrote:
> > >
> > > > Add co-maintainers from Google team for gve (Google Virtual
> > Ethernet).
> > > >
> > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > > ---
> > > >  Google Virtual Ethernet
> > > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > > +M: Jeroen de Borst <jeroendb@google.com>
> > > > +M: Rushil Gupta <rushilg@google.com>
> > > > +M: Jordan Kimbrough <jrkim@google.com>
> >
> > They were not part of the patch review process in the mailing list,
> > why do you want them to become maintainers?
> > I think it would be saner to have them involved first.
>
> Yes, make sense! Thanks for reminding this!
>
> Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
> could you help register for dev@dpdk.org
> at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
> the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
> Then you can add more info & explanation for your maintaining plan here.
> Thanks!
>
> >
>
>

Re: [PATCH] maintainers: update for gve

[Jordan Kimbrough]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

I've also registered

On Tue, Nov 15, 2022 at 12:04 PM Rushil Gupta <rushilg@google.com> wrote:

> Done. Thanks Junfeng!
>
>
>
> On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Tuesday, November 15, 2022 16:33
> > > To: Guo, Junfeng <junfeng.guo@intel.com>
> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
> > > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
> > > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
> > > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
> > > Jordan Kimbrough <jrkim@google.com>
> > > Subject: Re: [PATCH] maintainers: update for gve
> > >
> > > 09/11/2022 20:37, Rushil Gupta:
> > > > Thanks a lot Junfeng!
> > > >
> > > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
> > > wrote:
> > > >
> > > > > Add co-maintainers from Google team for gve (Google Virtual
> > > Ethernet).
> > > > >
> > > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > > > > ---
> > > > >  Google Virtual Ethernet
> > > > >  M: Junfeng Guo <junfeng.guo@intel.com>
> > > > > +M: Jeroen de Borst <jeroendb@google.com>
> > > > > +M: Rushil Gupta <rushilg@google.com>
> > > > > +M: Jordan Kimbrough <jrkim@google.com>
> > >
> > > They were not part of the patch review process in the mailing list,
> > > why do you want them to become maintainers?
> > > I think it would be saner to have them involved first.
> >
> > Yes, make sense! Thanks for reminding this!
> >
> > Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
> > could you help register for dev@dpdk.org
> > at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
> > the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
> > Then you can add more info & explanation for your maintaining plan here.
> > Thanks!
> >
> > >
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 4307 bytes --]

Re: [PATCH] maintainers: update for gve

[Jeroen de Borst]

[-- Attachment #1: Type: text/plain, Size: 3029 bytes --]

This driver is for Google's virtual NIC and the team here at Google is
working on DPDK support. We were unaware of this driver until just a few
weeks ago.

There are many features missing from the driver currently released and our
team intends to make sure this driver support all relevant features of our
device (both current and upcoming). Since our team works closely with the
team that develops the virtual device, we can proactively add (and test)
features before they're made publicly available.

Some of these features are:

   - Jumbo-frame support
   - A new queue format (that supports out-of-order completions)
   - RSS support
   - Flow-steering
   - Header-split

We're grateful to the original contributor of this driver and will
closely collaborate with them going forward.

Regards,
Jeroen de Borst
Tech Lead for guest drivers with Google Cloud

On Tue, Nov 15, 2022 at 12:54 PM Jordan Kimbrough <jrkim@google.com> wrote:

> I've also registered
>
> On Tue, Nov 15, 2022 at 12:04 PM Rushil Gupta <rushilg@google.com> wrote:
>
>> Done. Thanks Junfeng!
>>
>>
>>
>> On Tue, Nov 15, 2022 at 1:22 AM Guo, Junfeng <junfeng.guo@intel.com>
>> wrote:
>> >
>> >
>> >
>> > > -----Original Message-----
>> > > From: Thomas Monjalon <thomas@monjalon.net>
>> > > Sent: Tuesday, November 15, 2022 16:33
>> > > To: Guo, Junfeng <junfeng.guo@intel.com>
>> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
>> > > <jingjing.wu@intel.com>; ferruh.yigit@xilinx.com; Xing, Beilei
>> > > <beilei.xing@intel.com>; dev@dpdk.org; jeroendb@google.com;
>> > > jrkim@google.com; Zhang, Helin <helin.zhang@intel.com>; Rushil Gupta
>> > > <rushilg@google.com>; Jeroen de Borst <jeroendb@google.com>;
>> > > Jordan Kimbrough <jrkim@google.com>
>> > > Subject: Re: [PATCH] maintainers: update for gve
>> > >
>> > > 09/11/2022 20:37, Rushil Gupta:
>> > > > Thanks a lot Junfeng!
>> > > >
>> > > > On Tue, Nov 8, 2022 at 11:26 PM Junfeng Guo <junfeng.guo@intel.com>
>> > > wrote:
>> > > >
>> > > > > Add co-maintainers from Google team for gve (Google Virtual
>> > > Ethernet).
>> > > > >
>> > > > > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>> > > > > ---
>> > > > >  Google Virtual Ethernet
>> > > > >  M: Junfeng Guo <junfeng.guo@intel.com>
>> > > > > +M: Jeroen de Borst <jeroendb@google.com>
>> > > > > +M: Rushil Gupta <rushilg@google.com>
>> > > > > +M: Jordan Kimbrough <jrkim@google.com>
>> > >
>> > > They were not part of the patch review process in the mailing list,
>> > > why do you want them to become maintainers?
>> > > I think it would be saner to have them involved first.
>> >
>> > Yes, make sense! Thanks for reminding this!
>> >
>> > Hi @Rushil Gupta @Jeroen de Borst @Jordan Kimbrough,
>> > could you help register for dev@dpdk.org
>> > at https://www.dpdk.org/contribute/#Mailing-Lists as well as for
>> > the patchwork at http://patchwork.dpdk.org/project/dpdk/list/ first?
>> > Then you can add more info & explanation for your maintaining plan here.
>> > Thanks!
>> >
>> > >
>> >
>> >
>>
>

[-- Attachment #2: Type: text/html, Size: 5701 bytes --]

[PATCH v2] net/gve: add maintainers for GVE

[Junfeng Guo]

Add maintainers from Google for GVE.

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Signed-off-by: Jeroen de Borst <jeroendb@google.com>
Signed-off-by: Rushil Gupta <rushilg@google.com>
Signed-off-by: Joshua Washington <joshwash@google.com>
---
 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8df23e5099..08001751b0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini
 
 Google Virtual Ethernet
 M: Junfeng Guo <junfeng.guo@intel.com>
+M: Jeroen de Borst <jeroendb@google.com>
+M: Rushil Gupta <rushilg@google.com>
+M: Joshua Washington <joshwash@google.com>
 F: drivers/net/gve/
 F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
-- 
2.34.1

Re: [PATCH v2] net/gve: add maintainers for GVE

[Rushil Gupta]

acked-by: Rushil Gupta <rushilg@google.com>


On Thu, May 4, 2023 at 7:19 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
>
> Add maintainers from Google for GVE.
>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Jeroen de Borst <jeroendb@google.com>
> Signed-off-by: Rushil Gupta <rushilg@google.com>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> ---
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8df23e5099..08001751b0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini
>
>  Google Virtual Ethernet
>  M: Junfeng Guo <junfeng.guo@intel.com>
> +M: Jeroen de Borst <jeroendb@google.com>
> +M: Rushil Gupta <rushilg@google.com>
> +M: Joshua Washington <joshwash@google.com>
>  F: drivers/net/gve/
>  F: doc/guides/nics/gve.rst
>  F: doc/guides/nics/features/gve.ini
> --
> 2.34.1
>

Re: [PATCH v2] net/gve: add maintainers for GVE

[Joshua Washington]

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

acked-by: Joshua Washington <joshwash@google.com>

[-- Attachment #2: Type: text/html, Size: 118 bytes --]

Re: [PATCH v2] net/gve: add maintainers for GVE

[Jeroen de Borst]

acked-by: Jeroen de Borst <jeroendb@google.com>


On Mon, May 8, 2023 at 8:26 AM Joshua Washington <joshwash@google.com> wrote:
>
> acked-by: Joshua Washington <joshwash@google.com>

Re: [PATCH v2] net/gve: add maintainers for GVE

[Ferruh Yigit]

>> On 5/8/2023 5:49 AM, Rushil Gupta wrote:

Moved and accumulated acks down.

>> 
>>> On Thu, May 4, 2023 at 7:19 PM Junfeng Guo <junfeng.guo@intel.com> wrote:
>>>>
>>>> Add maintainers from Google for GVE.
>>>>
>>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>>>> Signed-off-by: Jeroen de Borst <jeroendb@google.com>
>>>> Signed-off-by: Rushil Gupta <rushilg@google.com>
>>>> Signed-off-by: Joshua Washington <joshwash@google.com>> 
>>>
>>> acked-by: Rushil Gupta <rushilg@google.com>
>>> 
>> 
>> acked-by: Joshua Washington <joshwash@google.com>
>>
>
> acked-by: Jeroen de Borst <jeroendb@google.com>
>

Applied to dpdk-next-net/main, thanks.