From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marc.sune@gmail.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 5BFCDBDC2
 for <dev@dpdk.org>; Tue, 16 Feb 2016 19:33:23 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id g62so165694440wme.0
 for <dev@dpdk.org>; Tue, 16 Feb 2016 10:33:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=nPlfSRNO6Av+Af40b7oPXdI+PaKRa5U+vJYFoc/riRs=;
 b=R7SnLCJo9+JIUqG0n1omH+x2Bu9JinDoha5LoXdXh2NMBi4JK9E7yvr83NhpJYQ3Rp
 C7A+HL+ep1vP+u4icRoLlSPziwNxdBbHphnet6Tj2sXoRBPg5ChIjBYDCEMkDYzzMNR8
 bzFzP6Svrfkb7J4RhUyZecztP+qhhZuUVyScSN8lZDOpkyb+N/qPgxC2FKXysTETa5Wy
 iTYvBd+Zy9Ja5dEFTP3Xs2KNVlY1rlRVjWunIOCAqy5KoW39l8rg12cy9s6PiclAmBBZ
 s2KR398BYt+xC6Z2zbZTv35cvbXD7lbD2jsdI/EdnHl++Keaw6XylmjYQp82kC3foZ6A
 tNKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-type;
 bh=nPlfSRNO6Av+Af40b7oPXdI+PaKRa5U+vJYFoc/riRs=;
 b=XlUnnrsW2khc1DsYTtOHHV+vTdSuPOP34cQviKt3gs9iv8hhWI4GJ5Q+0qmHOEzg/A
 OIimSJf4slTupP/mVTSmfy47C7J4CWfHerKHYokjIWFKUI4ZOV7cO7WSas2yI0b0S8OO
 MvzCjS1uyLixr0bfkUEmw2bXUbZ2aX8cljstS9r3if8OyBVYJOqjiOWhC+koxe1WhG/l
 mtfpDIVR8phm5YHjre40K/lfuqc9VTlIrSZRFoqtEOQ4v03EwZggICoolk2IonhP1vQD
 X3XcseLhdQYJcADUPmA1diNDFGHWvhUqg4OM6Tb3Dxbymduo+ilk0KQdmWtPlFB/kHrx
 Q2/A==
X-Gm-Message-State: AG10YOTTk/PoyPIIPkC+sFsVEhpxeEGSejT5L9bAGvn30dqbU/od1lIaNrsKzqfC6Ad2tTWvmdOusToED2rs3g==
X-Received: by 10.194.77.193 with SMTP id u1mr23800693wjw.73.1455647603187;
 Tue, 16 Feb 2016 10:33:23 -0800 (PST)
MIME-Version: 1.0
Sender: marc.sune@gmail.com
Received: by 10.27.95.202 with HTTP; Tue, 16 Feb 2016 10:33:03 -0800 (PST)
In-Reply-To: <3258026.sKzRUcIKf8@xps13>
References: <1454691969-25734-1-git-send-email-thomas.monjalon@6wind.com>
 <1455606865-22680-1-git-send-email-thomas.monjalon@6wind.com>
 <20160216162134.GA30782@sivlogin002.ir.intel.com> <3258026.sKzRUcIKf8@xps13>
From: Marc <marcdevel@gmail.com>
Date: Tue, 16 Feb 2016 19:33:03 +0100
X-Google-Sender-Auth: ulTHM_rt4K63pWHqAKIGHbgQR5Y
Message-ID: <CAExC=0R8QHOcyVHuWfgBZmE=JzEgPoxpaDtdUGci24N80Atvbg@mail.gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/3] fix C++ includes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2016 18:33:23 -0000

On 16 February 2016 at 17:26, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2016-02-16 16:21, Ferruh Yigit:
> > On Tue, Feb 16, 2016 at 08:14:22AM +0100, Thomas Monjalon wrote:
> > > When trying to build a C++ application, some errors appear from DPDK
> headers.
> > > 2 libraries are not fixed in this series:
> > > - cmdline
> > > - vhost which includes some not compliant Linux virtio headers
> >
> > Out of curiosity, how can we detect C++ compilation problems, do we have
> a C++ sample application?
> > Or how can we compile any existing application with c++, I tried
> "EXTRA_CFLAGS="-x c++" or "CC=g++" but both failed to compile.
>
> I will submit a test.
> At the moment, I use CC=g++ with this file:
>
> #ifdef RTE_LIBRTE_EAL
> #include <rte_alarm.h>
> #include <rte_atomic.h>
> #include <rte_branch_prediction.h>
> #include <rte_byteorder.h>
> #include <rte_common.h>
> #include <rte_cpuflags.h>
> #include <rte_cycles.h>
> #include <rte_debug.h>
> #include <rte_devargs.h>
> #include <rte_dev.h>
> #include <rte_dev_info.h>
> #include <rte_eal.h>
> #include <rte_eal_memconfig.h>
> #include <rte_errno.h>
> #include <rte_hexdump.h>
> #include <rte_interrupts.h>
> #include <rte_keepalive.h>
> #include <rte_launch.h>
> #include <rte_lcore.h>
> #include <rte_log.h>
> #include <rte_malloc.h>
> #include <rte_malloc_heap.h>
> #include <rte_memcpy.h>
> #include <rte_memory.h>
> #include <rte_memzone.h>
> #include <rte_pci.h>
> #include <rte_pci_dev_feature_defs.h>
> #include <rte_pci_dev_features.h>
> #include <rte_pci_dev_ids.h>
> #include <rte_per_lcore.h>
> #include <rte_prefetch.h>
> #include <rte_random.h>
> #ifdef RTE_ARCH_X86
> #include <rte_rtm.h>
> #endif
> #include <rte_rwlock.h>
> #include <rte_spinlock.h>
> #include <rte_string_fns.h>
> #include <rte_tailq.h>
> #include <rte_time.h>
> #include <rte_timer.h>
> #include <rte_vect.h>
> #include <rte_version.h>
> #endif
> #ifdef RTE_LIBRTE_CMDLINE
> /* TODO: C++ support
> #include <cmdline.h>
> #include <cmdline_cirbuf.h>
> #include <cmdline_parse_etheraddr.h>
> */
> #include <cmdline_parse.h>
> #include <cmdline_parse_ipaddr.h>
> #include <cmdline_parse_num.h>
> #include <cmdline_parse_portlist.h>
> #include <cmdline_parse_string.h>
> #include <cmdline_rdline.h>
> #include <cmdline_socket.h>
> #include <cmdline_vt100.h>
> #endif
> #ifdef RTE_LIBRTE_ACL
> #include <rte_acl.h>
> #endif
> #ifdef RTE_LIBRTE_SCHED
> #include <rte_approx.h>
> #include <rte_bitmap.h>
> #include <rte_red.h>
> #include <rte_sched_common.h>
> #include <rte_sched.h>
> #endif
> #ifdef RTE_LIBRTE_NET
> #include <rte_arp.h>
> #include <rte_icmp.h>
> #include <rte_ip.h>
> #include <rte_sctp.h>
> #include <rte_tcp.h>
> #include <rte_udp.h>
> #endif
> #ifdef RTE_LIBRTE_CFGFILE
> #include <rte_cfgfile.h>
> #endif
> #include <rte_compat.h>
> #include <rte_config.h>
> #ifdef RTE_LIBRTE_CRYPTODEV
> #include <rte_crypto.h>
> #include <rte_cryptodev.h>
> #include <rte_cryptodev_pmd.h>
> #endif
> #ifdef RTE_LIBRTE_DISTRIBUTOR
> #include <rte_distributor.h>
> #endif
> #ifdef RTE_LIBRTE_PMD_AF_PACKET
> #include <rte_eth_af_packet.h>
> #endif
> #ifdef RTE_LIBRTE_PMD_BOND
> #include <rte_eth_bond.h>
> #include <rte_eth_bond_8023ad.h>
> #endif
> #ifdef RTE_LIBRTE_ETHER
> #include <rte_eth_ctrl.h>
> #include <rte_ethdev.h>
> #include <rte_ether.h>
> #endif
> #ifdef RTE_LIBRTE_PMD_NULL
> #include <rte_eth_null.h>
> #endif
> #ifdef RTE_LIBRTE_PMD_RING
> #include <rte_eth_ring.h>
> #endif
> #ifdef RTE_LIBRTE_HASH
> #include <rte_fbk_hash.h>
> #include <rte_hash_crc.h>
> #include <rte_hash.h>
> #include <rte_jhash.h>
> #include <rte_thash.h>
> #endif
> #ifdef RTE_LIBRTE_IP_FRAG
> #include <rte_ip_frag.h>
> #endif
> #ifdef RTE_LIBRTE_JOBSTATS
> #include <rte_jobstats.h>
> #endif
> #ifdef RTE_LIBRTE_KNI
> #include <rte_kni.h>
> #endif
> #ifdef RTE_LIBRTE_KVARGS
> #include <rte_kvargs.h>
> #endif
> #ifdef RTE_LIBRTE_LPM
> #include <rte_lpm.h>
> #include <rte_lpm6.h>
> #endif
> #ifdef RTE_LIBRTE_MBUF
> #include <rte_mbuf.h>
> #endif
> #ifdef RTE_LIBRTE_MBUF_OFFLOAD
> #include <rte_mbuf_offload.h>
> #endif
> #ifdef RTE_LIBRTE_MEMPOOL
> #include <rte_mempool.h>
> #endif
> #ifdef RTE_LIBRTE_METER
> #include <rte_meter.h>
> #endif
> #ifdef RTE_LIBRTE_PIPELINE
> #include <rte_pipeline.h>
> #endif
> #ifdef RTE_LIBRTE_PORT
> #include <rte_port.h>
> #include <rte_port_ethdev.h>
> #include <rte_port_frag.h>
> #include <rte_port_ras.h>
> #include <rte_port_ring.h>
> #include <rte_port_sched.h>
> #include <rte_port_source_sink.h>
> #endif
> #ifdef RTE_LIBRTE_POWER
> #include <rte_power.h>
> #endif
> #ifdef RTE_LIBRTE_REORDER
> #include <rte_reorder.h>
> #endif
> #ifdef RTE_LIBRTE_RING
> #include <rte_ring.h>
> #endif
> #ifdef RTE_LIBRTE_TABLE
> #include <rte_lru.h>
> #include <rte_table.h>
> #include <rte_table_acl.h>
> #include <rte_table_array.h>
> #include <rte_table_hash.h>
> #include <rte_table_lpm.h>
> #include <rte_table_lpm_ipv6.h>
> #include <rte_table_stub.h>
> #endif
> #ifdef RTE_LIBRTE_VHOST
> /* TODO: fix vhost header for C++
> #include <rte_virtio_net.h>
> */
> #endif
>
> int
> main(int argc, char **argv)
> {
>         RTE_LOG(NOTICE, USER1, "function %s\n", __func__);
>         return 0;
> }
>
>
I don't know what you have in mind for the test, but with this file you can
only detect things like using reserved keywords of C++ in DPDK headers and
things like that. It will not detect linking issues (fundamentally missing
extern "C" in function declarations), which happen from time to time,
specially with new headers.

We would need to compile a .cc/.cpp file including all these headers and
link against all the functions on those headers, similarly to what autoconf
does to test libs. I could help on that for 2.4.

Marc