From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by dpdk.org (Postfix) with ESMTP id E2A62530F for ; Mon, 14 Mar 2016 23:17:08 +0100 (CET) Received: by mail-lb0-f176.google.com with SMTP id bc4so258259382lbc.2 for ; Mon, 14 Mar 2016 15:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ZVNQM8/59sT6kjHX6fGqucNfxp1RWj/WBXQ3sGHTdYA=; b=NlSVjbw+LTFweenEMWBuf+d8nfZcYoXXZHmYY5D4/tSTa0B2uAbuQEREp472AovsVM zowiLrTtKAYGJQIlxgzzLaPssS2H8yj67xeu3sf5kF72K2jCpxCZ7t+gBs+11OkNQy5z 2GHu070SNFgkkcYrBW0oODZzr9Agi/YBn+1zVSksSNUUAoFKN7fw8t2NLCTxjqAdG11/ a7fBUZsNGoDdROQ50+Ymq528NRAnV5gh2clvo4x6LJmlx+s6heYrO3CZoFZBKf15me4a 9lTKouH1KAwheJkmAVc91tytqb2r8T9BGpLOPQjToZuGJvFM2xxbMvTHjBXQUHoPRpCa cgoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ZVNQM8/59sT6kjHX6fGqucNfxp1RWj/WBXQ3sGHTdYA=; b=maLLYLn11wQ4fszyDOj+0jarXTBbAJ9266WYAbCNNm49bQrcCZYwS2vAUhtTw2bRxU zr+va+3d60uy7QiZjeBEDCQYiW1GyT920+6a4FpdUA6eFjmIZ0ZjKnXOc8BJFJhz11g8 bB/VGXHGup+3TwQHOQQuPaCHLlu7Moi7b+brxPCk7MRkItyyVvc7iZmiqZpDp3nZ9Tm4 oCp+vnO479oNRi+0lVsUMEz8N3OvJIT8SabMPtAYVt6DAIePfTVMiryASa99ZlskkgbA hi0NJVRVS+kXBgDN7oJFjmSdt/feBcVNkhHoaEs8lLjHq2XL53aBVoyHh/DT9/r5MPT9 07PA== X-Gm-Message-State: AD7BkJJTk/+15O+Ch3BoXn5hkTgufcfgxqPaXi8qxzQAZnC6g8Mv7ztO+eXgvkkF9ag0SEZsxlj5VW0I9FHFuA== X-Received: by 10.112.131.40 with SMTP id oj8mr8548406lbb.98.1457993828601; Mon, 14 Mar 2016 15:17:08 -0700 (PDT) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.112.155.196 with HTTP; Mon, 14 Mar 2016 15:16:48 -0700 (PDT) In-Reply-To: <1894237.OM5rSysoGp@xps13> References: <1456961677-1116-1-git-send-email-marcdevel@gmail.com> <1894237.OM5rSysoGp@xps13> From: Marc Date: Mon, 14 Mar 2016 23:16:48 +0100 X-Google-Sender-Auth: Uj1zQqNFQgt6y5CoJ_1J9FJmkHk Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix RTE_PMD_DEBUG_TRACE redefinition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 22:17:09 -0000 On 10 March 2016 at 19:23, Thomas Monjalon wrote: > 2016-03-03 00:34, Marc Sune: > > RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined > > in rte_cryptodev_pmd.h which produced MACRO redefinition warnings > > when including both rte_cryptodev_pmd.h and rte_ethdev.h. > > > > This commit moves MACRO definition to rte_cryptodev.c to prevent > > this warning. > > It is not the right fix. > This MACRO is only used in that .c file, so it actually makes sense not to be defined in the header file. > > This macro should probably be renamed with a crypto prefix or defined > only once (same thing for ethdev). > The function rte_pmd_debug_trace() and the macros > RTE_PROC_PRIMARY_OR_ERR_RET, > RTE_PROC_PRIMARY_OR_RET, > RTE_FUNC_PTR_OR_ERR_RET, > RTE_FUNC_PTR_OR_RET > should not be in lib/librte_eal/common/include/rte_dev.h. > The macros call RTE_PMD_DEBUG_TRACE which is defined elsewhere. > The rte_log.h is probably a better place. > But why these macros have no PMD prefix? > While I agree, this patch is only trying to solve the compilation error, which I think it is a step forward from what we have now. I am working on C++ linking automated test and I could not include both files in the test. Marc