From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id C169537B4 for ; Mon, 28 Mar 2016 21:12:03 +0200 (CEST) Received: by mail-lf0-f66.google.com with SMTP id c62so9333595lfc.2 for ; Mon, 28 Mar 2016 12:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=12K4M0YR6wNP+dIawwdTnYac51bLPAxAO+wxU/dPDDE=; b=Pe66D468BvIW9cc3DMQjHtVdNw1twfNtei6tp0ZYUxRnA0H89QdkfVPoG6MBg2FQe1 MSZHhRH3D2pr6HEIq9EBbVfd3ZLuh+l8H/w+hme3xs1utTYPoH0RP2vN29r+2ZUCnvOw c+GpOGE2x6szzxvDGqBeTCBrowpf3/1JG9ba8y/lCG3fd4MwaD3mh9zUU76znx3vReK4 o2R6XXSN/facI4fmeP4ysEj+F2mcznFjYW3zJhcrRSqcRjq2iLXAM5eanZ0QmeztaeWE 9bK6x5jfF4ra19OWwudPcKr4HyrhN58slhKyjatZsdlAQ5KjtuDUSadL7GHh0ohNC2s0 rEiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=12K4M0YR6wNP+dIawwdTnYac51bLPAxAO+wxU/dPDDE=; b=YOpGIq2pjzXkMuPj0qRRLuxLSEWyAfKd7qtWMZL0g7+Ske2tMWBSK5Y7+Nfdaf1Esn ArY8xnABeWjnN0piq6fZPDcPVgyJ7Q8oorP91WlYbbR9C+sWbGELpAtZHs2ZyzKpW8b9 /8uvZ8k1A240VMgBtfggjDkqwQ5UlTehAT/1WmmQMG2N5ASwMizIbGm2I6qFQ5U9WR0f uhtqx0GUaVyN/JpASq3gL49ewkKpq3NhEVhk4wo6qiE3v/wlE8K70eEDNsikMTYdMZu3 nqN9ir+ng87+RwuEPxqHnh0QLy4zMQ7FYRqh1L31hljzAcORb8i+kZPqAKJi/K2P3ntV y3vQ== X-Gm-Message-State: AD7BkJJEcjRAGIen3li1KtLT/cMhVysJEHv2MJF64INxlGMA5j9TapSFqOhfjMq+4dW1VMP7ZdkhhgJitMyzNA== X-Received: by 10.25.25.81 with SMTP id 78mr10745243lfz.145.1459192323372; Mon, 28 Mar 2016 12:12:03 -0700 (PDT) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.25.168.201 with HTTP; Mon, 28 Mar 2016 12:11:43 -0700 (PDT) In-Reply-To: <3378985.okHjTtIZOy@xps13> References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <10133718.H4CGZOGkuk@xps13> <3378985.okHjTtIZOy@xps13> From: Marc Date: Mon, 28 Mar 2016 21:11:43 +0200 X-Google-Sender-Auth: FC9i0D1ZmYZiwVW3ZPD2Hq_L-R4 Message-ID: To: Thomas Monjalon Cc: "Zhang, Helin" , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2016 19:12:04 -0000 On 28 March 2016 at 15:42, Thomas Monjalon wrote: > Hi Marc, > > 2016-03-27 21:39, Marc: > > On 27 March 2016 at 11:53, Thomas Monjalon > > wrote: > > > 2016-03-26 11:24, Marc: > > > > On 26 March 2016 at 09:08, Thomas Monjalon < > thomas.monjalon@6wind.com> > > > > wrote: > > > > > 2016-03-25 22:30, Marc: > > > > > > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and > > > > > ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work: > [...] > > > > > > I think having autoneg == 0 is better. Do you agree Thomas? > > > > > > > > > > No I do not agree, because this flag is now used also for > > > > > rte_eth_link.link_autoneg. > > > > > So it is more logic to set it to 1. > > > > > > > > Having to explicitly specify ETH_LINK_SPEED_AUTONEG in link_speeds > during > > > > port configuration for achieving auto-negociation, which is what 98% > of > > > > applications will use, seems anti-natural to me and breaks existing > > > > applications. > > > > > > Yes, you're right. We have to avoid apps modifications. > > > By keeping autoneg the default behaviour (value 0), we avoid issues. > > > > > > > The only benefit of your approach is not to have another macro > #define > > > > ETH_LINK_AUTONEG 1, which is marginal IMHO. > > > > > > Yes, you're right. > > > I suggest adding 2 macros for rte_eth_link.link_autoneg: > > > #define ETH_LINK_FIXED 0 /**< No autonegotiation. */ > > > #define ETH_LINK_AUTONEG 1 /**< Autonegotiated. */ > > > > > > and keep these ones to use with rte_eth_conf.link_speeds and > > > rte_eth_dev_info.speed_capa: > > > #define ETH_LINK_SPEED_AUTONEG (0 << 0) /**< Autonegotiate (all > speeds) */ > > > #define ETH_LINK_SPEED_FIXED (1 << 0) /**< Disable autoneg (fixed > speed) */ > > > > > > Opinions? > > > > Agree on all of them. I can add them in the (hopefully) final v14, once > all > > or main drivers have been tested. > > It would be better to make the v14 as soon as possible to let others test > the latest revision. > Thanks > Adding these MACROs (ETH_LINK_FIXED, ETH_LINK_AUTONEG) are the only changes to be done for v14 so far. The rest were there already (v13). There is no point on doing this re-spin now, because these MACROs are anyway not used by applications yet (autoneg flag in rte_link is an addition to this patch set). So I would go for testing drivers on this v13 and collect any changes, eventually, for v14. marc