From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id 18D02FA5F for ; Mon, 19 Dec 2016 17:35:30 +0100 (CET) Received: by mail-qk0-f195.google.com with SMTP id h201so56827qke.3 for ; Mon, 19 Dec 2016 08:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IsNUA5okJbngygt+yPSyYzGpg5eMXqTrDMmnzIOKZ8M=; b=b5wr2s+S0/Mt230hGcqHRw3QAJyfkXLpwLlPoyQSJOWhid9TivRP9a2mrdCedzWn5L g7jwUQ3+g/Q6qLB/DX6CGiagTsK4I1U5S2Gh0MGvx+VIkzhPdIhfK772oMoNLnCoMMUr 1LmDMK9J5bMlLRoz6lWGdf2d8qgwgzTQvMKYQk6XeWUNBldYKW/P6QJTxEHNk1vYtT1h yEqW5R6LtcmKzrIEcNq3MCfJaamT5QpbiUCRGjdGLkKxsC6mB1dX4CNWn1oTCtpq/VpO zsqjZEGyI3R7qcuAt+diOD/bMBhX8AUqFDfj6b5jlFLpl5OMGdWjgu8acGNrQhhSCvx/ Zntg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IsNUA5okJbngygt+yPSyYzGpg5eMXqTrDMmnzIOKZ8M=; b=l99v5Ryb921DEinmezkATkt+gHPiPilB3D7sYy5HQP7hcxmuUtuTz4QFymCksqF11l uVi8FKOWrpZNnhKiWFYdv5RPX1HSVl+I3pciIqqTt5YbJIncjmJgN6K8X9HBhWpGkrI/ qbIfkpg8DrAaNrHu0owAVUdz44PHp0fpDwWzG4YgqOpsa2bApIkBTTuqFOx9IVgMPsBy Cj79ajtDihI6wzLJvY378ar70k4a+VYadv64R9QLwZS/b1Y/GhSzFscLJoSFaEDTG/Kc MSwXBHe8OaeZ+VWAg24KIL/TKua64iMVSS2FU6nYb+6VGNQ4lLHLuE/iFxe2AusjrOO7 QuHw== X-Gm-Message-State: AIkVDXLX3ShWsnNojoPxY13lgjXUxFIGVGVP8d/sjL6JGPoop4bNcLKF96+iymTED0gJ3h9jaCrmCjziNCtKhw== X-Received: by 10.55.185.133 with SMTP id j127mr310062qkf.39.1482165329508; Mon, 19 Dec 2016 08:35:29 -0800 (PST) MIME-Version: 1.0 Sender: marc.sune@gmail.com Received: by 10.12.152.1 with HTTP; Mon, 19 Dec 2016 08:35:09 -0800 (PST) In-Reply-To: References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com> From: Marc Date: Mon, 19 Dec 2016 17:35:09 +0100 X-Google-Sender-Auth: iKvPHt0vMCF2U0V3Kakz2ea7JGE Message-ID: To: Alejandro Lucero Cc: Ferruh Yigit , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 16:35:30 -0000 On 19 December 2016 at 17:18, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > On Mon, Dec 19, 2016 at 3:05 PM, Ferruh Yigit > wrote: > > > On 12/19/2016 3:02 PM, Alejandro Lucero wrote: > > > > > > > > > On Mon, Dec 19, 2016 at 2:36 PM, Ferruh Yigit > > > wrote: > > > > > > Hi Alejandro, > > > > > > > > > Hi, > > > > > > > > > On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > > > > NFP supports more speeds than just 40 and 100GB, which were > > > > what was advertised before. > > > > > > > > Signed-off-by: Alejandro Lucero > > > > > > --- > > > > drivers/net/nfp/nfp_net.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/nfp/nfp_net.c > b/drivers/net/nfp/nfp_net.c > > > > index 27afbfd..77015c4 100644 > > > > --- a/drivers/net/nfp/nfp_net.c > > > > +++ b/drivers/net/nfp/nfp_net.c > > > > @@ -1077,7 +1077,9 @@ static void nfp_net_read_mac(struct > > nfp_net_hw *hw) > > > > dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; > > > > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > > > > > > > > - dev_info->speed_capa = ETH_LINK_SPEED_40G | > > ETH_LINK_SPEED_100G; > > > > + dev_info->speed_capa = ETH_SPEED_NUM_1G | > ETH_LINK_SPEED_10G > > | > > > > + ETH_SPEED_NUM_25G | > ETH_SPEED_NUM_40G > > | > > > > + ETH_SPEED_NUM_50G | > > ETH_LINK_SPEED_100G; > > > > > > Does all devices driver by this driver supports all these speeds? > > > > > > I am aware of at least one exception to this, from previous patch > > [1], > > > should we take that into account? > > > > > > > > > So we have different NFP devices and different firmwares. > > > NFP by design support all those speeds, but the PMD relies on the > > > firmware for being able to know which is the current configured speed > > > after link negotiation. PMD development was done with a specific > > > firmware, and I was told to just report such speed by default. Last > > > firmware versions give that speed info, but old firmware versions do > not. > > > > > > So, all devices support such a speed range, indeed PMD works with any > of > > > them, but reported speed is always 40G with old firmware. This is a > > > firmware limitation but we have to support old and new firmware. > > > > But this information to the application will be wrong for some (old) FW. > > What do you think checking the FW version here and report capability > > based on what FW supports? > > > > > The driver advertises the right speed range supported. The problem is with > the report about the current link speed configured. > Maybe, is the right thing to do here to not report the current link speed > because the driver really does not know about it? > > If you agree with this, I'm afraid the just accepted patch about the link > report needs to be modified. > Alejandro, If negociated link state has to be changed, then struct rte_eth_dev_data dev_link field is where to do it. As Ferruh was saying, dev_info->speed_capa contains the speed capabilties of the particular NIC in use, not the driver (detecting firmware version would be the best here). marc > > > > > > > > > > > > > > > Also other than that exception, can you please confirm all other > > devices > > > support all above speeds? > > > > > > [1] > > > + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || > > > + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && > > > + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) > > > + link.link_speed = ETH_SPEED_NUM_40G; > > > > > > > > > > } > > > > > > > > static const uint32_t * > > > > > > > > > > > > > > >