From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CD1AA04DB; Tue, 17 Nov 2020 09:52:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 030EB592C; Tue, 17 Nov 2020 09:52:36 +0100 (CET) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by dpdk.org (Postfix) with ESMTP id 63859F90 for ; Tue, 17 Nov 2020 09:52:34 +0100 (CET) Received: by mail-qt1-f193.google.com with SMTP id g17so15091474qts.5 for ; Tue, 17 Nov 2020 00:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QZZ5ST/gNfYLwNolP1F8WAxAWo8i3pnpFnuhxa2NBNs=; b=PBvXD7Gi3PrhuTOowma0XCX1RpdhpvLo34/T5ebecXs35A44jTTMktWTFlLVmpo5GQ NnrcxNj4PwvT+OuEA2b4lcy9vkpZMd63eLgSWbk6BVy8n36xtwAKR34jBjci9eEleVE7 JFhXm5R9C/WC6ZOCMVZmwCoRw6SGG1aROrVOXS3Fj73TfoFajPbDZOrR7t7+VGeiot0f 4LbcPVOYbwDmLSsBCXgfRWLKnRIzlMoX2QlyFtAioqy25NzeIYoQilIfOQYmbzH8pPIt qIPGz78nwW6ob6QZlnFV0GbGIqX9HXRWTSB7Qg9o8txKtNHW7sBAnLu+Ommwjnzpg8Ez wGBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QZZ5ST/gNfYLwNolP1F8WAxAWo8i3pnpFnuhxa2NBNs=; b=Cm4KiU9RmlXve2tFvHVToDPTUWBXJb9rveubVJJHSJdISTowXzWb4gvVQqCDXJww+y RBmhwbYpRaH3A+EldtGFwJjn7/zIKL2JZl9VJ+p71Cz8uw4TLzLL4m4P39r/xLqTc7EB Trd6NI6KaIK8n4z38EDp0JVascjP5/9UYY70hTZBGouM4db01v6dZJk+jltjXEyYc0c+ RembPzqM0C2UHdpGFh9pg1hTl5r2x0HyKY+cb8M4HFrZZoo6KN2ENrSU609WxMNBIHo2 HGIpnMkfQ6PTHOwlvcvGm3ZLvOffKvYHAIIYoRElojBZwmD6124eOCropNyeMDJQR1T4 /okA== X-Gm-Message-State: AOAM5333kU1fT+3CeZx5l0V5Mjs60WtYJaB100vF6ObrqMqNa9ZITDvN hous0OOXn02F8OIHvp4XhWXoWcQgpshubBXAIr3W9A== X-Google-Smtp-Source: ABdhPJwUgxHO1X7o+C9bjfiZQ/dvp8NokMvZ9gvGe/GTJ/dV6A2L7jwrlxPaAznboQP1lKfTVM83lvtwcDNHnBiwq1I= X-Received: by 2002:ac8:23fb:: with SMTP id r56mr17588537qtr.371.1605603152781; Tue, 17 Nov 2020 00:52:32 -0800 (PST) MIME-Version: 1.0 References: <20201116170258.18583-1-maxime.leroy@6wind.com> <20201116170258.18583-3-maxime.leroy@6wind.com> In-Reply-To: From: Maxime Leroy Date: Tue, 17 Nov 2020 09:52:21 +0100 Message-ID: To: Slava Ovsiienko Cc: Matan Azrad , Shahaf Shuler , Olivier Matz , "dev@dpdk.org" , Didier Pallard Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Slava, On Mon, Nov 16, 2020 at 9:03 PM Slava Ovsiienko wrote: > > Hi, Maxime > > It seems there are some typos (see below). > Beside these ones - ACKed. > > > -----Original Message----- > > From: Maxime Leroy > > Sent: Monday, November 16, 2020 19:03 > > To: Matan Azrad ; Shahaf Shuler ; > > Slava Ovsiienko ; Olivier Matz > > > > Cc: dev@dpdk.org; Didier Pallard > > Subject: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value > > > > From: Didier Pallard > > > > Three bugs in rx_queue_count function: > > - One entry may contain several segments, so 'used' must be multiplied > > by number of segments per entry to properly reflect the queue usage. > > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt > > mode. The range returned by rx_queue_count should be the number of > > Should it be "bullet number 3" ? This bullet is for SPRQ mode. The bullet number 3 is for MPRQ mode. Not sure to understand your point. > > > entries used in queue, so it ranges from 0 to max number of entries > > in queue, not this number minus one. > > WARNING:TYPO_SPELLING: 'acount' may be misspelled - perhaps 'account'? > Should it be - "to take into account?" > Should it be "MPRQ" ? I will fix it in V4. Thanks for the review. > > > - For MQRT mode, we need to take acount of the number of strd. > > > > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > > Signed-off-by: Didier Pallard > > Signed-off-by: Maxime Leroy > Acked-by: Viacheslav Ovsiienko >