DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Is Flow Director supported on the x540 chipset?
@ 2014-01-16  6:47 Fulvio Risso
  2014-01-17 11:24 ` Maxime Leroy
  0 siblings, 1 reply; 10+ messages in thread
From: Fulvio Risso @ 2014-01-16  6:47 UTC (permalink / raw)
  To: dev

Dear all,

by digging into the DPDK code it seems to me that FDIR is not supported 
on the x540 chipset, while it is supported on 82599.

Another message seems to mention the same problem here:

   http://dpdk.org/ml/archives/dev/2013-November/000806.html

Is there any plan to support FDIR to the x540 chipset?

	fulvio

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-01-16  6:47 [dpdk-dev] Is Flow Director supported on the x540 chipset? Fulvio Risso
@ 2014-01-17 11:24 ` Maxime Leroy
  2014-02-06 16:47   ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Maxime Leroy @ 2014-01-17 11:24 UTC (permalink / raw)
  To: Fulvio Risso; +Cc: dev

Hi Fulvio,

I have been checked few information about the datasheet of the X540 card.
The X540 card is a derivative of the 82599. It's very similar to the 82599 card.

The both cards use the same hardware registers for the flow director.
Thus, the current code of the dpdk for the flow director should work
with X540 card too.

I think you only need to change few lines in lib/librte_pmd_ixgbe/ixgbe_fdir.c:

  - if (hw->mac.type != ixgbe_mac_82599EB)
  + if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type != ixgbe_mac_X540)

Let me know if you can test it and please provide a patch if it works.

Thanks. Regards,

Maxime

On Thu, Jan 16, 2014 at 7:47 AM, Fulvio Risso <fulvio.risso@polito.it> wrote:
> Dear all,
>
> by digging into the DPDK code it seems to me that FDIR is not supported on
> the x540 chipset, while it is supported on 82599.
>
> Another message seems to mention the same problem here:
>
>   http://dpdk.org/ml/archives/dev/2013-November/000806.html
>
> Is there any plan to support FDIR to the x540 chipset?
>
>         fulvio

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-01-17 11:24 ` Maxime Leroy
@ 2014-02-06 16:47   ` Thomas Monjalon
  2014-02-13  9:44     ` Mauro Annarumma
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2014-02-06 16:47 UTC (permalink / raw)
  To: Fulvio Risso; +Cc: dev

Hi Fulvio,

17/01/2014 12:24, Maxime Leroy:
> On Thu, Jan 16, 2014, Fulvio Risso <fulvio.risso@polito.it> wrote:
> > by digging into the DPDK code it seems to me that FDIR is not supported
> > on the x540 chipset, while it is supported on 82599.
[...]
> > Is there any plan to support FDIR to the x540 chipset?
> 
[...]
> I think you only need to change few lines in
> lib/librte_pmd_ixgbe/ixgbe_fdir.c:
> 
>   - if (hw->mac.type != ixgbe_mac_82599EB)
>   + if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type !=
> ixgbe_mac_X540)
> 
> Let me know if you can test it and please provide a patch if it works.

Have you tried to patch and test flow director for X540 ?

thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-02-06 16:47   ` Thomas Monjalon
@ 2014-02-13  9:44     ` Mauro Annarumma
  2014-02-13 10:28       ` Richardson, Bruce
  0 siblings, 1 reply; 10+ messages in thread
From: Mauro Annarumma @ 2014-02-13  9:44 UTC (permalink / raw)
  To: dev

Hi,
I'm trying to use Flow Director. Initially I used a X540 chipset and I was not able to make it work; I thought it was a compatibility problem with the controller. Maxime suggested to change some lines in the ixgbe_fdir.c file, I changed these lines but it
      did not give the expected results; 
   At this point I was sure that the problem was the incompatibility between the DPDK and the X540 chipset therefore I retrived a NIC whit a 82599 chipset and I repeated my attempts, unfortunately I got the some problems.
   
In order to be more clear I explain my attempts:
I try  to run the test-pmd app with the command-line option
      "--pkt-filter-mode=perfect", the app doesn't start (the rte_eth_dev_start
      function return an error) otherwise without the --pkt-filter-mode command-line option the application run
      normally. 

This is the command line I use to start the program:

frog@frog:~/dpdk-1.5.2r1/app/test-pmd$
 sudo ./testpmd -c 0x0f -n 2 -m 512 -- -i --portmask=0x3 --nb-cores=2 
--pkt-filter-mode=perfect --rxq=2 --txq=2


and the relative output:

...
Interactive-mode selected
Configuring Port 0 (socket -1)
Fail to start port 0 (ret=-5)*
Configuring Port 1 (socket -1)
Fail to start port 1 (ret=-5)*
Please stop the ports first
Done
testpmd> 

*ret=-5 is the result of the rte_eth_dev_start function

I guess someone was able to use FDIR, at least in the testpmd application. What am I doing wrong?
Best regards

> From: thomas.monjalon@6wind.com
> To: fulvio.risso@polito.it
> Date: Thu, 6 Feb 2014 17:47:21 +0100
> CC: dev@dpdk.org
> Subject: Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> 
> Hi Fulvio,
> 
> 17/01/2014 12:24, Maxime Leroy:
> > On Thu, Jan 16, 2014, Fulvio Risso <fulvio.risso@polito.it> wrote:
> > > by digging into the DPDK code it seems to me that FDIR is not supported
> > > on the x540 chipset, while it is supported on 82599.
> [...]
> > > Is there any plan to support FDIR to the x540 chipset?
> > 
> [...]
> > I think you only need to change few lines in
> > lib/librte_pmd_ixgbe/ixgbe_fdir.c:
> > 
> >   - if (hw->mac.type != ixgbe_mac_82599EB)
> >   + if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type !=
> > ixgbe_mac_X540)
> > 
> > Let me know if you can test it and please provide a patch if it works.
> 
> Have you tried to patch and test flow director for X540 ?
> 
> thanks
> -- 
> Thomas
 		 	   		  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-02-13  9:44     ` Mauro Annarumma
@ 2014-02-13 10:28       ` Richardson, Bruce
  2014-02-14 10:28         ` Mauro Annarumma
  0 siblings, 1 reply; 10+ messages in thread
From: Richardson, Bruce @ 2014-02-13 10:28 UTC (permalink / raw)
  To: Mauro Annarumma, dev

Hi,

can you please give a few more details about your setup? What version of the Intel DPDK are you using? I tried using the command you give below on my system with 82599-based NICs and testpmd starts up without any issues.

Here's the (clipped for brevity) output that I get:

$ sudo ./testpmd -c 0x0f -n 2 -m 512 -- -i --portmask=0x3 --nb-cores=2 --pkt-filter-mode=perfect --rxq=2 --txq=2
EAL: No free hugepages reported in hugepages-2048kB
EAL: Detected lcore 0 as core 0 on socket 0
EAL: Detected lcore 1 as core 1 on socket 0
... <snip>...
Interactive-mode selected
previous number of forwarding ports 4 - changed to number of configured ports 2
Configuring Port 0 (socket 1)
Configuring Port 1 (socket 1)
Configuring Port 2 (socket 1)
Configuring Port 3 (socket 1)
Checking link statuses...
Port 0 Link Up - speed 10000 Mbps - full-duplex
Port 1 Link Up - speed 10000 Mbps - full-duplex
Port 2 Link Up - speed 10000 Mbps - full-duplex
Port 3 Link Up - speed 10000 Mbps - full-duplex
Done
testpmd>


Perhaps you could also try turning on some of the IXGBE debug options in your compile time config e.g. defconfig_x86_64-default-linuxapp-gcc. Setting "CONFIG_RTE_LIBRTE_IXGBE_DEBUG_INIT" and "CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER" to "y" might provide some useful output.

Regards,
/Bruce

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauro
> Annarumma
> Sent: Thursday, February 13, 2014 9:45 AM
> To: dev@dpdk.org
> Subject: Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> 
> Hi,
> I'm trying to use Flow Director. Initially I used a X540 chipset and I was not
> able to make it work; I thought it was a compatibility problem with the
> controller. Maxime suggested to change some lines in the ixgbe_fdir.c file, I
> changed these lines but it
>       did not give the expected results;
>    At this point I was sure that the problem was the incompatibility between
> the DPDK and the X540 chipset therefore I retrived a NIC whit a 82599
> chipset and I repeated my attempts, unfortunately I got the some
> problems.
> 
> In order to be more clear I explain my attempts:
> I try  to run the test-pmd app with the command-line option
>       "--pkt-filter-mode=perfect", the app doesn't start (the
> rte_eth_dev_start
>       function return an error) otherwise without the --pkt-filter-mode
> command-line option the application run
>       normally.
> 
> This is the command line I use to start the program:
> 
> frog@frog:~/dpdk-1.5.2r1/app/test-pmd$
>  sudo ./testpmd -c 0x0f -n 2 -m 512 -- -i --portmask=0x3 --nb-cores=2 --pkt-
> filter-mode=perfect --rxq=2 --txq=2
> 
> 
> and the relative output:
> 
> ...
> Interactive-mode selected
> Configuring Port 0 (socket -1)
> Fail to start port 0 (ret=-5)*
> Configuring Port 1 (socket -1)
> Fail to start port 1 (ret=-5)*
> Please stop the ports first
> Done
> testpmd>
> 
> *ret=-5 is the result of the rte_eth_dev_start function
> 
> I guess someone was able to use FDIR, at least in the testpmd application.
> What am I doing wrong?
> Best regards
> 
> > From: thomas.monjalon@6wind.com
> > To: fulvio.risso@polito.it
> > Date: Thu, 6 Feb 2014 17:47:21 +0100
> > CC: dev@dpdk.org
> > Subject: Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> >
> > Hi Fulvio,
> >
> > 17/01/2014 12:24, Maxime Leroy:
> > > On Thu, Jan 16, 2014, Fulvio Risso <fulvio.risso@polito.it> wrote:
> > > > by digging into the DPDK code it seems to me that FDIR is not
> supported
> > > > on the x540 chipset, while it is supported on 82599.
> > [...]
> > > > Is there any plan to support FDIR to the x540 chipset?
> > >
> > [...]
> > > I think you only need to change few lines in
> > > lib/librte_pmd_ixgbe/ixgbe_fdir.c:
> > >
> > >   - if (hw->mac.type != ixgbe_mac_82599EB)
> > >   + if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type !=
> > > ixgbe_mac_X540)
> > >
> > > Let me know if you can test it and please provide a patch if it works.
> >
> > Have you tried to patch and test flow director for X540 ?
> >
> > thanks
> > --
> > Thomas
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-02-13 10:28       ` Richardson, Bruce
@ 2014-02-14 10:28         ` Mauro Annarumma
  2014-03-18 14:59           ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Mauro Annarumma @ 2014-02-14 10:28 UTC (permalink / raw)
  To: dev




Hi Bruce,
your answer was really helpful. The application didn't work due to this line 
"if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type !=ixgbe_mac_X540)". 

I changed the || whit a && and now the application (with the FDIR mode active) runs on both X540 and 82599. 
Now I'm testing if the FDIR really works properly also on the X540 ; if it works, I will provide a patch.

Best Regards, 

    Mauro

> From: bruce.richardson@intel.com
> To: mauroannarumma@hotmail.it; dev@dpdk.org
> Subject: RE: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> Date: Thu, 13 Feb 2014 10:28:37 +0000
> 
> Hi,
> 
> can you please give a few more details about your setup? What version of the Intel DPDK are you using? I tried using the command you give below on my system with 82599-based NICs and testpmd starts up without any issues.
> 
> Here's the (clipped for brevity) output that I get:
> 
> $ sudo ./testpmd -c 0x0f -n 2 -m 512 -- -i --portmask=0x3 --nb-cores=2 --pkt-filter-mode=perfect --rxq=2 --txq=2
> EAL: No free hugepages reported in hugepages-2048kB
> EAL: Detected lcore 0 as core 0 on socket 0
> EAL: Detected lcore 1 as core 1 on socket 0
> ... <snip>...
> Interactive-mode selected
> previous number of forwarding ports 4 - changed to number of configured ports 2
> Configuring Port 0 (socket 1)
> Configuring Port 1 (socket 1)
> Configuring Port 2 (socket 1)
> Configuring Port 3 (socket 1)
> Checking link statuses...
> Port 0 Link Up - speed 10000 Mbps - full-duplex
> Port 1 Link Up - speed 10000 Mbps - full-duplex
> Port 2 Link Up - speed 10000 Mbps - full-duplex
> Port 3 Link Up - speed 10000 Mbps - full-duplex
> Done
> testpmd>
> 
> 
> Perhaps you could also try turning on some of the IXGBE debug options in your compile time config e.g. defconfig_x86_64-default-linuxapp-gcc. Setting "CONFIG_RTE_LIBRTE_IXGBE_DEBUG_INIT" and "CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER" to "y" might provide some useful output.
> 
> Regards,
> /Bruce
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauro
> > Annarumma
> > Sent: Thursday, February 13, 2014 9:45 AM
> > To: dev@dpdk.org
> > Subject: Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> > 
> > Hi,
> > I'm trying to use Flow Director. Initially I used a X540 chipset and I was not
> > able to make it work; I thought it was a compatibility problem with the
> > controller. Maxime suggested to change some lines in the ixgbe_fdir.c file, I
> > changed these lines but it
> >       did not give the expected results;
> >    At this point I was sure that the problem was the incompatibility between
> > the DPDK and the X540 chipset therefore I retrived a NIC whit a 82599
> > chipset and I repeated my attempts, unfortunately I got the some
> > problems.
> > 
> > In order to be more clear I explain my attempts:
> > I try  to run the test-pmd app with the command-line option
> >       "--pkt-filter-mode=perfect", the app doesn't start (the
> > rte_eth_dev_start
> >       function return an error) otherwise without the --pkt-filter-mode
> > command-line option the application run
> >       normally.
> > 
> > This is the command line I use to start the program:
> > 
> > frog@frog:~/dpdk-1.5.2r1/app/test-pmd$
> >  sudo ./testpmd -c 0x0f -n 2 -m 512 -- -i --portmask=0x3 --nb-cores=2 --pkt-
> > filter-mode=perfect --rxq=2 --txq=2
> > 
> > 
> > and the relative output:
> > 
> > ...
> > Interactive-mode selected
> > Configuring Port 0 (socket -1)
> > Fail to start port 0 (ret=-5)*
> > Configuring Port 1 (socket -1)
> > Fail to start port 1 (ret=-5)*
> > Please stop the ports first
> > Done
> > testpmd>
> > 
> > *ret=-5 is the result of the rte_eth_dev_start function
> > 
> > I guess someone was able to use FDIR, at least in the testpmd application.
> > What am I doing wrong?
> > Best regards
> > 
> > > From: thomas.monjalon@6wind.com
> > > To: fulvio.risso@polito.it
> > > Date: Thu, 6 Feb 2014 17:47:21 +0100
> > > CC: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
> > >
> > > Hi Fulvio,
> > >
> > > 17/01/2014 12:24, Maxime Leroy:
> > > > On Thu, Jan 16, 2014, Fulvio Risso <fulvio.risso@polito.it> wrote:
> > > > > by digging into the DPDK code it seems to me that FDIR is not
> > supported
> > > > > on the x540 chipset, while it is supported on 82599.
> > > [...]
> > > > > Is there any plan to support FDIR to the x540 chipset?
> > > >
> > > [...]
> > > > I think you only need to change few lines in
> > > > lib/librte_pmd_ixgbe/ixgbe_fdir.c:
> > > >
> > > >   - if (hw->mac.type != ixgbe_mac_82599EB)
> > > >   + if (hw->mac.type != ixgbe_mac_82599EB || hw->mac.type !=
> > > > ixgbe_mac_X540)
> > > >
> > > > Let me know if you can test it and please provide a patch if it works.
> > >
> > > Have you tried to patch and test flow director for X540 ?
> > >
> > > thanks
> > > --
> > > Thomas
> > 

 		 	   		  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] Is Flow Director supported on the x540 chipset?
  2014-02-14 10:28         ` Mauro Annarumma
@ 2014-03-18 14:59           ` Thomas Monjalon
  2014-03-24 21:35             ` [dpdk-dev] [PATCH] ixgbe: support flow director for X540 Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2014-03-18 14:59 UTC (permalink / raw)
  To: Mauro Annarumma; +Cc: dev

Hello Mauro,

14/02/2014 11:28, Mauro Annarumma :
> Now I'm testing if the FDIR really works properly also on the X540 ;
> if it works, I will provide a patch.

Have you tested FDIR on X540?

-- 
Thomas

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH] ixgbe: support flow director for X540
  2014-03-18 14:59           ` Thomas Monjalon
@ 2014-03-24 21:35             ` Thomas Monjalon
  2014-03-26  9:45               ` Maxime Leroy
  0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2014-03-24 21:35 UTC (permalink / raw)
  To: dev

From: Mauro Annarumma <mauroannarumma@hotmail.it>

Flow director in X540 uses the same registers as in 82599.
So it just has to be enabled in the 82599 implementation.

Signed-off-by: Mauro Annarumma <mauroannarumma@hotmail.it>
---
 lib/librte_pmd_ixgbe/ixgbe_fdir.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_fdir.c b/lib/librte_pmd_ixgbe/ixgbe_fdir.c
index f15151a..0d91ff9 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_fdir.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_fdir.c
@@ -182,7 +182,7 @@ ixgbe_fdir_configure(struct rte_eth_dev *dev)
 
 	PMD_INIT_FUNC_TRACE();
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = configure_fdir_flags(&dev->data->dev_conf.fdir_conf, &fdirctrl);
@@ -464,7 +464,7 @@ fdir_add_update_signature_filter(struct rte_eth_dev *dev,
 	union ixgbe_atr_input input;
 	int err;
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = fdir_filter_to_atr_input(fdir_filter, &input);
@@ -550,7 +550,7 @@ ixgbe_fdir_remove_signature_filter(struct rte_eth_dev *dev,
 
 	PMD_INIT_FUNC_TRACE();
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = fdir_filter_to_atr_input(fdir_filter, &input);
@@ -674,7 +674,7 @@ ixgbe_fdir_set_masks(struct rte_eth_dev *dev, struct rte_fdir_masks *fdir_masks)
 
 	hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = ixgbe_reinit_fdir_tables_82599(hw);
@@ -784,7 +784,7 @@ fdir_add_update_perfect_filter(struct rte_eth_dev *dev,
 	union ixgbe_atr_input input;
 	int err;
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = fdir_filter_to_atr_input(fdir_filter, &input);
@@ -836,7 +836,7 @@ ixgbe_fdir_remove_perfect_filter(struct rte_eth_dev *dev,
 
 	PMD_INIT_FUNC_TRACE();
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return -ENOSYS;
 
 	err = fdir_filter_to_atr_input(fdir_filter, &input);
@@ -859,7 +859,7 @@ ixgbe_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir *fdir)
 			IXGBE_DEV_PRIVATE_TO_FDIR_INFO(dev->data->dev_private);
 	uint32_t reg;
 
-	if (hw->mac.type != ixgbe_mac_82599EB)
+	if (hw->mac.type != ixgbe_mac_82599EB && hw->mac.type !=ixgbe_mac_X540)
 		return;
 
 	/* Get the information from registers */
-- 
1.9.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: support flow director for X540
  2014-03-24 21:35             ` [dpdk-dev] [PATCH] ixgbe: support flow director for X540 Thomas Monjalon
@ 2014-03-26  9:45               ` Maxime Leroy
  2014-03-26 10:30                 ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Maxime Leroy @ 2014-03-26  9:45 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

Thanks

On Mon, Mar 24, 2014 at 10:35 PM, Thomas Monjalon <thomas.monjalon@6wind.com
> wrote:

> From: Mauro Annarumma <mauroannarumma@hotmail.it>
>
> Flow director in X540 uses the same registers as in 82599.
> So it just has to be enabled in the 82599 implementation.
>
> Signed-off-by: Mauro Annarumma <mauroannarumma@hotmail.it>
>
> Acked-by: Maxime Leroy <maxime.leroy@6wind.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: support flow director for X540
  2014-03-26  9:45               ` Maxime Leroy
@ 2014-03-26 10:30                 ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2014-03-26 10:30 UTC (permalink / raw)
  To: Maxime Leroy, Mauro Annarumma; +Cc: dev

> > From: Mauro Annarumma <mauroannarumma@hotmail.it>
> > 
> > Flow director in X540 uses the same registers as in 82599.
> > So it just has to be enabled in the 82599 implementation.
> > 
> > Signed-off-by: Mauro Annarumma <mauroannarumma@hotmail.it>
>
> Acked-by: Maxime Leroy <maxime.leroy@6wind.com>

Applied for version 1.6.0r2.

Thank you Mauro and Maxime.

-- 
Thomas

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-03-26 10:29 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-16  6:47 [dpdk-dev] Is Flow Director supported on the x540 chipset? Fulvio Risso
2014-01-17 11:24 ` Maxime Leroy
2014-02-06 16:47   ` Thomas Monjalon
2014-02-13  9:44     ` Mauro Annarumma
2014-02-13 10:28       ` Richardson, Bruce
2014-02-14 10:28         ` Mauro Annarumma
2014-03-18 14:59           ` Thomas Monjalon
2014-03-24 21:35             ` [dpdk-dev] [PATCH] ixgbe: support flow director for X540 Thomas Monjalon
2014-03-26  9:45               ` Maxime Leroy
2014-03-26 10:30                 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).