DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Leroy <maxime.leroy@6wind.com>
To: Daniel Kan <dan@nyansa.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode
Date: Tue, 14 Jan 2014 18:42:49 +0100	[thread overview]
Message-ID: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com> (raw)
In-Reply-To: <1389640630-21003-1-git-send-email-dan@nyansa.com>

Hello,

Thanks for your patch fixing the regression introduced by my commit
(igb/ixgbe: ETH_MQ_RX_NONE should disable RSS).

I have one comment about your fix. I don't think there are any reasons
to not enable RSS with only one RX queue in testpmd.

RSS is mainly used in testpmd to spread traffic on the different rx queues.
But you can use RSS with one rx queue for debbugging purpose.
For example, you can use the rxonly forward engine of the testpmd to display
the RSS hash. (see pkt_burst_receive in app/test-pmd/rxonly.c)

An other issue about not enabling RSS with 1 queue, when you use the command
show_rss_key in the testpmd, this one will display that the RSS is enabled.
(because rss_hf != 0; see port_rss_hash_conf_show function in
app/test-pmd/config.c)

Do you agree with my analyze ?

Thanks.

-- 
Maxime Leroy

  reply	other threads:[~2014-01-14 17:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-11  2:46 [dpdk-dev] [PATCH] app/testpmd: fix RSS rx " Daniel Kan
2014-01-13 10:31 ` Thomas Monjalon
2014-01-13 11:18   ` Ananyev, Konstantin
2014-01-13 11:32     ` Thomas Monjalon
2014-01-13 19:17   ` [dpdk-dev] [PATCH v2] app/testpmd: fix RSS " Daniel Kan
2014-01-14 17:42     ` Maxime Leroy [this message]
2014-01-14 19:57       ` Daniel Kan
2014-01-14 21:34         ` Thomas Monjalon
2014-01-16  0:27       ` [dpdk-dev] [PATCH v3] Daniel Kan
2014-01-16  0:31       ` [dpdk-dev] [PATCH v3] app/testpmd: fix RSS rx by setting mq_mode Daniel Kan
2014-01-16 12:34         ` Maxime Leroy
2014-01-17 11:25           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com \
    --to=maxime.leroy@6wind.com \
    --cc=dan@nyansa.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).