From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 847FCD0B2 for ; Wed, 6 Feb 2019 14:12:37 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id w7so2854501pgp.13 for ; Wed, 06 Feb 2019 05:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b65APv6UuvtRZJc7Jas0wo2tusrYShyhQTSQjBm6+bI=; b=W3D9YQw+8AtD9sgrcUnljFOmBpKAyJEg6ADRixf731uOPlbagzO815xEcWYcgLQLdD 0fY2fCZLjzBNVimdzeycBftFdrkH3pghw5xh9PXckzL8SDD9ritCuB+/80zYL8IqS1+O fxGZjyH/sAyMdWarQM3RoMHvzW7NRlA/GOTuTZhIztqZ8X4k/E3dJr9ADHc/O+FgoEtn 26J0+ZlajYWIKMuQ0IiS9jdQLEhaA+xpwZ+LlKU7r5+xjeJFzrALcWd4ZUEqLPwLrSdA 2UAbOnLSszc6wRL3ydFEeDbwawp9XxtoPGiJXYyk1P43JADNLuoXJKAuyn3TjMr7lUgI a4XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b65APv6UuvtRZJc7Jas0wo2tusrYShyhQTSQjBm6+bI=; b=ce8lnftPxBqqBnMW+5n7md8Hzy0VVMXY64G4pHb55gj04bFX45/R6JHx8DAZzheL0X L50Kdg9O5tNtYDpGUqNroZE/yBjyoz7tjrTjkJk1fMi5rU6GZbbZyP7XBbsRgb+//kcs QIZHtoHQuS4i8bIYQ60igvScqJQ6cL82rLbQpDRF8+ZD0cSolXsIpbOlci6+cKgbiYwp QFgh3Nc15MpWH5fnVxKfd0A5JHcpVrTdjJ2vLrKAksHnRxJqpPwuYImXyhXKZfu9DzzT aOSaWx+n7D4HzZAruPskmKuq4J5JOpzDtAuuz/TGD4q4frNghszzEnZt7eFSGu3LPacs NqPQ== X-Gm-Message-State: AHQUAuYcwOX6gaeHEd/PAycHOD9JWfRMJQFC1DDyfbUahgMeFIKyAWYL Rjxo04H5ljQlaR9xEUNwNF9t3ABOlQFNfZnnRyQtgg== X-Google-Smtp-Source: AHgI3IbzaKlwHtrgzHfVSrt6cvWZ3UOsisrJ6wFYWYrToxhu59lDdf9v6nJvv9a1CT645cbYZ6GuCuD5xU1lv8BFSz0= X-Received: by 2002:a62:546:: with SMTP id 67mr10240156pff.99.1549458756513; Wed, 06 Feb 2019 05:12:36 -0800 (PST) MIME-Version: 1.0 References: <20181218012539.52921-1-ferruh.yigit@intel.com> <96c15909-f1f6-5ba9-967b-526c470b9739@intel.com> In-Reply-To: From: Igor Ryzhov Date: Wed, 6 Feb 2019 16:12:25 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , John McNamara , Marko Kovacevic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] kni: remove ethtool support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 13:12:37 -0000 Hi Ferruh, What's the plan with this patch? Best regards, Igor On Sat, Jan 5, 2019 at 7:55 PM Igor Ryzhov wrote: > Hi Ferruh, > > I answered in another thread. > > Regarding this patch =E2=80=93 I have no objections now. > > Best regards, > Igor > > On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit > wrote: > >> On 12/18/2018 9:20 AM, Ferruh Yigit wrote: >> > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: >> >> Hi Ferruh, >> >> >> >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and >> consider >> >> rebasing your patch over mine. >> > >> > Sorry about that, yes I will check it today. >> >> Hi Igor, >> >> I put some comments on your patch. >> >> As far as I can see it also has a target to remove current type of ethto= ol >> support, so this RFC should not be a concern to you. >> All ethtool support can be removed, when you have an actual solution for >> driver >> independent ethtool support only a little code needs to be added back. >> >> Thanks, >> ferruh >> >> > >> >> >> >> As we discussed with Stephen, KNI needs to supply ethtool_ops with >> >> .get_link function, to properly support link status. >> >> So we should save ethtool_ops and implement .get_link using standard >> >> ethtool_op_get_link. >> >> >> >> Best regards, >> >> Igor >> > >> > >> >>