From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [RFC] kni: remove ethtool support
Date: Sat, 5 Jan 2019 19:55:50 +0300 [thread overview]
Message-ID: <CAF+s_Fw4CXzoGH77-NAWuu4spoOEmzybOp3YiUJrfXYBzj7KYQ@mail.gmail.com> (raw)
In-Reply-To: <96c15909-f1f6-5ba9-967b-526c470b9739@intel.com>
Hi Ferruh,
I answered in another thread.
Regarding this patch – I have no objections now.
Best regards,
Igor
On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 12/18/2018 9:20 AM, Ferruh Yigit wrote:
> > On 12/18/2018 8:20 AM, Igor Ryzhov wrote:
> >> Hi Ferruh,
> >>
> >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and
> consider
> >> rebasing your patch over mine.
> >
> > Sorry about that, yes I will check it today.
>
> Hi Igor,
>
> I put some comments on your patch.
>
> As far as I can see it also has a target to remove current type of ethtool
> support, so this RFC should not be a concern to you.
> All ethtool support can be removed, when you have an actual solution for
> driver
> independent ethtool support only a little code needs to be added back.
>
> Thanks,
> ferruh
>
> >
> >>
> >> As we discussed with Stephen, KNI needs to supply ethtool_ops with
> >> .get_link function, to properly support link status.
> >> So we should save ethtool_ops and implement .get_link using standard
> >> ethtool_op_get_link.
> >>
> >> Best regards,
> >> Igor
> >
> >
>
>
next prev parent reply other threads:[~2019-01-05 16:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 1:25 Ferruh Yigit
2018-12-18 8:20 ` Igor Ryzhov
2018-12-18 9:20 ` Ferruh Yigit
2018-12-18 18:17 ` Ferruh Yigit
2019-01-05 16:55 ` Igor Ryzhov [this message]
2019-02-06 13:12 ` Igor Ryzhov
2019-02-18 12:33 ` Ferruh Yigit
2019-02-18 13:07 ` Igor Ryzhov
2019-02-18 13:18 ` Ferruh Yigit
2019-05-24 16:29 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2019-05-24 16:46 ` Stephen Hemminger
2019-05-24 16:46 ` Ferruh Yigit
2019-05-24 16:55 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-05-24 19:27 ` Neil Horman
2019-05-29 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_Fw4CXzoGH77-NAWuu4spoOEmzybOp3YiUJrfXYBzj7KYQ@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).