From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id 499501B4CF for ; Sat, 5 Jan 2019 17:56:02 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id q1so19750395pfi.5 for ; Sat, 05 Jan 2019 08:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/6jl7J5wNezUaPJvn+S8VA8SFEsimIjKrV30Hfzu+bo=; b=LJQKJVZGfWowJs56AGTQ8n/7FO5Wy7oYUypVPt6MdQ9YqwNx3vG+ZOAXQuj8JuXDxZ Ux/nIDmTRmCNFfM+8Om0Jl/jGn/w+9lrkW5zW2AksSvK/zX0tXBDp8t7fEDo4P1+1ZML NxTsve3nXAfeu8FSiFx0tIHeOM4cSJOde4kkc2irBTLgx5GZaWrcAeAS+crYQ04GQxve A2pgvTmX2Rzo6RuStJ2pdBIbvnsmb2l4A2xDLMz+yVFlfTd8hT4EupVjmEIm41oq/6hT FcexD6Zb0pgE3J2y25okO0VcHcGkE/0GcFAywZ4EfhwZWmQAtZoD2fIvJnXY6qhS+gsN tBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/6jl7J5wNezUaPJvn+S8VA8SFEsimIjKrV30Hfzu+bo=; b=CZl9PLjOducpcdaVlnxe5CT20tySfi9ND1u4wxYJitMmcxcfH9qy4EBO9rptFNDJ71 FntiMNc2fkkMz/PaZ5Q36CA4c2dhqEU+CqexAxzfkqIrZbi1cEc5mfuGx/epFjch2Vjt 4aR9CGwB5FZPlHMrdLUPzhhmk0gQbyKpYZhME/NiTW+fshxcDSWdt+pSKgB292BahjZy 18zLaZgkWc6/S+z4HpmEW/iTQlF8zqnqH/ilEuN9p4luPZsCX1VQgco4XvkY3HPym2HS UGYR5YrxmoCpR8mPGI7UpT51hU2/0HLsIBUj1ii8aRhWXRi1tunB4qiOF53Y5Syxlv3w JJiQ== X-Gm-Message-State: AJcUukfHCCi00Yye2NwURUUG9oBhmTiDx9JD6G9AkDKs9b0/Jm2OKS11 pb5MbVN9tUXGmh7DKs+8gyGgPDYzuh7MQunCX0crZKWA X-Google-Smtp-Source: ALg8bN7ADyaq7r21zoItNnXCJihaiYUYvB/5Cd6LryLxgD8u3dXtTMkqILdwuNCuqX9MSwkKGpwGASvGE0fSVamYHm8= X-Received: by 2002:a63:ab08:: with SMTP id p8mr5223778pgf.87.1546707361475; Sat, 05 Jan 2019 08:56:01 -0800 (PST) MIME-Version: 1.0 References: <20181218012539.52921-1-ferruh.yigit@intel.com> <96c15909-f1f6-5ba9-967b-526c470b9739@intel.com> In-Reply-To: <96c15909-f1f6-5ba9-967b-526c470b9739@intel.com> From: Igor Ryzhov Date: Sat, 5 Jan 2019 19:55:50 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , John McNamara , Marko Kovacevic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] kni: remove ethtool support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 16:56:02 -0000 Hi Ferruh, I answered in another thread. Regarding this patch =E2=80=93 I have no objections now. Best regards, Igor On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit wrote= : > On 12/18/2018 9:20 AM, Ferruh Yigit wrote: > > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: > >> Hi Ferruh, > >> > >> Please, look at my patch http://patches.dpdk.org/patch/48454/ and > consider > >> rebasing your patch over mine. > > > > Sorry about that, yes I will check it today. > > Hi Igor, > > I put some comments on your patch. > > As far as I can see it also has a target to remove current type of ethtoo= l > support, so this RFC should not be a concern to you. > All ethtool support can be removed, when you have an actual solution for > driver > independent ethtool support only a little code needs to be added back. > > Thanks, > ferruh > > > > >> > >> As we discussed with Stephen, KNI needs to supply ethtool_ops with > >> .get_link function, to properly support link status. > >> So we should save ethtool_ops and implement .get_link using standard > >> ethtool_op_get_link. > >> > >> Best regards, > >> Igor > > > > > >