From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id B4E431B4C9 for ; Sat, 5 Jan 2019 17:53:46 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id t13so18827353ply.13 for ; Sat, 05 Jan 2019 08:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=olbf7+IMrr+ArflcOaBR/M6pjLUfUCdR9i5AlAtrC2A=; b=JqJibevQkDp+0cK4LYDqpLYbkYyV62BKpcLQsiI9t3sQGyu3RixpWaJZBwa/vEq1Sh ICwfQ5DkPaowmHEQlSWUKULpxv6PdlkYkzQSDyyXZT62n/ykcjncd29de90CIn6xY589 G+6m00ojfXHyYfZ5j4LFt8DWt67K061sg2+rl0Va1ESsXnCXfSV1KMPMc3bPKs4nDXeZ FaWMfYRlfQTbdOdvjdBeI6jMrdiJeNpTgTrWfePsfMa3rnBXeZHQYZq9iArcUYTpeSKa BMCdJ+7jm8gCJA9GkMVS2ednxXNTzU2qtd/I2NVFzJH1JOPK3BT9xASQC5g4PUBDWaK1 3iBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=olbf7+IMrr+ArflcOaBR/M6pjLUfUCdR9i5AlAtrC2A=; b=d9c0buypQcDbf50Bj2fNsOP9kIMJupsTlQ3q7/KaiDwRl7kSpJyfmEflbO5pz2A1j1 OB5AJIQiEZGbps/llunX0EjDnqCAS5dIgXLR3DqjIMTL6nyrZrzBVU8+0a/dk+Ffgv2x D9SUQn9s+TVBkxIsEawm5x71mMY9wdkhCN+JLLUXWds++EMmR1Gmx1NS3Ualsg1V0x+O hGRMohs043/bXiszhZpZCJcaIh6VS2MyHpENwlD2pUdMkP5a1j8EtaO4vwTUXUIR/0By CdYvif64rAzLgd2tD1HpKb9H7G5Hcn6NVDS2I2hha8+Wk8mHm4nA4gF3BhcSODWPiDjp Ab/Q== X-Gm-Message-State: AJcUukddhW3qw7tgIP9cthLAVizalMDKcsWEuO/gwy3wFNXJkTbBslTm zS637IJlQvRvJA6Q41N5fCdRbYWxcBUHOPxbqwSjhYfMMjM= X-Google-Smtp-Source: ALg8bN6k5cRqYHjq3XLnTyb7jyBTErxR5Yr4FTkT1YPV1uMeJEBFDityqAR0PxCE9b9pT93UEIGSMmkIgZhI52GpEok= X-Received: by 2002:a17:902:2868:: with SMTP id e95mr55288374plb.317.1546707225419; Sat, 05 Jan 2019 08:53:45 -0800 (PST) MIME-Version: 1.0 References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> <7f929055-b55a-e839-9927-96787db88094@intel.com> <7eab0eec-335a-be47-2406-9c989d13e981@intel.com> In-Reply-To: <7eab0eec-335a-be47-2406-9c989d13e981@intel.com> From: Igor Ryzhov Date: Sat, 5 Jan 2019 19:53:34 +0300 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2019 16:53:47 -0000 Hi Ferruh, Thank you for all your comments. The only real purpose of the patch is to support .get_link for all KNI interfaces, not just for those using igb or ixgbe. So I propose to remove ethtool support at all with your patch, and after that, I will add .get_link support again. Yes, I understand that it doesn't implement real link status support, it just relies on the application, that should set link status using sysfs. Regarding the ethtool support in a driver-independent way =E2=80=93 the ide= a is to use the same req/resp queues which are used for some net_device_ops like .ndo_change_mtu or .ndo_set_mac_address. I want to add more types of requests to rte_kni_req_id enum and implement them. It's not an urgent task, so I don't know yet when I'll find time to do it. Best regards, Igor On Tue, Dec 18, 2018 at 9:13 PM Ferruh Yigit wrote= : > On 12/3/2018 2:06 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > What about the patch? > > > > I also support dropping ethtool for ixgbe and i40e, but to save generic > ethtool_ops > > with .get_link implementation, because it's an essential function that > works > > correctly > > after proper implementation of carrier status that was merged into 18.1= 1. > > > > Also, other ethtool operations may be implemented in a > driver-independent way using > > the same concept as for netdev_ops. > > "carrier status" relies on the sample app support also relies on kni > net_device > sysfs interface. > It is good target to have ethtool support in a driver-independent way, > please > share more details and lets discuss them. > > > > > On Mon, Dec 3, 2018 at 4:09 PM Ferruh Yigit > > wrote: > > > > On 11/30/2018 11:38 PM, Stephen Hemminger wrote: > > > On Fri, 30 Nov 2018 22:47:50 +0300 > > > Igor Ryzhov > > wrote: > > > > > >> Current implementation of kni_ethtool_ops just uses correspondin= g > > >> ethtool_ops function of underlying driver for all functions > except for > > >> .get_link. This commit sets kni->net_dev->ethtool_ops directly t= o > the > > >> ethtool_ops of the corresponding driver. > > >> > > >> For unknown drivers (all but ixgbe and i40e) we still use > > >> kni_ethtool_ops with implemented .get_link function. > > >> > > >> Signed-off-by: Igor Ryzhov iryzhov@nfware.com>> > > > > > > Why does KNI still support ethtool which: > > > 1. Only works on a subset of devices > > > 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, > and KNI) > > > > +1 to drop ethtool support, last time we tried concern was anybody > may be using > > it, perhaps we can try again. > > > > > > > > Then again why does KNI exist at all? What is missing from virtio > user which > > > is faster anyway. > > > > > > >