From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 972B6A04B7; Wed, 14 Oct 2020 11:36:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B81A81DDCB; Wed, 14 Oct 2020 11:35:50 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id E978F1DDC9 for ; Wed, 14 Oct 2020 11:35:46 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id g12so2925695wrp.10 for ; Wed, 14 Oct 2020 02:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwMsnMit0rG9P2Gr+A3Y5arX3e8slBA27BcV5nHivvI=; b=Oew+0AVbIPF8SVK/8CN3pdCLpZP7acadpvc7QKg5c+Vm123gk0yb6fA6LD/zGnzMzX ImLtL+8yEhdmW00pSKs8XRoT2bj0ZUnMceFfadCyyrDocRQ8ZiX+vNpSsd6nixLtMLcW AUz53HezYzoy00H8RdjMScCaJ5I2bCF2784zKMR4/tbEZIRZ2Ri0x/GpNLcS5OzuM7rE +SPJxuf0xVWtNLQ/IwO5JLofL7d2MepRLw3YVlsMLTZ45KtbN4A2TNpSZ0NZOs+QbZQk doRucng//S/dZ344FornpBqnAbjDPwTHsu5EwgH60Ngkwey9lOxnN8KAFzFhdc6lmKBy YW/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwMsnMit0rG9P2Gr+A3Y5arX3e8slBA27BcV5nHivvI=; b=fXcFncPVEQ9FCpg3OScssjtnYYgLClsJ7WApR9bgZ76naiFcpTreGr2POaMZXmXuGc HSTuqPtHEefMbd3ZAEnOqBwjYswFosocObAAocxQlVU8jBzjBUoGnudbyFRuwSe5yDjX 7st8v8s2BvVF2fiTKxPf2UWTbhlrBGTqWRjPFcvwE07UaLWfNYbVf9GqyhqsJFpN5HwK /cbkCnzs6NCwyUU+uaV+Y6+oLXKZqZgsYBHnK8FtK9POvInr/Be36XW+87nSR6gQABOQ 37gt7LZ0IBM/vDrz0DXtbYX8MbKZGuxSnny+i3Pkmy2wpm5EjWhW+bqFMXgQJgNMNyE5 rG7Q== X-Gm-Message-State: AOAM531JTIdwSTRXSHsEVChednDKlIakPe/gCEN5pLzH98Hvafq0b/LP PDLk+gpSpltoTpe8hIk1g9EpqvhU5xZd9gcRSN+0BA== X-Google-Smtp-Source: ABdhPJzNNzqhz78GQgBw2KjHDtrpuNv9e5R7cbFpTpxEctrr4u6RH+B56rb5osSLbwZ/Ft1Ee1e41yvIFfPUPWJI8rM= X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr4483795wrt.109.1602668145568; Wed, 14 Oct 2020 02:35:45 -0700 (PDT) MIME-Version: 1.0 References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> <20201014022649.2165524-2-ferruh.yigit@intel.com> In-Reply-To: <20201014022649.2165524-2-ferruh.yigit@intel.com> From: Igor Ryzhov Date: Wed, 14 Oct 2020 12:35:34 +0300 Message-ID: To: Ferruh Yigit Cc: Bruce Richardson , Ray Kinsella , Neil Horman , Thomas Monjalon , Andrew Rybchenko , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, As rte_eth_stats is going to be changed, is it possible to add new counters there? For example, in/out multicast/broadcast packets. Igor On Wed, Oct 14, 2020 at 5:27 AM Ferruh Yigit wrote: > Queue stats will be removed from basic stats to xstats. > > It will be PMDs responsibility to fill queue stats based on number of > queues they have. > > Until all PMDs implement the xstats, a temporary > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched > to the xstats should clear this flag to bypass the ethdev layer autofill > for queue stats. > > Signed-off-by: Ferruh Yigit > --- > config/rte_config.h | 2 +- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > lib/librte_ethdev/rte_ethdev.h | 3 +++ > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/config/rte_config.h b/config/rte_config.h > index 03d90d78bc..9ef3b75940 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -55,7 +55,7 @@ > > /* ether defines */ > #define RTE_MAX_QUEUES_PER_PORT 1024 > -#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 > +#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */ > #define RTE_ETHDEV_RXTX_CALLBACKS 1 > > /* cryptodev defines */ > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 584e720879..9143cfc529 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -164,6 +164,13 @@ Deprecation Notices > following the IPv6 header, as proposed in RFC > https://mails.dpdk.org/archives/dev/2020-August/177257.html. > > +* ethdev: Queue specific stats fields will be removed from ``struct > rte_eth_stats``. > + Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, > ``q_obytes``, > + ``q_errors``. > + Instead queue stats will be received via xstats API. Current method > support > + will be limited to maximum 256 queues. > + Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. > + > * security: The API ``rte_security_session_create`` takes only single > mempool > for session and session private data. So the application need to create > mempool for twice the number of sessions needed and will also lead to > diff --git a/lib/librte_ethdev/rte_ethdev.h > b/lib/librte_ethdev/rte_ethdev.h > index bb7a2b4289..a2e811ca48 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -253,6 +253,7 @@ struct rte_eth_stats { > uint64_t ierrors; /**< Total number of erroneous received > packets. */ > uint64_t oerrors; /**< Total number of failed transmitted > packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation > failures. */ > + /* Queue stats are limited to max 256 queues */ > uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; > /**< Total number of queue RX packets. */ > uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS]; > @@ -2704,6 +2705,7 @@ int rte_eth_xstats_reset(uint16_t port_id); > * The per-queue packet statistics functionality number that the > transmit > * queue is to be assigned. > * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. > + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. > * @return > * Zero if successful. Non-zero otherwise. > */ > @@ -2724,6 +2726,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t > port_id, > * The per-queue packet statistics functionality number that the receive > * queue is to be assigned. > * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. > + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. > * @return > * Zero if successful. Non-zero otherwise. > */ > -- > 2.26.2 > >