From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3E3EA0524; Fri, 23 Apr 2021 14:43:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02A10410ED; Fri, 23 Apr 2021 14:43:54 +0200 (CEST) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id 1C3CF410D8 for ; Fri, 23 Apr 2021 14:43:53 +0200 (CEST) Received: by mail-ed1-f53.google.com with SMTP id e7so57226666edu.10 for ; Fri, 23 Apr 2021 05:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5svaq7cPp1g8dpc2kYcwudWEhbasfdceysmeTbfgjFY=; b=RPpfcK+11KrV5JRwsn6JlT6ij7JyS6aBpw7aeLgC2O6bVDA2HZ1mUQeqH998QvcpdT keXCuI7CQfY32gxANONRjdTmirjt/TW+YcsC7VIFULj8RZQ7KLrxj+R3mwCVr5d68Ggm angxIGu66tjHoZ+k6JMOv9vbSwJIT0UZLLWPVjlTlRWUc5ILFzWn0aL+BQcnGFGNQ01V 8JgMX13NJwAegclSxIfufJ8T+ZbmbCQ02TSv/E6r2Yfv4VpiLW5Q/v40JeAli5taz+L6 N28n2qYe0As4/o3OOyMeII/bU50/SwiToq9wMCtDszWxRWR2K6mQjoLw7HAcxAKPZetQ b+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5svaq7cPp1g8dpc2kYcwudWEhbasfdceysmeTbfgjFY=; b=KiwsHgX8Vtnnl0P34K7X6WvWDw7v7JBZ/lRQqx8icjAMCiN5UNjNskhRLAbpYJ+w7Y f5wSE/H/pnw82TIHLTd9PrgsqoFPIaKxODG5oZB3XwzVuxI/JtMU6nErBhJjCScLdJIj bwM8lyJ1W2GRhGAt6wMyY7Tk7LVjVx0+E+c89vIsJJSpuHDB+h+1KXWg5n+SOHC25N1Z eLOO3ixgZEhs+p/3Gs5DIg/YXtZQfwq/1ZKiRMn4yE9mYAREBsuLuCeXpb422Pn8irGB 1YX4KTfw0GZ9OYCPp/1D7R3gC1Vu1ad5rsPLpUv0gKSmuPLplhUkl9BdIPFBlTeyvrQR w6kQ== X-Gm-Message-State: AOAM533XOaDcbWVHgWaZbdnUgUOSIvTEKksn9kISwyThZzeDocIEbQ/v Y+9oJTOiBDXdhz6Fyyp3CgPfzsrJ+VL0Ykyfu3BpAg== X-Google-Smtp-Source: ABdhPJwQJhKXUGbPoyRpcIPzqaPeopEp5pY65avhSATYqn50u6XAIuGkoCDet/R5IzINKpfeDXl/wpFcMBS2ziG3qrg= X-Received: by 2002:a50:f19d:: with SMTP id x29mr4457415edl.102.1619181832756; Fri, 23 Apr 2021 05:43:52 -0700 (PDT) MIME-Version: 1.0 References: <20201126144613.4986-1-eladv6@gmail.com> <2345640.QMWomeNEm9@thomas> <599cc2f5-467a-a954-29be-e77e3b796784@intel.com> In-Reply-To: <599cc2f5-467a-a954-29be-e77e3b796784@intel.com> From: Igor Ryzhov Date: Fri, 23 Apr 2021 15:43:41 +0300 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Stephen Hemminger , Elad Nachman , dev , dpdk stable , Dan Gora Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, Thanks. I think it would be great to make this configurable, and maybe even make shutdown synchronous by default to preserve the old behavior. I would be grateful if you could spend time on the work and I am ready to review it. Igor On Fri, Apr 23, 2021 at 11:59 AM Ferruh Yigit wrote: > On 4/23/2021 9:41 AM, Igor Ryzhov wrote: > > This patch changes the behavior for KNI interface shutdown. > > Previously we would receive a real response from the driver, now we > > always receive success. > > I think this should be reflected in the docs/release notes. > > > > Hi Igor, > > Make sense, I can add it. > > Meanwhile do you think has a benefit to make shutdown behavior > configurable? > Async/Sync shutdown based on module param? > > > Igor > > > > On Wed, Apr 21, 2021 at 2:07 AM Thomas Monjalon > > wrote: > > > > 12/04/2021 16:35, Elad Nachman: > > > Hi, > > > > > > The new patch is fine by me. > > > > > > Tested several dozens restarts of our proprietary application > without > > > apparent problem. > > > > Series applied, thanks. > > > > > >