From: Igor Ryzhov <iryzhov@nfware.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix vhost guide
Date: Mon, 13 Apr 2015 10:14:22 +0300 [thread overview]
Message-ID: <CAF+s_Fz8fT+3Vhv5q+GuLpMRQVCFDX_9w_efJZrDVJ3PmOe7zg@mail.gmail.com> (raw)
In-Reply-To: <AC251030-A286-4EAC-9449-2D72420F1E24@arccn.ru>
Sorry, I used wrong email address to reply from. This one is correct.
On Mon, Apr 13, 2015 at 10:11 AM, Igor Ryzhov <iryzhov@arccn.ru> wrote:
> Hello, Changchun.
>
> Previous paragraph says «To enable vhost, turn on vhost library in the
> configure file config/common_linuxapp», but string in a code-block is
> «CONFIG_RTE_LIBRTE_VHOST=n». I thought that idea is to use the default
> string from the config file that user have to change, not already changed
> string. So I used the same style.
>
> Regards,
> Igor
>
> 13 апр. 2015 г., в 7:52, Ouyang, Changchun <changchun.ouyang@intel.com>
> написал(а):
>
> Hi Igor,
>
> Good catch, comments as below.
>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org <dev-bounces@dpdk.org>] On Behalf
> Of Igor Ryzhov
> Sent: Thursday, April 9, 2015 12:31 AM
> To: dev@dpdk.org
> Cc: Igor Ryzhov
> Subject: [dpdk-dev] [PATCH] doc: fix vhost guide
>
> Guide says that a configure parameter to choose between vhost cuse and
> vhost user will be introduced in the future, but it’s already added by
> commit
> 28a1ccca41bf.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
> doc/guides/sample_app_ug/vhost.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/vhost.rst
> b/doc/guides/sample_app_ug/vhost.rst
> index 8a7eb3b..df8cd8c 100644
> --- a/doc/guides/sample_app_ug/vhost.rst
> +++ b/doc/guides/sample_app_ug/vhost.rst
> @@ -309,13 +309,12 @@ Compiling the Sample Code
>
> CONFIG_RTE_LIBRTE_VHOST=n
>
> - vhost user is turned on by default in the lib/librte_vhost/Makefile.
> - To enable vhost cuse, uncomment vhost cuse and comment vhost user
> manually. In future, a configure will be created for switch between two
> implementations.
> + vhost user is turned on by default in the configure file
> config/common_linuxapp.
> + To enable vhost cuse, disable vhost user.
>
> .. code-block:: console
>
> - SRCS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_cuse/vhost-net-cdev.c
> vhost_cuse/virtio-net-cdev.c vhost_cuse/eventfd_copy.c
> - #SRCS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_user/vhost-net-user.c
> vhost_user/virtio-net-user.c vhost_user/fd_man.c
> + CONFIG_RTE_LIBRTE_VHOST_USER=y
>
>
> If it wants to guide user how to enable vhost cuse, then I think
> It makes sense to change it into: CONFIG_RTE_LIBRTE_VHOST_USER=n
>
> Thanks
> Changchun
>
>
>
next prev parent reply other threads:[~2015-04-13 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 16:31 Igor Ryzhov
2015-04-08 19:53 ` Butler, Siobhan A
2015-04-13 4:52 ` Ouyang, Changchun
2015-04-13 7:11 ` Igor Ryzhov
2015-04-13 7:14 ` Igor Ryzhov [this message]
2015-04-14 2:34 ` Ouyang, Changchun
2015-04-16 12:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_Fz8fT+3Vhv5q+GuLpMRQVCFDX_9w_efJZrDVJ3PmOe7zg@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).