From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vn0-f51.google.com (mail-vn0-f51.google.com [209.85.216.51]) by dpdk.org (Postfix) with ESMTP id ADFD2C358 for ; Mon, 13 Apr 2015 09:14:24 +0200 (CEST) Received: by vnbf129 with SMTP id f129so16648298vnb.9 for ; Mon, 13 Apr 2015 00:14:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=IrRlFUkRKl6dTQqp+bS3lKPeT7Jq7eg5NDsX3Yrs02g=; b=NOvl6vdoVWheCzrwNyU2tgyldbEPrGPRNoibu4dwjYgiE1F329Nwmkruv8PGg1f3qw q7yvfKTXy7PiBGWCV6Bn85uM/BG2BVUbVRX56VSZhoKxpd19kWQtsXOHBP5R5pvjokVh l3tZqdhtNkBpAjkvD0k4xYsQjd7c3v0QKZnCvrukRt1lODCq4Wk+IbxeByQEl4vAmCJR yhAr3m6wkNUdC5FT3B/NJPtSQsnTj5hpempR48rD6KJsuz1a940pt1wEjugqKSJO8+oK oOj1Ctj2sv/zc6mZSj8NwychCXKT6OUr8sFf1EC0Grf7VwPFGVJXlBox7uWkRF9rNjfv vP4A== X-Gm-Message-State: ALoCoQnM2KK5mrtkbxf0fEnpfF72vmIqtmAeUfLeh9CJkTjVtWTHc785aUdhz1peWlVs7WZ3Xy1k MIME-Version: 1.0 X-Received: by 10.60.133.176 with SMTP id pd16mr11039866oeb.78.1428909263046; Mon, 13 Apr 2015 00:14:23 -0700 (PDT) Received: by 10.60.166.116 with HTTP; Mon, 13 Apr 2015 00:14:22 -0700 (PDT) X-Originating-IP: [95.182.74.2] In-Reply-To: References: <1428510667-6438-1-git-send-email-iryzhov@nfware.com> Date: Mon, 13 Apr 2015 10:14:22 +0300 Message-ID: From: Igor Ryzhov To: "Ouyang, Changchun" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] doc: fix vhost guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 07:14:25 -0000 Sorry, I used wrong email address to reply from. This one is correct. On Mon, Apr 13, 2015 at 10:11 AM, Igor Ryzhov wrote: > Hello, Changchun. > > Previous paragraph says =C2=ABTo enable vhost, turn on vhost library in t= he > configure file config/common_linuxapp=C2=BB, but string in a code-block i= s > =C2=ABCONFIG_RTE_LIBRTE_VHOST=3Dn=C2=BB. I thought that idea is to use th= e default > string from the config file that user have to change, not already changed > string. So I used the same style. > > Regards, > Igor > > 13 =D0=B0=D0=BF=D1=80. 2015 =D0=B3., =D0=B2 7:52, Ouyang, Changchun > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): > > Hi Igor, > > Good catch, comments as below. > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org ] On Behalf > Of Igor Ryzhov > Sent: Thursday, April 9, 2015 12:31 AM > To: dev@dpdk.org > Cc: Igor Ryzhov > Subject: [dpdk-dev] [PATCH] doc: fix vhost guide > > Guide says that a configure parameter to choose between vhost cuse and > vhost user will be introduced in the future, but it=E2=80=99s already add= ed by > commit > 28a1ccca41bf. > > Signed-off-by: Igor Ryzhov > --- > doc/guides/sample_app_ug/vhost.rst | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/sample_app_ug/vhost.rst > b/doc/guides/sample_app_ug/vhost.rst > index 8a7eb3b..df8cd8c 100644 > --- a/doc/guides/sample_app_ug/vhost.rst > +++ b/doc/guides/sample_app_ug/vhost.rst > @@ -309,13 +309,12 @@ Compiling the Sample Code > > CONFIG_RTE_LIBRTE_VHOST=3Dn > > - vhost user is turned on by default in the lib/librte_vhost/Makefile. > - To enable vhost cuse, uncomment vhost cuse and comment vhost user > manually. In future, a configure will be created for switch between two > implementations. > + vhost user is turned on by default in the configure file > config/common_linuxapp. > + To enable vhost cuse, disable vhost user. > > .. code-block:: console > > - SRCS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D vhost_cuse/vhost-net-cdev.c > vhost_cuse/virtio-net-cdev.c vhost_cuse/eventfd_copy.c > - #SRCS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D vhost_user/vhost-net-user.= c > vhost_user/virtio-net-user.c vhost_user/fd_man.c > + CONFIG_RTE_LIBRTE_VHOST_USER=3Dy > > > If it wants to guide user how to enable vhost cuse, then I think > It makes sense to change it into: CONFIG_RTE_LIBRTE_VHOST_USER=3Dn > > Thanks > Changchun > > >