From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id 9ABB35B2A for ; Mon, 18 Feb 2019 14:07:30 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id f132so8556625pfa.6 for ; Mon, 18 Feb 2019 05:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0OhxhP4xsoFUgYClD/2eOMnGN3XcA0gQZscz5Zl9a/E=; b=Nlfmc/U7N2i8JFs+kM/tCx1nQyb6BRfAS4R8cyLUyZ0jTpEed/IrmaQxCo5HIY5AUS NQksgX8/Nyb3lQNr1XiTjs8x7OpArukyyQ2DMtpRhq0kz28WgslV7tES82ctbh+ArEd8 ITfkhP+y5ih3HUi1p6fa5b4QdrBiQ2UhI97DscPFF39Ce98VwU5RpYT39qxZO2TPkLOE nBagRixHtEbOflLop2vCyjogLC0t/3ozIoQ1CswlEYzvPSSTBqKG1bbfR3aRqLXrVBT0 OZMS7WYPP9d2j/ObAV7xl+yQuYRFFW5STCcPqrMz4mS4Y2p+NC3tb4TyuIQaqmxB8rBX Cfgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0OhxhP4xsoFUgYClD/2eOMnGN3XcA0gQZscz5Zl9a/E=; b=hODOtNVsBbhPf46W1Zxiz+oC//UYWNQzewwRppUrgeGu4H0saDMRdrrjm1JlpuiiK/ xHWjSM98vJj5DMgnRI+zG7wD58I2IuEB0qfz5AlHs97Kzjnd2L/Xu261zHIQPhOaZ8FA 5Vrw4qHOzLbqgOlbeJx+ODk/Jyk+f1DWZW85ApCWeRwpalS8c+/2hoBvDEp6aBSQPcgy CQEEKsdskSH/gdtGsT3PMqEctle+6YqkmsTSw1PiIz0WH01OVdCE99Xg4RbCCwtCpa2j jxK05LUmfB9Psa9CQG8VzTOpnwxreuOwunBniVOwALm+fcR3W8lEf3wVAVlkIf84lDRp z1Iw== X-Gm-Message-State: AHQUAuatkDuPXJ5puhAsKcCB8+l0TYrfEDnCD4MrwQ15HP+mh43DePR+ quWYO/My8SMqwCBrP2lw017Ie9nIu/XIThv7izQyRQ== X-Google-Smtp-Source: AHgI3Ia2I/mQxjB23h91LTbwFutxaLrUnZOWsPDEW/FGCNiX/AU4VKiqdtOEXBmPD6BunDNYVctQiR7kV4bsqzqpY/Q= X-Received: by 2002:a63:f553:: with SMTP id e19mr18459825pgk.87.1550495249340; Mon, 18 Feb 2019 05:07:29 -0800 (PST) MIME-Version: 1.0 References: <20181218012539.52921-1-ferruh.yigit@intel.com> <96c15909-f1f6-5ba9-967b-526c470b9739@intel.com> In-Reply-To: From: Igor Ryzhov Date: Mon, 18 Feb 2019 16:07:18 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Thomas Monjalon , John McNamara , Marko Kovacevic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] kni: remove ethtool support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 13:07:30 -0000 Hi Ferruh, Thanks. Should I be a maintainer to ack the patch? Best regards, Igor On Mon, Feb 18, 2019 at 3:33 PM Ferruh Yigit wrote= : > On 2/6/2019 1:12 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > What's the plan with this patch? > > Hi Igor, > > I just sent a deprecation notice for this: > https://patches.dpdk.org/patch/50347/ > > If the deprecation notice approved, requires 3 acks, note will go into > 19.05 > And later this patch can go in 19.08 > > Thanks, > ferruh > > > > > Best regards, > > Igor > > > > On Sat, Jan 5, 2019 at 7:55 PM Igor Ryzhov > > wrote: > > > > Hi Ferruh, > > > > I answered in another thread. > > > > Regarding this patch =E2=80=93 I have no objections now. > > > > Best regards, > > Igor > > > > On Tue, Dec 18, 2018 at 9:17 PM Ferruh Yigit > > wrote: > > > > On 12/18/2018 9:20 AM, Ferruh Yigit wrote: > > > On 12/18/2018 8:20 AM, Igor Ryzhov wrote: > > >> Hi Ferruh, > > >> > > >> Please, look at my patch http://patches.dpdk.org/patch/48454= / > and > > consider > > >> rebasing your patch over mine. > > > > > > Sorry about that, yes I will check it today. > > > > Hi Igor, > > > > I put some comments on your patch. > > > > As far as I can see it also has a target to remove current type > of ethtool > > support, so this RFC should not be a concern to you. > > All ethtool support can be removed, when you have an actual > solution for > > driver > > independent ethtool support only a little code needs to be adde= d > back. > > > > Thanks, > > ferruh > > > > > > > >> > > >> As we discussed with Stephen, KNI needs to supply ethtool_op= s > with > > >> .get_link function, to properly support link status. > > >> So we should save ethtool_ops and implement .get_link using > standard > > >> ethtool_op_get_link. > > >> > > >> Best regards, > > >> Igor > > > > > > > > > >