From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02599460C1; Mon, 20 Jan 2025 11:05:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA5940653; Mon, 20 Jan 2025 11:05:19 +0100 (CET) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id B93AA4027A for <dev@dpdk.org>; Mon, 20 Jan 2025 11:05:18 +0100 (CET) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3ce868498d3so16558905ab.3 for <dev@dpdk.org>; Mon, 20 Jan 2025 02:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1737367518; x=1737972318; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RoJHa/7fcadzXrRut2IcxEDx1TAG9rKOhHH0TvDsfm8=; b=YYemhUjhkPakLmlfjY/YUPNNN9XdEBFqGCM+TDBlJia8ZnGL185zPqoUvHfato9kx1 ASzWXeYzwidjxNZGDdk5r6t9QkBn+myJBckg4VcT9rDITIbDaNUa4ofi8JjWNStXmWmV WrAWHgm6vb0eFmKgSiwSsuP17KUFuSEWaDkDGV02zu1C4ki944I6hXeAokmdYPCpd/iv FAQdHCN6dBsls8eS9fLS1CFL5Qab7eJ2GE8FDfFg/sAxvCKjLSAD4Eu1nluzxZv6IFOO no6/JOzGQFtFZS84sG4NQdFwQOWjj8YXDqnQupeLptz53puzDdU+utCkKfqGu7+B+aMh wOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737367518; x=1737972318; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RoJHa/7fcadzXrRut2IcxEDx1TAG9rKOhHH0TvDsfm8=; b=g9mcc2rPFvrIJDWKtW1nnMgL8PfkiOQfX+sNmEdWffxKmvlMhjKkpew79QCWivCI03 PWmt7iL0FhZHHj8Q2uRJMa3cjha14ngJo8McRicxn18MwkZeg7NjI3tappBfAyBpCd4C evLB4oILlvqSmOxKJoLubIS5uoblG20Ey1gxRtMa2CKyIfkWPe+JKEvTuzwTpcpRDMn4 OfG/32iLwGvXbaDPCCGriz5g1B+5huiBri6kMm89gGuNyU618Ho5Gza3wGwDiA2/qF2Y G9GDFIq15qTmKmNY1JZ72JSQgI4C3tvHQSAyNwczUWQDsJee1cxqYBKktZDnxohbJQbv vxaw== X-Gm-Message-State: AOJu0YwetxCjfYqBU9kxLifavEM4Y8GajTN7/5B3gyA1HCKf5jeg7UuQ ZlZ+//gjPTN+J0C8fNSeQFwPSZEx+jkFFXX3DiALaAil0gaFiCFl3Om4AMBAuoERlsBZGn7nLyj 5iyp1V5rBw8kLQI5yvKr9FMI7YhfO0afexktLYg== X-Gm-Gg: ASbGnct49FTDOwtGW5zyVUgUk+P01PP3Wk5UH06FRxfNBlav2duSwh91xT2IzKtCgvJ 1tVQ5Ws++uPeI9s1ID77ZhzW3ACJkMpVwFqyAj7Ltme9/FBncozxchpDZIIVhsFFh0I6K6sCR8V eWLi+c7RY= X-Google-Smtp-Source: AGHT+IHUYdQjF1sMjtkyINimyGlC7QW9ZiW6ELKgTw4e66rneOqCMcC0VD+12rD0vMHq5a0ceslEviBYkVYMM0g+k3k= X-Received: by 2002:a05:6e02:3cc2:b0:3ce:791d:7f6 with SMTP id e9e14a558f8ab-3cf74487b41mr84335865ab.16.1737367517752; Mon, 20 Jan 2025 02:05:17 -0800 (PST) MIME-Version: 1.0 References: <20250119174643.2162110-1-ariel.otilibili@6wind.com> <20250119174643.2162110-3-ariel.otilibili@6wind.com> <7524c0626a384d458ca64414ca1ff0e4@huawei.com> In-Reply-To: <7524c0626a384d458ca64414ca1ff0e4@huawei.com> From: Ariel Otilibili <ariel.otilibili@6wind.com> Date: Mon, 20 Jan 2025 11:05:07 +0100 X-Gm-Features: AbW1kvb4S9jcpHfDXH3JHTMEVkm0j6uuPFjrvq0JKKNKgBourEKZpn2HHe0wDEg Message-ID: <CAF1zDgaWLj_1sKNvR7pX6Pf8-8pQTxDUm9keUkoqi83dhUc_GQ@mail.gmail.com> Subject: Re: [PATCH 2/2] mempool: turn functions into single-exit ones To: Konstantin Ananyev <konstantin.ananyev@huawei.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com> Content-Type: multipart/alternative; boundary="000000000000bd89be062c206506" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org --000000000000bd89be062c206506 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Konstantin, On Mon, Jan 20, 2025 at 12:44=E2=80=AFAM Konstantin Ananyev < konstantin.ananyev@huawei.com> wrote: > > > > Some functions did not set rte_errno; for avoiding that, they are turne= d > > into single-exit ones. > > > > Bugzilla ID: 1559 > > Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com> > > But reading through public API comments none of these functions are > expected to set rte_errno value. > If rte_mempool_create_empty() forgets to set rte_errno, why it is not > enough just to add missing one in rte_mempool_create_empty()? > Thanks for your feedback. Indeed, only rte_mempool_create_empty() returns a rte_errno https://doc.dpdk.org/api/rte__mempool_8h.html#a82e301ee33ed7a263ceb4582655d= c3ea I'll push a new series with this change. Regards, Ariel --000000000000bd89be062c206506 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hi Konstantin,<br></div><br><div class=3D"gmail_quote= gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 2= 0, 2025 at 12:44=E2=80=AFAM Konstantin Ananyev <<a href=3D"mailto:konsta= ntin.ananyev@huawei.com">konstantin.ananyev@huawei.com</a>> wrote:<br></= div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor= der-left:1px solid rgb(204,204,204);padding-left:1ex"><br> <br> > Some functions did not set rte_errno; for avoiding that, they are turn= ed<br> > into single-exit ones.<br> > <br> > Bugzilla ID: 1559<br> > Signed-off-by: Ariel Otilibili <<a href=3D"mailto:ariel.otilibili@6= wind.com" target=3D"_blank">ariel.otilibili@6wind.com</a>><br> <br> But reading through public API comments none of these functions are <br> expected to set rte_errno value.<br> If rte_mempool_create_empty() forgets to set rte_errno, why it is not<br> enough just to add missing one in rte_mempool_create_empty()?<br></blockquo= te><div>Thanks for your feedback. Indeed, only=C2=A0 rte_mempool_create_emp= ty() returns a rte_errno</div><div><a href=3D"https://doc.dpdk.org/api/rte_= _mempool_8h.html#a82e301ee33ed7a263ceb4582655dc3ea">https://doc.dpdk.org/ap= i/rte__mempool_8h.html#a82e301ee33ed7a263ceb4582655dc3ea</a></div><div><br>= </div><div>I'll push a new series with this change.</div><div><br></div= ><div>Regards,</div><div>Ariel<br></div></div></div> --000000000000bd89be062c206506--