From: Ariel Otilibili <ariel.otilibili@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Reshma Pattan <reshma.pattan@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close
Date: Mon, 24 Feb 2025 17:42:40 +0100 [thread overview]
Message-ID: <CAF1zDgaa+Fg7kV_QFb6KkXZSBDk8F4jkT2O-yRo77Em9Dhbfqw@mail.gmail.com> (raw)
In-Reply-To: <20250224074253.3df64dff@hermes.local>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
Hello Dmitry, hello Stephen;
On Mon, Feb 24, 2025 at 4:42 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> The convention (back from Unix) is that errno is only set on failure.
> Simpler fix would just to silently ignore NULL case.
>
Thanks for your feedback. Here they are addressed,
https://inbox.dpdk.org/dev/20250224164031.587829-1-ariel.otilibili@6wind.com/
[-- Attachment #2: Type: text/html, Size: 833 bytes --]
next prev parent reply other threads:[~2025-02-24 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 16:08 [PATCH 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-16 16:08 ` [PATCH 1/1] " Ariel Otilibili
2025-02-16 16:51 ` Stephen Hemminger
2025-02-23 21:41 ` [PATCH v2 0/1] warn if NULL is passed to rte_pcapng_close Ariel Otilibili
2025-02-23 21:41 ` [PATCH v2 1/1] pcapng: " Ariel Otilibili
2025-02-23 22:04 ` Dmitry Kozlyuk
2025-02-24 15:42 ` Stephen Hemminger
2025-02-24 16:42 ` Ariel Otilibili [this message]
2025-02-24 16:40 ` [PATCH v3 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-24 16:40 ` [PATCH v3 1/1] " Ariel Otilibili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF1zDgaa+Fg7kV_QFb6KkXZSBDk8F4jkT2O-yRo77Em9Dhbfqw@mail.gmail.com \
--to=ariel.otilibili@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).