Re: [PATCH v6 2/2] net/af_xdp: Refactor af_xdp_tx_zc

[Ariel Otilibili <ariel.otilibili@6wind.com>]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hello Stephen,

On Mon, Feb 24, 2025 at 8:25 PM Stephen Hemminger <
stephen@networkplumber.org> wrote:

>
> Please avoid doing assignment in a conditional statement, can be error
> prone.
> Surprised checkpatch doesn't complain about it.
>

Thanks for the feedback. checkpatch did catch them.

Here is the new series,
https://inbox.dpdk.org/dev/20250226200841.2342632-3-ariel.otilibili@6wind.com/

Regards,
Ariel

>
> Better as:
>                         desc = reserve_and_fill(txq, mbuf, umem);
>                         if (!desc) {
>                                 kick_tx(txq, cq);
>                                 desc = reserve_and_fill(txq, mbuf, umem);
>                                 if (!desc)
>                                         goto out;
>

[-- Attachment #2: Type: text/html, Size: 1536 bytes --]